Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adminPanel): Fix max length of link header allowed #5566

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

alexd-bes
Copy link
Contributor

No issue: Fix max length of link header allowed

Changes:

  • There is a default max length allowed for a link header to be parsed using parse-link-header of 2000 characters. Occasionally this is exceeded, which results in an error. This change is to allow us to set our own limit in the env variables, and to get vite to carry this var through

Copy link
Contributor

@jaskfla jaskfla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find (and wild that we have links that long??)

Left a tiny suggestion, but not sure if we like/want the explicitness of the current implementation so pre-approving. Thanks for this fix!

@alexd-bes alexd-bes merged commit 07e1277 into dev Apr 9, 2024
43 checks passed
@alexd-bes alexd-bes deleted the fix-maxlength-header-exceeded branch April 9, 2024 00:32
@jaskfla jaskfla mentioned this pull request Apr 11, 2024
1 task
@rohan-bes rohan-bes mentioned this pull request Apr 22, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants