Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Specs #11

Open
alvinkatojr opened this issue Jun 30, 2020 · 0 comments
Open

Failing Specs #11

alvinkatojr opened this issue Jun 30, 2020 · 0 comments

Comments

@alvinkatojr
Copy link

alvinkatojr commented Jun 30, 2020

The beyonic gem has about 38 failing specs caused by wrong data types. The errors are:

  • NoMethodError: undefined method 'each_pair' for #<Array:0x00007ff3606d7440> Did you mean? each_slice
  • NoMethodError: undefined method 'each' for "{'id': '1234', 'name': 'Lucy'}":String

Reproduction steps are simple:

  1. cd into beyonic gem and run rspec spec

Using git blame I've been able to narrow down the problem to these specific lines introduced by @KayLuke.

Reverting the code back to the implementation by @ogerman fixes the first errors and adjusting the value of the metadata property on another spec fixes the later.

I have a branch with fixes for these test failures, happy to send in a PR to resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant