Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGDSTRM-9146 - Admin server does not return latest from all partitions #222

Merged
merged 7 commits into from
Aug 24, 2022
Merged

MGDSTRM-9146 - Admin server does not return latest from all partitions #222

merged 7 commits into from
Aug 24, 2022

Conversation

biswassri
Copy link
Contributor

No description provided.

@biswassri biswassri marked this pull request as draft August 18, 2022 20:17
@biswassri biswassri marked this pull request as ready for review August 22, 2022 20:53
@MikeEdgar MikeEdgar added this to the 0.12.0 milestone Aug 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

86.0% 86.0% Coverage
0.0% 0.0% Duplication

MikeEdgar
MikeEdgar approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks @biswassri

@biswassri biswassri requested a review from rareddy August 23, 2022 17:27
rareddy
rareddy approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@rareddy rareddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I do not think I quite followed the lamda based final call that brings everything together :) just that I was never used StreamSupport class before

@biswassri biswassri merged commit 3adf9b3 into bf2fc6cc711aee1a0c2a:main Aug 24, 2022
@biswassri biswassri deleted the latest-records-changes branch August 31, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeEdgar MikeEdgar MikeEdgar approved these changes

@rareddy rareddy rareddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
3 participants
@biswassri @rareddy @MikeEdgar