Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstart: install inotify-tools only once (avoid CHEF-3694 warning). #239

Conversation

jperville
Copy link
Contributor

This PR avoids the resource-cloning (CHEF-3694) warning that triggers when deploying more than one container as upstart services.

Symptoms of the problem:

==> default: [2014-11-18T08:35:44+00:00] WARN: Cloning resource attributes for package[inotify-tools] from prior resource (CHEF-3694)
==> default: [2014-11-18T08:35:44+00:00] WARN: Previous package[inotify-tools]: /tmp/vagrant-chef-3/chef-solo-1/cookbooks/docker/providers/container.rb:490:in `service_create_upstart'
==> default: [2014-11-18T08:35:44+00:00] WARN: Current  package[inotify-tools]: /tmp/vagrant-chef-3/chef-solo-1/cookbooks/docker/providers/container.rb:490:in `service_create_upstart'

The reason is that the generated upstart service depends on the inotify-tools package (which must be present at compile-time since the docker_cmd commands run at compile-time); since this package is installed as a technical detail, I think that it should indeed be installed from within the docker_container LWRP as today and not in an external recipe.

@tduffield
Copy link
Contributor

I like the implementation. Consider it merged.

tduffield pushed a commit that referenced this pull request Nov 19, 2014
…s-only-once

Upstart: install inotify-tools only once (avoid CHEF-3694 warning).
@tduffield tduffield merged commit 6b1746d into sous-chefs:master Nov 19, 2014
@jperville jperville deleted the chef-3694-install-inotify-tools-only-once branch September 21, 2015 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants