Add CI build with --minimal-versions

[bheisler]

Should verify that Criterion.rs builds correctly with this flag, to ensure that the lower-bounds for dependencies are correct.

[Eh2406]

I got it working for cargo, and am happy to help with in other repos.

[bheisler]

That would be very helpful!

I've tried using -Z minimal-versions myself. It looks like num 0.1.0 doesn't compile on Rust 1.28. I haven't yet figured out how to adjust Criterion.rs' Cargo.toml file to remove the transitive dependency on num 0.1.0.

[Eh2406]

Unfortunately I am unavailable to work on OSS stuff for the next week. In the meantime, some notes on tracking this stuff down: rust-lang/cargo#5657 (comment)

[Eh2406]

So I have spent some time looking into it.

• you use as_fail witch was introduced in failure = "0.1.2" so that should be bumped.
• removing num 0.1.0 this can be done by adding a chrono = "0.4.1"
• removing winapi 0.2.4 is hard without depending on it for normal resolution, but can be done.
• serde_derive_internals and pest_derive can be fixed by adding a quote = "0.3.15"

Some of these changes should probably be upstreamed, iif the upstream crates want to sport minimal-versions. Specifically, a large number of synthetic deps are only required if handlebars is on. That would be a pain to do with a feature that activates other deps, but easy to do by requiring a version of handlebars that sports minimal-versions.

[bheisler]

Awesome! Thanks for the help.

[Eh2406]

Just an update waiting on a release of env_logger with rust-cli/env_logger#101 then I can make a PR to handlebars. When that is released I can get criterion working with minimal-versions. The end is in sight!

[bheisler]

Reopening this - I still need to add a CI build to ensure that this continues to work.