Pull upstream changes #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original example in .md looks like tab separated since its rendition is ugly, but it is just that -- spaces were not used, not tabs. Just so it might come handy (may be there is a command for that) to display spaces and tabs for content in clipboard you could use smth like $> xsel -o | sed -e 's, ,·,g' -e 's,\t,⇰,g' onset·duration⇰response_time⇰correct⇰stop_trial⇰go_trial 200⇰200⇰0⇰n/a⇰n/a⇰n/a%
More work needs to be done to make it all uniform and factually correct. In "theory" markdown sources should use tabs. HTML (and PDF) rendering should provide nice rendition of those while layouting into a proper tabular presentation and using some unicode characters to depict tab symbols. For now -- note should suffice
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
this commit rewrites the fieldmaps subsection to better allocate the proposed changes, while making its structure more consistent with the previous contents of the section.
as this important principle was buried in the bottom of the fieldmaps section.
Co-authored-by: Chris Markiewicz <effigies@gmail.com> Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
Co-authored-by: Taylor Salo <tsalo006@fiu.edu>
[MISC] add remi as maintainer
#653 (comment) Co-authored-by: Teon L Brooks <teon.brooks@gmail.com>
Co-authored-by: Teon L Brooks <teon.brooks@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
[FIX] Fixing template string on electrodes for eeg and ieeg.
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
[FIX] add paragraph on MEG specific "markers" suffix in MEG spec
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
[MISC] add brief note that TSV example in the spec may currently use either tab or space characters
The next line following the table would otherwise be displayed as an extra row in the table. This was the case directly following the "Specific EEG fields MUST be present" table containing the `EEGReference`.
[FIX] Added white space after table
[FIX] Rewrite the MRI/fieldmaps subsection for consistency with the rest of specs
update Contributing with info on how to respond to reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.