-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pdf version of spec #135
Comments
Hi @sappelhoff, On the website under The BIDS Specification it does currently link out to the latest stable version of the specification on readthedocs. Previously the pdf spec was on the website at that location, but I am not aware of where the pdf link currently is promoted. May you please direct me to where it may be and I will update it? |
right! I forgot about this. So currently we do not have a pdf spec. Correct? |
That is right as far as I know. There is a nice plug-in that exports all the markdown files into pdfs and there is an option to combine them and set the path (default is the same directory as the md files). I can investigate and see how this works so we can get a built pdf into the repo |
thanks @franklin-feingold, this sounds perhaps worth an experiment. A portable (i.e., not online and a single file) of the specification would perhaps be good to have. I'll close this issue however, because its main purpose is "solved" |
Thanks @sappelhoff & @franklin-feingold. Just commenting that I had the link in the documentation for BEP001, it isn’t linked from the website at the moment (as Franklin said). No need to track down an incorrect link 🕵🏼♀️😁 |
I think for the portable (pdf) specification, it should be of the latest stable version (versus latest). I think we would want the portable version to be something that we support and being the latest stable version we support. This can be part of the release protocol. WDYT? In the interest of keeping PRs to small manageable reviews and additions, I will wait until we have worked through #137 before adding in how the pdf generation will work. Though, in the meantime I will PR the latest stable version pdf (v1.1.2) before fleshing out that step in the release protocol (if you agree) so at least we have it in the repo. |
this is how it will roughly look - https://github.com/franklin-feingold/bids-specification/blob/pdf_spac/BIDS-Specification_v1.1.2.pdf - still a WIP, I want to add a TOC and brief title to more resemble the previous pdfs. |
sounds like a great plan @franklin-feingold thanks for tackling it.
looks good to me. Some points:
|
To answer your point -
Just a note - I am going to reopen this issue and broaden the name out to pdf version of the specification since this issue has broadened a bit and I think this issue is fine to track this pdf development |
small update - still WIP, but have another iteration of the pdf. There are still 3 outstanding issues I see:
The pdf-exporter repo is https://github.com/zhaoterryy/mkdocs-pdf-export-plugin I am also going to explore possible alternatives |
Hi folks, Just wanted to ping this issue. I work with industrial collaborators, and they love BIDS: Every time a pharma company transfers data they require a Data Transfer Specification (DTS), now lots of the DTS text can be replaced with "We use BIDS". However, for record keeping / due diligence they want to be able include a fixed copy of the standard, i.e. a PDF. Having viewed the PDFs, here are some minor/major things to consider:
|
I wonder if meanwhile it is better to keep a PDF which gets more and more severity outdated, or add a redirect for https://bids.neuroimaging.io/bids_spec.pdf to just go to https://bids-specification.readthedocs.io ? or is PDF version is feasible to achieve in a short time? (it seemed to work, although the last version posted is no longer available for preview @franklin-feingold) |
Just wanted to newly +1 this... PDF is still need and important for industrial users and, e.g., other standards efforts that want a single fixed document to study. |
I agree a fixed PDF is very useful, and this should be a priority. The annoying thing is that RTD can usually do PDF builds alongside HTML builds. I guess this is a mkdocs vs Sphinx thing. Franklin found a plugin that seems to do what we want (though his link is now dead...), but I don't know if activating it on RTD will get us the PDF build for free, or if we would need to upload it somewhere else. It wouldn't be too hard to have a |
Indeed, a to-the-minute PDF is not what's important, but rather a PDF for each major release. |
Here is an example combined PDF generated by mkdocs-pdf-export-plugin: combined.pdf It lacks a ToC, and any versioning information. |
Oh, nice. That looks better. Though I don't see a version... |
NICE! Thank you for looking back into it! Later might be worth enhancing PDF version with URLs for every section to make it easy to get to the updated version PS glancing over PDF helped already to identify #361 -- there is a good value of having a "hard copy"! ;-) |
oh - long vertically tables seems to be cut as well :-( see the one for Units |
Hi everyone! I spent some time working on this issue. I wanted to explore a new package to convert from markdown to pdf. I went with pandoc after looking up sphinx and pandoc. Here is the pdf I was able to generate: Changes made:
Problems with this solution:
Most of the above problems with the solution can be potentially solved. However, would appreciate thoughts on how much of a priority these are and which takes priority over the other. More details on the PR: #375 |
Thank you @Arshitha ! This seems to be some progress. Here are a few more snagging issues with the PDF:
|
Hi folks, I had the chance to work on some of the bugs pointed out by @nicholst. Some background on pandoc. It's a powerful haskell library that converts files from one markup format to another. To create a pdf from multiple markdown files, it creates one large LaTeX file which is then converted to a pdf using Here are two versions of the pdf that I was able to generate using pandoc with different options:
Other things to note:
Also, in both versions of the pdf, I was able to fix the tabular text overflow:
I'd like appreciate feedback on these changes before I proceed to create a PR with these changes. |
awesome work @Arshitha!
yes I think removing all internal links is preferable to having some work and some others not. Is it possible to remove the links during the build of the doc? Because we cannot remove the links in the spec itself just for the sake of the pdf. Another question: Internal links in the same .md seem to work --> would it be possible to just remove cross .md links?
Nice, IMO this is a priority. PS: tagging @yarikoptic to make sure he sees this after his recent post: #375 (comment) |
@sappelhoff Yes, it's possible to remove only cross .md files without affecting the original .md files. |
Amazing work @Arshitha ! Thanks for the push! I didn't have time to crawl through each PDF, but one quick thought on Appendix IV, Entity Table... there is simply no way that a wide table like this will ever render... I mean you could try to do a landscape page, but if some day we add more entities it'll again run out of space. So! I would propose that we simply need to have a reasonable limit and that after a table gets 'so wide' (how wide? dunno) it needs to be broken into successive stacked tables. |
could you please also some kind of a "TODO: fix/reenable cross .md links in .pdf" issue, so there would be a note to have it addressed properly in the future? |
version 2 is indeed better with not polluting with all the chapter numbers etc
even more fun:
Overall -- so nice and so worth merging and addressing any of these or detected later issues later and one at a time ;) |
but indeed version 1 provides most stable and less buggy rendering, so I would vote for it instead ;) |
Great! Thanks, everyone for the feedback. Will update the PR soon. |
Again, congrats to @Arshitha and the whole team for getting the PDF version up and running so quickly. I think this Issue can be closed now, but there's one last thing: How is the BIDS community supposed find the PDF version? I searched the Read The Docs site and the BIDS website... I couldn't find any links to the PDF version. Presumably there should be reference to it on the webpage here: https://bids.neuroimaging.io/specification.html and, if not implicitly within RTD, in the landing page |
nope, you are right, this is still on the To Do list.
Yes, I would put a short paragraph on each: (1) the website, and (2) the landing page of the spec. |
I can propose a PR... but what's the target URL I should use for the PDF? |
cool, would be much appreciated 👍 on the zenodo page, you can see this small snippet saying:
so I think we should use this URL: |
I am closing this now. We only need to upload the PDFs between versions 1.0.0 and 1.3.0 to Zenodo to finish this process, and that is tracked in #407 |
https://bids.neuroimaging.io/bids_spec.pdf does currently not link to the most recent version of the spec, which is as @KirstieJane pointed out 1.1.2
This should be updated and I think we should automate this in our release cycles.
The text was updated successfully, but these errors were encountered: