-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "DRAFT" watermark (or similar) to non-stable rendered spec #373
Comments
Thanks for writing this up @sappelhoff & for thinking about it @franklin-feingold! The idea we had in the meeting was potentially changing the colour of the theme....that seems more customisable, right? Maybe purple rather than blue? (something like that) Just pinging here incase anyone with read the docs skillz has ideas 😃 |
The decision to use mkdocs instead of sphinx puts us in a very difficult-to-customize situation. I think to do something like this, we'll probably need to write our own plugin. |
Would it be so hard to switch? We could try a "translation" in a different repo that is private for now (or at least not promoted) and check the progress ... and if we find that it's:
... we could take down the markdown and replace with RST? |
in a short skype call we discussed that going from markdown to RST would be a huge amount of work ... and currently not warranted. The best course of action to solve the present issue would be to write a plugin using Python: |
I was checking out the different pages rendered for our spec, and realized (contrary to what I thought) that all of them have an indication of what they are.
That got me thinking again why (for what purpose) we need the change of color theme (or watermark, or disclaimer that it's a draft). Could you please clarify once more @KirstieJane? Is it because few people know the meaning of a version number's |
Thanks @sappelhoff - the point is that the suffix on the version is too easy to miss (and potentially the point that you made about people not knowing what the suffix means). But mostly that if you glance at the page its quite subtle. In the url there's a difference between The goal is to just make the page very quickly look very different to the accepted standard. |
Spent a little bit poking at this. I think conditionally fiddling with CSS should be pretty easy. I'll see what I can do. If we want to have a warning banner, there isn't a good injection point in the material theme, so we might need to fork the theme. But that's not a huge problem, IMO. |
thanks for the clarification @KirstieJane!
looks super nice IMO. +1 to include this |
I LOVE IT @effigies!! 🚀 |
According to @franklin-feingold, this issue was brought up in a recent steering group meeting:
Intro
We are rendering the specification in several flavors, such as:
-dev
appendix to the version of the spec in the header of the rendered spec. This version is not currently released/accepted, but it will becomestable
eventually.Problem
However, we are also rendering some development branches, such as the one for derivatives. Currently, this development branch "looks" similar to the "stable" rendered spec. This is a problem, because users may accidentally use this version of the specification for formatting datasets, although this is merely a development branch and subject to change.
Solution
A potential solution would be to add a watermark or similar sign to all renderings that are not either
What I have looked into so far
This leaves me with the only feasible option at this point: For every rendered development version (currently only derivatives), we can edit this line in the sourcecode:
bids-specification/mkdocs.yml
Line 1 in b6d7099
Opinions and alternatives are welcome, I am not super happy with this solution.
The text was updated successfully, but these errors were encountered: