Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Add filename template legend #1259

Merged
merged 5 commits into from
Aug 30, 2022

Conversation

Remi-Gau
Copy link
Collaborator

closes #1198
replaces #1219

let's see how this one goes

@codecov
Copy link

codecov bot commented Aug 29, 2022

Codecov Report

Merging #1259 (649e4e4) into master (b3afa2a) will decrease coverage by 0.09%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
- Coverage   88.33%   88.24%   -0.10%     
==========================================
  Files           6        6              
  Lines        1020     1029       +9     
==========================================
+ Hits          901      908       +7     
- Misses        119      121       +2     
Impacted Files Coverage Δ
tools/schemacode/bidsschematools/render.py 92.83% <77.77%> (-0.35%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@effigies effigies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for paring it down! It is much easier to think about when it's just the heart of it. Some small suggestions that should have no impact on the render but tighten up the function a bit.

tools/schemacode/bidsschematools/render.py Outdated Show resolved Hide resolved
tools/schemacode/bidsschematools/render.py Outdated Show resolved Hide resolved
tools/schemacode/bidsschematools/render.py Outdated Show resolved Hide resolved
Remi-Gau and others added 2 commits August 30, 2022 09:57
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 😄

@sappelhoff sappelhoff merged commit aec0a21 into bids-standard:master Aug 30, 2022
@sappelhoff
Copy link
Member

Thanks @Remi-Gau

@Remi-Gau Remi-Gau deleted the add_legend branch September 14, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add legend below filename templates
4 participants