-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add filename template legend #1259
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1259 +/- ##
==========================================
- Coverage 88.33% 88.24% -0.10%
==========================================
Files 6 6
Lines 1020 1029 +9
==========================================
+ Hits 901 908 +7
- Misses 119 121 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for paring it down! It is much easier to think about when it's just the heart of it. Some small suggestions that should have no impact on the render but tighten up the function a bit.
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 😄
Thanks @Remi-Gau |
closes #1198
replaces #1219
let's see how this one goes