-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add generic metadata from BEP22 to MRI #1396
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1396 +/- ##
=======================================
Coverage 87.93% 87.93%
=======================================
Files 16 16
Lines 1351 1351
=======================================
Hits 1188 1188
Misses 163 163 ☔ View full report in Codecov by Sentry. |
I am not entirely sure if some of those have existing DICOM tags for MRI data. BodyPart for PET mentions "DICOM Tag 0018, 0015 Body Part Examined", but I am not sure how it is for MRI data. @neurolabusc if you have any hints on the DICOM fields for those metadata it'd be much appreciated. |
The DICOM Body Part Examined Attribute (0018,0015) is optional (Type 3). It is often included in MRI scanners with most vendors using |
@Remi-Gau do you have source data exemplars for proposed tags like |
I actually do not. Those are metadata being added to the BIDS MRS extension (see for example here:
I am just trying to also add them to the MRI datatypes to help have more internal consistency within BIDS. Random question: would there be an issue in adding those to BIDS AND DICOM ? |
@Remi-Gau your question is timely. The DICOM Executive Committee is encouraging the collaboration between the BIDS steering committee and the DICOM Magnetic Resonance Work Group (WG-16). The Work Groups have representatives from all the manufacturers. While things take time to trickle through, it is an opportunity to create a virtuous loop between what users need and how different manufacturers refer to items. |
Go for it, or I can tomorrow. |
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Opened #1593. |
8c6f280
to
3664403
Compare
removed sampled metadata as this is taken care of in #1593 |
@markmikkelsen Trying to get a handle on this. Do we have example DICOMs that generate these additional terms? How do MRS converters determine them? |
WaterSuppression: optional | ||
WaterSuppressionTechnique: optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@effigies DICOM tag (0018,9025) fits these, but the value is not boolean as is proposed in #1377. The DICOM tag also covers OuterVolumeSuppression
that the MRS BEP includes (which would be the FAT
value in DICOM).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do we want to add something like the following to WaterSuppression
:
Corresponds to DICOM Tag 0018, 9025
SpectrallySelectedSuppression
.
If present and notNONE
, then this value SHOULD be True, otherwise False.
And the following to WaterSuppressionTechnique
?
Corresponds to DICOM Tag 0018, 9025
SpectrallySelectedSuppression
.
May be omitted if the value isNONE
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me! And the same would be the case for OuterVolumeSuppression
.
I want to point out that most MR manufacturers don't even use the DICOM format to export/store MRS data. They use their own format. Hence why we designed the NIfTI-MRS format. If MRS datasets are "DICOM" formatted, manufacturers alter them to their own specifications. So, I feel conforming MRS metadata in BIDS to DICOM is limiting what MRS users actually need for sharing data in BIDS format. Is there a reason why BIDS should conform so much to DICOM? |
Perhaps @wtclarke can provide insight. @markmikkelsen while BIDS is distinct from DICOM, it is useful to use the same terminology when it is already established in one standard. Furthermore, the BIDS steering group is actively collaborating with the relevant DICOM working groups (composed of engineers from the manufacturers) to establish common terminology where none exists. While this does slow down the process, the aim is for manufacturers to move from private DICOM tags or private manufacturer data formats to public DICOM tags. So while current MRS data may not use DICOM or public tags, the goal is in the future they will be able to. It makes sense to generate new terms when the existing ones are ambiguous or where manufacturers use competing terms. However, it makes sense to involve the manufacturers in the dialog to harmonize our terminology. |
Thanks, @neurolabusc—that's very helpful to know! I'm glad the manufacturers are working together to better harmonize terminology. As you know, it's been a particularly challenging issue for MRS software developers. |
Coming back to this from the MRS-BEP:
As far as I am aware, these have no equivalent DICOM tags but are very useful to the understanding of measurement of outcomes data outcomes of MRS users (e.g., see our multi-site paper)
These are relevant to parallel RF transmission in MRI and MRS, but they do not seem to have any DICOM tags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a domain expert, but as far as I can tell this looks reasonable to me. Thanks!
Aim
Adds metadata to MRI and PET that either already exist in other modalities (BodyPart*) or are part of BEP22 (MRS).
See comment #1377 (comment)
This should: