You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As discussed in #1410
Currently, bids-validator checks the first columns in channels.tsv and throws a [CODE72] MISSING_TSV_COLUMNS_IEEG_CHANNELS error if the first columns are not all required columns, i.e. if the order of the columns is wrong.
Ideally ,the error message should in this be more precise. When all required columns are present, but not in the right order, it should throw an error that is something like: WRONG_ORDER_TSV_COLUMN_IEEG_CHANNELS
The corresponding source code I think can be found here, where each single column name is checked to be at the correct position, e.g. checkheader('name', 0, file, 72)
A solution might be to add a new method before the positional checks that checks simply if all required columns are present. If not, then we get the MISSING error. We would then also change the error code in the checkheader method to a different error code which would give us information about the wrong order.
Would this be the preferred way to go?
I am happy to contribute to this, but I have no prior experience in JS so it might be a bit bumpy
The text was updated successfully, but these errors were encountered:
I think you are on the right track, and improving the error message in this way would be a help to dataset curators 👍 Maybe @rwblair can lend you a hand with the details.
As discussed in #1410
Currently, bids-validator checks the first columns in channels.tsv and throws a [CODE72] MISSING_TSV_COLUMNS_IEEG_CHANNELS error if the first columns are not all required columns, i.e. if the order of the columns is wrong.
Ideally ,the error message should in this be more precise. When all required columns are present, but not in the right order, it should throw an error that is something like: WRONG_ORDER_TSV_COLUMN_IEEG_CHANNELS
The corresponding source code I think can be found here, where each single column name is checked to be at the correct position, e.g.
checkheader('name', 0, file, 72)
A solution might be to add a new method before the positional checks that checks simply if all required columns are present. If not, then we get the MISSING error. We would then also change the error code in the
checkheader
method to a different error code which would give us information about the wrong order.Would this be the preferred way to go?
I am happy to contribute to this, but I have no prior experience in JS so it might be a bit bumpy
The text was updated successfully, but these errors were encountered: