Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel columns: split cases "MISSING" and "WRONG_ORDER" #1411

Closed
richardkoehler opened this issue Feb 1, 2022 · 1 comment · Fixed by #1441
Closed

Channel columns: split cases "MISSING" and "WRONG_ORDER" #1411

richardkoehler opened this issue Feb 1, 2022 · 1 comment · Fixed by #1441
Labels
effort: medium Estimated medium effort task impact: low Estimated low impact task

Comments

@richardkoehler
Copy link

As discussed in #1410
Currently, bids-validator checks the first columns in channels.tsv and throws a [CODE72] MISSING_TSV_COLUMNS_IEEG_CHANNELS error if the first columns are not all required columns, i.e. if the order of the columns is wrong.

grafik

Ideally ,the error message should in this be more precise. When all required columns are present, but not in the right order, it should throw an error that is something like: WRONG_ORDER_TSV_COLUMN_IEEG_CHANNELS

The corresponding source code I think can be found here, where each single column name is checked to be at the correct position, e.g.
checkheader('name', 0, file, 72)
A solution might be to add a new method before the positional checks that checks simply if all required columns are present. If not, then we get the MISSING error. We would then also change the error code in the checkheader method to a different error code which would give us information about the wrong order.

Would this be the preferred way to go?

I am happy to contribute to this, but I have no prior experience in JS so it might be a bit bumpy

@sappelhoff
Copy link
Member

I think you are on the right track, and improving the error message in this way would be a help to dataset curators 👍 Maybe @rwblair can lend you a hand with the details.

@sappelhoff sappelhoff added effort: medium Estimated medium effort task impact: low Estimated low impact task labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: medium Estimated medium effort task impact: low Estimated low impact task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants