Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support phase functional MRI data #834

Closed
tsalo opened this issue Sep 17, 2019 · 3 comments · Fixed by #835
Closed

Support phase functional MRI data #834

tsalo opened this issue Sep 17, 2019 · 3 comments · Fixed by #835

Comments

@tsalo
Copy link
Member

tsalo commented Sep 17, 2019

Per bids-standard/bids-specification#128 and bids-standard/bids-specification#312, phase fMRI data are supported as a suffix (_phase) in the func datatype. It doesn't look like that change has been pushed to the BIDS validator (at least as of the current latest release on DockerHub last month).
@effigies
Copy link
Collaborator

Sure. Want to add it to:

https://github.com/bids-standard/bids-validator/blob/731b8aee3f615760044f3ec7962e52f43c87b3b7/bids-validator/bids_validator/rules/file_level_rules.json#L119-L141

@tsalo
Copy link
Member Author

tsalo commented Sep 17, 2019

Absolutely! I didn't realize that was all there was to it.

@tsalo tsalo mentioned this issue Sep 17, 2019
Merged
@effigies
Copy link
Collaborator

I'm not positive it is, but it will at least get us started, and then a more experienced reviewer should be able to point you to any other changes needed.

@irisgroen irisgroen mentioned this issue Jan 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add functional phase data patterns to file_level_rules tsalo/bids-validator
2 participants
@effigies @tsalo