deirokay.validate() without a value for the save_to parameter resulting in NameError

[lfenzo]

Experienced while trying call deirokay.validate() without providing a value for save_to. As in the source code, the save_to_fs variable is accessed regardless of the value in save_to (which defaults to None in the function definition) resulting in a NameError: free variable 'save_to_fs' referenced before assignment in enclosing scope. However, the "Getting started" example in the documentation somehow works without passing save_to.

deirokay/deirokay/validator.py

Lines 102 to 122 in 546e5d1

	if save_to:
	save_to_fs = fs_factory(save_to)
	if isinstance(save_to_fs, LocalFileSystem) and not save_to_fs.isdir():
	raise ValueError('The `save_to` parameter must be an existing'
	' directory or an S3 path.')
	if isinstance(against, str):
	save_format = save_format or splitext(against)[1].lstrip('.')
	validation_document = fs_factory(against).read_dict()
	else:
	save_format = save_format or 'yaml'
	validation_document = deepcopy(against)
	assert save_format.lower() in ('json', 'yaml', 'yml'), (
	f'Not a valid format {save_format}'
	)
	# Render templates
	template = dict(
	series=lambda x, y: get_series(x, y, read_from=save_to_fs),
	**(template or {})
	)