-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to call 'plugins' from the command-line #101
Comments
+1 @heuermh had expressed interest in this as well. |
Pull request coming shortly, Frank :-) |
Wunderbar! |
+1 On Thu, Feb 13, 2014 at 12:20 PM, Timothy Danford
|
Sorry for coming late to the party here, looking at the current PluginExecutor I'm still missing a few things. How would an implementation of AdamPlugin add new command line parameters? How would an implementation of AdamPlugin not part of the adam build get added to the classpath? |
Yeah, we (Carl and I) talked about that -- especially the bit about specifying command-line arguments. We decided to file the pull request earlier rather than later, but these are great ideas and I agree that they're necessary. Want to file an issue or two? And then if you'd like to do some work, I'd be happy to review a PR ... or vice-versa, if I can find the time this weekend. |
Right now, each individual command-line ... command, that we run, is written as a separate AdamCommand and made a part of the adam-cli package.
That's great for common commands that are useful to everyone -- but in the future, users will want to write commands to execute on a Spark cluster with ADAM, without necessarily compiling the command into the adam-cli module itself.
This suggests that we might define an interface and an execution harness for "plugins," which would be dynamically-loaded code, conforming to a particular interface, that can be executed (by fully-qualified class name) from the command line.
The text was updated successfully, but these errors were encountered: