Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow list of commands to be injected into adam-cli AdamMain #132

Closed
heuermh opened this issue Feb 22, 2014 · 3 comments
Closed

Allow list of commands to be injected into adam-cli AdamMain #132

heuermh opened this issue Feb 22, 2014 · 3 comments

Comments

@heuermh
Copy link
Member

heuermh commented Feb 22, 2014

The list of commands in AdamMain is private, so outside of the PluginExecutor mechanism, adding new commands requires modifying this list and rebuilding; this also introduces a circular dependency between the adam build and an external project.

Adding a new constructor to AdamMain with a reference to the list of commands as a parameter would allow the list to be provided by dependency injection (e.g. via Guice).

https://code.google.com/p/google-guice/

@karenfeng
Copy link
Contributor

Hey @heuermh, I was thinking about working on this issue. Are you already working on it, or can I go ahead?

@heuermh
Copy link
Member Author

heuermh commented Jun 17, 2014

@karenfeng I don't have time to work on it now, so if you want to pick it up, please do so. I'll try to help where I can.

@heuermh
Copy link
Member Author

heuermh commented Mar 24, 2016

Fixed by #762 and #854

@heuermh heuermh closed this as completed Mar 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants