We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Hadoop configuration from the SparkContext associated with an ADAMContext needs to be accessible for subclasses to access the FileSystem
[INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] .../org/dishevelled/bio/adam/BiojavaAdamContext.java:[136,52] sc has private access in org.bdgenomics.adam.rdd.ADAMContext
Alternately, we could increase the visibility of the getFs... methods from private[rdd] to protected.
getFs...
private[rdd]
protected
The text was updated successfully, but these errors were encountered:
Ah, I hadn't thought of the Java access patterns here. I think we should just make the sc field of ADAMContext public again.
sc
ADAMContext
Sorry, something went wrong.
The workaround is not so bad, I wrap sc in the constructor into a JavaSparkContext field
public class MyAdamContext extends ADAMContext { private final transient JavaSparkContext javaSparkContext; public MyAdamContext(final SparkContext sc) { super(sc); javaSparkContext = new JavaSparkContext(sc); } //... FileSystem fileSystem = path.getFileSystem(javaSparkContext.hadoopConfiguration());
https://github.com/heuermh/dishevelled-bio/blob/master/adam/src/main/java/org/dishevelled/bio/adam/BiojavaAdamContext.java#L133
What do you think about the getFs... methods?
No branches or pull requests
The Hadoop configuration from the SparkContext associated with an ADAMContext needs to be accessible for subclasses to access the FileSystem
Alternately, we could increase the visibility of the
getFs...
methods fromprivate[rdd]
toprotected
.The text was updated successfully, but these errors were encountered: