Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FeatureRDD.toCoverage throws NullPointerException when there is no coverage information #1471

Closed
devin-petersohn opened this issue Apr 4, 2017 · 1 comment
Closed

FeatureRDD.toCoverage throws NullPointerException when there is no coverage information #1471

devin-petersohn opened this issue Apr 4, 2017 · 1 comment
Assignees
@devin-petersohn
Milestone
0.23.0

Comments

@devin-petersohn
Copy link
Member

This is more of a discussion on how to handle this case.

Do we want to leave it, or should we add a require()?

The exception isn't thrown until the CoverageRDD is materialized, and NullPointerExceptions are notoriously difficult to debug at times.

I think it would be nicer to have in ADAM, but I am also happy to handle this exception downstream if that is the consensus.
@fnothaft
Copy link
Member

fnothaft commented Apr 4, 2017

I would +1 adding a require. IMO, users shouldn't see a NPE.

@devin-petersohn devin-petersohn self-assigned this Apr 4, 2017
@devin-petersohn devin-petersohn mentioned this issue Apr 4, 2017
Merged
@heuermh heuermh added this to the 0.23.0 milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@devin-petersohn devin-petersohn

Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

No branches or pull requests
3 participants
@heuermh @fnothaft @devin-petersohn