Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min Phred score gets bumped by 33 twice in BQSR #1488

Closed
fnothaft opened this issue Apr 13, 2017 · 0 comments
Closed

Min Phred score gets bumped by 33 twice in BQSR #1488

fnothaft opened this issue Apr 13, 2017 · 0 comments
Assignees
@fnothaft
Labels
bug
Milestone
0.23.0

Comments

@fnothaft
Copy link
Member

Paranoia sweeps the nation as an implicit conversion from Char to Int allows the minAcceptablePhred score to be incremented by 33 twice in the AlignmentRecordRDD->BaseQualityScoreRecalibration codepath. Troubled developers ask each other: could my Chars be the next target of implicit conversion? Find out more tonight.

For those watching at home, the first bump is here and the second bump is here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fnothaft fnothaft

Labels
bug
Projects
None yet
Milestone
0.23.0
Development

No branches or pull requests
1 participant
@fnothaft