Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate applyPredicate from ADAMContext #609

Closed
laserson opened this issue Mar 2, 2015 · 2 comments
Closed

Eliminate applyPredicate from ADAMContext #609

laserson opened this issue Mar 2, 2015 · 2 comments

Comments

@laserson
Copy link
Contributor

laserson commented Mar 2, 2015

In our recent effort to polish and tighten up ADAM, the focus has been to use the ADAM repo to store primarily lower-level ETL tools that make it easy to load, store, filter, join, etc. all different kinds of genomics data. Ideally, we'd use the lowest level abstractions given to us, which are the Spark RDDs. As such, if you get back an RDD of genomics objects and want to filter them, you should call .filter() on the RDD, rather than some other ADAM-specific function that essentially wraps the same functionality. The only load functions that should take predicates are ones that push the predicate into the Parquet code.

@laserson laserson changed the title Eliminate applyPredicate from a Eliminate applyPredicate from ADAMContext Mar 2, 2015
@tdanford
Copy link
Contributor

tdanford commented Mar 3, 2015

Can you provide a description though, uri?

@fnothaft
Copy link
Member

Closed by #616.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants