Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set defaults to schemas #1972

Merged
merged 3 commits into from
Jun 12, 2018
Merged

Set defaults to schemas #1972

merged 3 commits into from
Jun 12, 2018

Conversation

ffinfo
Copy link
Contributor

@ffinfo ffinfo commented Mar 27, 2018

For user convenience when working with scala

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@ffinfo
Copy link
Contributor Author

ffinfo commented Mar 27, 2018

Also changed to case classes, better native scala/dataset support

@heuermh
Copy link
Member

heuermh commented May 22, 2018

Jenkins, test this please

@coveralls
Copy link

coveralls commented May 22, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 79.145% when pulling 0ec222d on ffinfo:set_defaults into 1bfddc6 on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2769/
Test PASSed.

@heuermh
Copy link
Member

heuermh commented May 23, 2018

Looks reasonable to me, thank you, @ffinfo!

@heuermh heuermh requested a review from fnothaft May 23, 2018 14:22
@heuermh
Copy link
Member

heuermh commented Jun 6, 2018

@fnothaft milestone 0.24.1?

@heuermh heuermh mentioned this pull request Jun 11, 2018
Closed
@fnothaft fnothaft added this to the 0.24.1 milestone Jun 12, 2018
@heuermh heuermh merged commit afa55a4 into bigdatagenomics:master Jun 12, 2018
@heuermh
Copy link
Member

heuermh commented Jun 12, 2018

Thank you, @ffinfo! Squashed and merged as commit afa55a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnothaft fnothaft fnothaft approved these changes

@heuermh heuermh heuermh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ffinfo @AmplabJenkins @heuermh @coveralls @fnothaft