Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-1712] Replace utils.Logger with grizzled.slf4j.Logger #2136

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Mar 12, 2019

Fixes #1712

Unfortunately this requires changes in bdg-utils, and as such is blocked on an 0.2.15 release.

@heuermh heuermh added this to the 0.27.0 milestone Mar 12, 2019
@heuermh heuermh changed the title Replace utils.Logger with grizzled.slf4j.Logger [ADAM-1712] Replace utils.Logger with grizzled.slf4j.Logger Mar 12, 2019
@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2957/

Build result: FAILURE

GitHub pull request #2136 of commit ee23b1b automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos spark-test) in workspace /home/jenkins/workspace/ADAM-prbWiping out workspace first.Cloning the remote Git repositoryCloning repository https://github.com/bigdatagenomics/adam.git > git init /home/jenkins/workspace/ADAM-prb # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/heads/:refs/remotes/origin/ # timeout=15 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10 > git config --add remote.origin.fetch +refs/heads/:refs/remotes/origin/ # timeout=10 > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ # timeout=15 > git rev-parse origin/pr/2136/merge^{commit} # timeout=10 > git branch -a -v --no-abbrev --contains af687be # timeout=10Checking out Revision af687be (origin/pr/2136/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f af687be1b00ed04339f2aace50930e389f76bfc9First time build. Skipping changelog.Triggering ADAM-prb ? 2.7.5,2.11,2.2.3,ubuntuADAM-prb ? 2.7.5,2.11,2.2.3,ubuntu completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@heuermh
Copy link
Member Author

heuermh commented Apr 26, 2019

@shaneknapp Jenkins doesn't seem to want to pick this PR up, and also is unresponsive via the web

@shaneknapp
Copy link
Contributor

test this please

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 78.921% when pulling f132d8c on heuermh:grizzled-slf4j into 122888b on bigdatagenomics:master.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2967/
Test PASSed.

@heuermh
Copy link
Member Author

heuermh commented Apr 26, 2019

Thank you, @shaneknapp!

@heuermh heuermh merged commit 6e6ac8d into bigdatagenomics:master Apr 26, 2019
@heuermh heuermh deleted the grizzled-slf4j branch September 16, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log with parameterized messages consistently for performance
4 participants