Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the predicates package. #621

Merged
merged 2 commits into from
Mar 16, 2015

Conversation

fnothaft
Copy link
Member

Follow on cleanup to #609. We shouldn't need the predicates package after migrating to filter2 and removing the automagical predicates.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/635/

Build result: FAILURE

GitHub pull request #621 of commit ff0461b automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/621/merge^{commit} # timeout=10 > git branch -a --contains 79abef185535aa3af9f0ac887f6aa733813571db # timeout=10 > git rev-parse remotes/origin/pr/621/merge^{commit} # timeout=10Checking out Revision 79abef185535aa3af9f0ac887f6aa733813571db (origin/pr/621/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 79abef185535aa3af9f0ac887f6aa733813571dbFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@massie
Copy link
Member

massie commented Mar 16, 2015

Jenkins, test this please.

@fnothaft
Copy link
Member Author

Also, in #609 parquet-scala was added with scope test. I've removed the test scoping so that it is provided in the adam-shell.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/636/

Build result: FAILURE

GitHub pull request #621 of commit ff0461b automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/621/merge^{commit} # timeout=10 > git branch -a --contains 79abef185535aa3af9f0ac887f6aa733813571db # timeout=10 > git rev-parse remotes/origin/pr/621/merge^{commit} # timeout=10Checking out Revision 79abef185535aa3af9f0ac887f6aa733813571db (origin/pr/621/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 79abef185535aa3af9f0ac887f6aa733813571dbFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/637/

Build result: FAILURE

GitHub pull request #621 of commit c7ef1b0 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/621/merge^{commit} # timeout=10 > git branch -a --contains 762fbae # timeout=10 > git rev-parse remotes/origin/pr/621/merge^{commit} # timeout=10Checking out Revision 762fbae (origin/pr/621/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 762fbaec33ed9d0339cfa02fae868289330aaa0dFirst time build. Skipping changelog.Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/638/

Build result: FAILURE

GitHub pull request #621 of commit 444bca8 automatically merged.Notifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'[EnvInject] - Loading node environment variables.Building remotely on amp-jenkins-worker-05 (centos) in workspace /home/jenkins/workspace/ADAM-prb > git rev-parse --is-inside-work-tree # timeout=10Fetching changes from the remote Git repository > git config remote.origin.url https://github.com/bigdatagenomics/adam.git # timeout=10Fetching upstream changes from https://github.com/bigdatagenomics/adam.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/bigdatagenomics/adam.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse origin/pr/621/merge^{commit} # timeout=10 > git branch -a --contains 762fbae # timeout=10 > git rev-parse remotes/origin/pr/621/merge^{commit} # timeout=10Checking out Revision 762fbae (origin/pr/621/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 762fbae > git rev-list 762fbae # timeout=10Triggering ADAM-prb ? 2.2.0,centosTriggering ADAM-prb ? 2.3.0,centosTriggering ADAM-prb ? 1.0.4,centosADAM-prb ? 2.2.0,centos completed with result FAILUREADAM-prb ? 2.3.0,centos completed with result FAILUREADAM-prb ? 1.0.4,centos completed with result FAILURENotifying endpoint 'HTTP:https://webhooks.gitter.im/e/ac8bb6e9f53357bc8aa8'
Test FAILed.

@fnothaft
Copy link
Member Author

Jenkins, retest this please.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/639/
Test PASSed.

@laserson
Copy link
Contributor

I love all this deletion! Any reason to wait before merge?

@massie
Copy link
Member

massie commented Mar 16, 2015

None, Uri. Feel free to push the button. :)

-Matt

On Mon, Mar 16, 2015 at 3:28 PM, Uri Laserson notifications@github.com
wrote:

I love all this deletion! Any reason to wait before merge?


Reply to this email directly or view it on GitHub
#621 (comment).

laserson added a commit that referenced this pull request Mar 16, 2015
@laserson laserson merged commit 9685c2a into bigdatagenomics:master Mar 16, 2015
@laserson
Copy link
Contributor

@fnothaft fnothaft deleted the remove-predicate-package branch March 16, 2015 23:38
@fnothaft
Copy link
Member Author

I love all this deletion!

+1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants