From 6b987cfd1805e5cf6d631d33fa212be6ab24c11b Mon Sep 17 00:00:00 2001 From: Joey Date: Fri, 8 Mar 2024 09:52:08 +0800 Subject: [PATCH] [VL] Merge Partial and PartialMerge logic in generateMergeCompanionNode (#4883) --- .../execution/HashAggregateExecTransformer.scala | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/backends-velox/src/main/scala/io/glutenproject/execution/HashAggregateExecTransformer.scala b/backends-velox/src/main/scala/io/glutenproject/execution/HashAggregateExecTransformer.scala index cc428b59221e8..cc7a1a852ad3b 100644 --- a/backends-velox/src/main/scala/io/glutenproject/execution/HashAggregateExecTransformer.scala +++ b/backends-velox/src/main/scala/io/glutenproject/execution/HashAggregateExecTransformer.scala @@ -217,18 +217,9 @@ abstract class HashAggregateExecTransformer( def generateMergeCompanionNode(): Unit = { aggregateMode match { - case Partial => - val partialNode = ExpressionBuilder.makeAggregateFunction( - VeloxAggregateFunctionsBuilder.create(args, aggregateFunction, aggregateMode), - childrenNodeList, - modeKeyWord, - VeloxIntermediateData.getIntermediateTypeNode(aggregateFunction) - ) - aggregateNodeList.add(partialNode) - case PartialMerge => + case Partial | PartialMerge => val aggFunctionNode = ExpressionBuilder.makeAggregateFunction( - VeloxAggregateFunctionsBuilder - .create(args, aggregateFunction, aggregateMode), + VeloxAggregateFunctionsBuilder.create(args, aggregateFunction, aggregateMode), childrenNodeList, modeKeyWord, VeloxIntermediateData.getIntermediateTypeNode(aggregateFunction)