Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Routes need to be reworked #372

Closed
da3dsoul opened this issue Sep 30, 2019 · 3 comments
Closed

Routes need to be reworked #372

da3dsoul opened this issue Sep 30, 2019 · 3 comments
Labels
Enhancement Improving on what's there kore An issue related to the Kore Remote App interacting with Nakamori not_relevant_for_now Notes Notes for devs to keep ideas straight and/or remembered

Comments

@da3dsoul
Copy link
Contributor

da3dsoul commented Sep 30, 2019

It was mentioned in #370, but this clearly needs more discussion and thought.

  • Routes need to basically mirror the folder structure for Kore (and probably other things) to work right. When it goes up a level, you just cut the last part of the URL off, and vice-versa when entering a folder. (edit: and we dont want double same folder when going one level up)
  • They need to make sense.
  • They need to not end in a slash or number. This is a Kodi bug, but it still matters.
  • They need to support deep, varying trees. Filters are super flexible, and it is kind of a pain for systems that aren't. eg. /tags/tag/series/episode-types/episodes and /All/Group/Group/Series/Episodes need to both work and follow the other rules.
  • They need to be easily debuggable/troubleshootable. I should be able to look at the URL and know what Nakamori is trying to do and why it might be failing.
  • They need to be able to handle Filters that Apply at the Series Level.
  • They need to be able to handle Groups!

I know you don't use groups, but that's also why it seems that any time you mess with routes or menus, my groups and fancy filters stop working. I don't know if we need to implement Unit Tests or something, but that has long been a problem, and it bothers me every time it happens. Likewise, I imagine it goes both ways, like with your Kore and transcoder support.

@da3dsoul da3dsoul added Enhancement Improving on what's there Notes Notes for devs to keep ideas straight and/or remembered kore An issue related to the Kore Remote App interacting with Nakamori labels Sep 30, 2019
@da3dsoul
Copy link
Contributor Author

@bigretromike is there a reason you nested the routes? Does it need to respond to both, or is it mainly accept the lack of parameters?

@plugin.route()
@plugin.route()
def do_something()

That is what I mean by nesting.

@bigretromike
Copy link
Owner

When I nested something it was for supporting both that ends and don't ends with / because thats show kodi add / at end when you add item as part of main menu for kodi.

@da3dsoul
Copy link
Contributor Author

Okay, then it's no longer needed. Good to know. Routing "fixed" that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improving on what's there kore An issue related to the Kore Remote App interacting with Nakamori not_relevant_for_now Notes Notes for devs to keep ideas straight and/or remembered
Projects
None yet
Development

No branches or pull requests

2 participants