Further print abort improvement #2799
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisslorand
force-pushed
the
Print-abort-improvement
branch
4 times, most recently
from
7f9bc7d to
d8f5d6c
Compare
kisslorand
force-pushed
the
Print-abort-improvement
branch
4 times, most recently
from
58eee66 to
9579cbf
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Bump |
kisslorand
force-pushed
the
Print-abort-improvement
branch
5 times, most recently
from
1c2426e to
f62b7e4
Compare
kisslorand
force-pushed
the
Print-abort-improvement
branch
from
f62b7e4 to
eda7999
Compare
kisslorand
force-pushed
the
Print-abort-improvement
branch
from
eda7999 to
e4e89f4
Compare
kisslorand
force-pushed
the
Print-abort-improvement
branch
2 times, most recently
from
5f11b9e to
12862a0
Compare
kisslorand
force-pushed
the
Print-abort-improvement
branch
from
12862a0 to
25914e3
Compare
|
This PR has been automatically marked as stale because it has had no activity for the last 60 days. It will be closed in 7 days if no further activity occurs. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
BTT or MKS TFT
Description
This PR is a follow-up of PR Minor improvement on print abort #2728. That PR came with a nice idea but implemented it poorly. In case of printing from TFT media or remote host not all possible blocking operations are released (just only one) so the print will not stop ASAP.
This PR fixes it, in case of a print abort all blocking operations are released so the abortion of the print happens without any hesitation.
FW size is shrunken.