-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework change to mmdet #96
Comments
We've come to the point where we can't update TensorFlow any more without breaking the Mask R-CNN implementation of MAIA. While the code still runs, the detection output is wrong somehow. The current TF version has several security vulnerabilities. I think we should make the move to mmdet and maybe just use a simple Faster R-CNN as a starting point. We should compare detection performance with the original MAIA implementation but it should be similar. We can then experiment with the advanced features of mmdet at some later point. The most difficult part would be the migration of the custom implementation of the autoencoder/novelty detection method in TensorFlow. The move to mmdet and PyTorch has the additional advantage that it's compatible with DINO, which we plan to use to sort image thumbnails. |
What about dropping the autoencoder and using DINO right away or do you want to keep it for compatibility? If you don't want to use Mask R-CNN instance segmentation I agree that Faster R-CNN or YOLO might be a better solution because it uses less ressources. |
I would like to keep the current feature set in BIIGLE.
That only works for models/weights, right? You still have to implement the code in the new framework. For MAIA novelty detection, the autoencoder is trained from scratch each time, so no model is reused at all. |
To my knowledge it is not only the weights but also the operations (the model architecture) which is transformed, so it should work. |
I managed to get MAIA running on an older version of TensorFlow again, so it is functional right now. We should still make the change to a more maintainable implementation. Maybe as part of the hackathon. |
I pushed a Dockerfile with a complete PyTorch/mmdetection setup to the |
I guess it might be a good idea if you could gather some like plug in points/interfaces where code has to be injected such as - exchange noveltydetection.py it receives parameter1,2,3,4 via command line and outputs json to stdout |
Most updates are required for the Python scripts in Novelty detection is handled by the Instance segmentation is handled by the
|
We could change the detection framework to mmdet, which would have multiple benefits.
The text was updated successfully, but these errors were encountered: