Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Redis 0.25 #305

Closed
brocaar opened this issue Mar 13, 2024 · 2 comments
Closed

Update to Redis 0.25 #305

brocaar opened this issue Mar 13, 2024 · 2 comments
Labels
A-redis Area: Redis / deadpool-redis enhancement New feature or request

Comments

@brocaar
Copy link
Contributor

brocaar commented Mar 13, 2024

Redis 0.25.x has been released. Would it be possible to update deadpool-redis to this version?

It might be needed to make some adaptations (I have not had the time yet to look into this):

use of deprecated method redis::Client::get_async_connection: aio::Connection is deprecated. Use client::get_multiplexed_async_connection instead

Maybe this means that for non-cluster connections, the connection-pool is no longer needed as these queries will use a single multiplexed connection?

@brocaar
Copy link
Contributor Author

brocaar commented Mar 13, 2024

I think a connection pool is still needed, because some queries will block the multiplexed connection, see: redis-rs/redis-rs#851 (comment)

I have made these modifications in my fork:
brocaar@1697c5e

Before creating a pull-request, I will do some local testing first.

@bikeshedder bikeshedder added enhancement New feature or request A-redis Area: Redis / deadpool-redis labels Mar 13, 2024
@brocaar
Copy link
Contributor Author

brocaar commented Mar 14, 2024

Thanks for reviewing and merging the PR. I think this issue can be closed now :-)

@brocaar brocaar closed this as completed Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-redis Area: Redis / deadpool-redis enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants