fix: Handle issue with reopening cached editors

biscuit/core/components/editors/texteditor/text.py

@@ -602,16 +602,15 @@ def detect_encoding(self, file_path):
         try:
             with open(file_path, 'rb') as file:
                 bomstring = file.read(8)
+                detected = chardet.detect(bomstring)
+                encoding = detected['encoding'].lower()
+                if encoding == 'ascii':
+                    return 'utf-8'
+
+                return encoding                
         except Exception as e:
             # empty file
             return 'utf-8'
-
-        detected = chardet.detect(bomstring)
-        encoding = detected['encoding'].lower()
-        if encoding == 'ascii':
-            return 'utf-8'
-
-        return encoding
 
     def change_eol(self, eol: str):
         if not self.exists:

biscuit/core/layout/base/content/editors/__init__.py

@@ -7,7 +7,7 @@
 import tkinter as tk
 import typing
 from tkinter.messagebox import askyesno
-from typing import List, Union
+from typing import Dict, List, Union
 
 from biscuit.core.components.editors import Editor, Welcome
 from biscuit.core.components.editors.editor import BaseEditor
@@ -37,7 +37,7 @@ def __init__(self, master: ContentPane, *args, **kwargs) -> None:
         self.tabs = self.editorsbar.tabs
 
         self.active_editors: List[Editor] = []
-        self.closed_editors: List[Editor] = {}
+        self.closed_editors: Dict[Editor] = {}
 
         self.emptytab = Empty(self)
         self.emptytab.grid(column=0, row=1, sticky=tk.NSEW)
@@ -165,7 +165,7 @@ def delete_editor(self, editor: Editor) -> None:
         self.active_editors.remove(editor)
         self.tabs.delete_tab(editor)
         if editor.path in self.closed_editors:
-            self.closed_editors.remove(editor)
+            self.closed_editors.pop(editor)
 
         editor.destroy()
         self.base.explorer.open_editors.remove_item(editor)