Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R]: resolve best practice advice #22

Merged
merged 5 commits into from
Aug 5, 2020
Merged

[R4R]: resolve best practice advice #22

merged 5 commits into from
Aug 5, 2020

Conversation

HaoyangLiu
Copy link
Contributor

No description provided.

@unclezoro unclezoro changed the title WIP: resolve best practice advice [R4R]: resolve best practice advice Aug 5, 2020
@unclezoro unclezoro changed the base branch from master to develop August 5, 2020 02:45
@HaoyangLiu HaoyangLiu requested a review from yutianwu August 5, 2020 02:45
@yutianwu yutianwu merged commit 83d72b8 into develop Aug 5, 2020
@unclezoro unclezoro deleted the resolve-best-pratices branch August 8, 2020 02:50
irrun added a commit to irrun/bsc that referenced this pull request Apr 26, 2024
@pythonberg1997 @buddh0 @irrun
fix: some builder issues (bnb-chain#22)
b5e2af8 
* fix: allow fast node to rewind after abnormal shutdown (bnb-chain#2401)

(cherry picked from commit fb435eb)

* fix: bundlepool concurrent read and write and commit blob tx issue

* feat: set MaxBundleAliveBlock as bundle's default ddl

---------

Co-authored-by: buddho <galaxystroller@gmail.com>
Co-authored-by: irrun <irunert@gmail.com>
redhdx added a commit to redhdx/bsc that referenced this pull request May 30, 2024
@redhdx @pythonberg1997
@irrun @buddh0 @unclezoro
bsc builder diff (#2)
7ecb12b 
* builder: implement BEP322 builder-api (bnb-chain#7)

* feat: mev-builder

* consesus: add a interface to set validator at runtime
* core/txpool: add bundlepool to maintain bundle txs
* core/type: define bundle
* internal/ethapi: add sendBundle, bundlePrice, unregis
* ethclient: add SendBundle
* miner: add fillTransacitonsAndBundles, add Bidder to sendBid to validators
* add README.builder.md
---------

Co-authored-by: raina <irunert@gmail.com>

* fix: index out of range (bnb-chain#10)

* feat: call mev_params before send bid (bnb-chain#12)

* fix: NPE and wrong profit (bnb-chain#13)

* doc: update README.builder.md (bnb-chain#14)

* fix: concurrent map write issue (bnb-chain#15)

* fix: wrongly switch sync mode from full sync to snap sync issue (bnb-chain#17)

* fix: add missing part when preparing env in `SimulateBundle` (bnb-chain#19)

* feat: sendBundle return bundle hash (bnb-chain#20)

* fix: some builder issues (bnb-chain#22)

* fix: allow fast node to rewind after abnormal shutdown (bnb-chain#2401)

(cherry picked from commit fb435eb)

* fix: bundlepool concurrent read and write and commit blob tx issue

* feat: set MaxBundleAliveBlock as bundle's default ddl

---------

Co-authored-by: buddho <galaxystroller@gmail.com>
Co-authored-by: irrun <irunert@gmail.com>

* fix: typo in `BundlePool.AllBundles` (bnb-chain#24)

* feat: add `reconnectLoop` for mev validators (bnb-chain#25)

* feat: add `reconnectLoop` for mev validators

* fix lint issue

* fix review comments

* fix review comments

* feat: ethclient of bundle (bnb-chain#23)

* fix: a nil pointer when query bundle price (bnb-chain#28)

* feat: set unrevertible tx hashes when sendBid

---------

Co-authored-by: Roshan <48975233+Pythonberg1997@users.noreply.github.com>
Co-authored-by: raina <irunert@gmail.com>
Co-authored-by: Roshan <luoshen1997@gmail.com>
Co-authored-by: buddho <galaxystroller@gmail.com>
Co-authored-by: zoro <296179868@qq.com>
galaio pushed a commit to galaio/bsc that referenced this pull request Jul 31, 2024
@trianglesphere @mslipper
@protolambda @tynes @maurelian
optimism: historical Bedrock geth rollup changes
c48b8aa 
This commit squashes the op-geth fork history into a more maintainable
diff for rebasing upon upstream geth.

reference-optimistic-geth changes (origins of op-geth in early Bedrock
development stage):
- Deposit TX Type
- Enable deposit tx in EVM/tx pool
- Change deposit nonce to not be the max nonce
- Extend PayloadAttributesV1 with a Transactions field
- Force deposits at the start of each L2 block
- Fix height check
- noTxPool flag, reproduce block in verifier mode without tx pool interference
- Fix RPC json marshalling (ref op-geth PR 4)
- Deposit txs block height check in block body validation (ref op-geth PR 5)
- core: do not try to reinject deposit txs into tx-pool (ref-op-geth PR 6)
- deposit source hash field instead of L2 block height and tx index combination
- Include invalid deposits, rewind state, but always persist mint (bnb-chain#10)
- Provide gas to Call/Create in deposit transactions (bnb-chain#12)
- Add docker builds (ref-op-geth PR 16, 17)
- Don't panic on deposit transaction signature values or chain ID (ref-op-geth PR 18)
- core: Add version to DepositTx (ref-op-geth PR 19)
- Enable Geth build/lint/test in CircleCI (ref-op-geth PR 23)
- core: Include guaranteed gas in the gas pool (ref-op-geth PR 21)
- core: handle base fee, l1 availability fee, tx fee (ref-op-geth PR 27)
- fix: deposit tx hash
- fix l1 fee cache, rpc, tracing and tx pool
- core: remove deposit-tx sub-type (a.k.a. deposit version byte)
- eth/catalyst: allow engine user to reorg own chain
- miner: restore ability to reorg deep as block builder
- params: print Optimism consensus type in banner
- core/types: remove unused protected() method, see upstream PR 23376
- core: do not mutate original balance value in tx pool l1 cost adjustment
- core: subtract deposit gas from pool, so other txs do not use the same gas. And fail tx processing if deposits reach gas limit
- core/types: deposits do not tip, avoid basefee subtraction
- Unmeter the L1 Attributes Transaction
- miner: handle force tx errors as critical, clean up diff
- ci: Switch branch
- eth,miner: return STATUS_INVALID when failing to process forced transactions in request (ref-op-geth PR 40)
- verifier: forward tx to sequencer based on flag
- txpool: add flag to disable tx gossip (ref-op-geth PR 42)
- Add op-geth version in addition to geth version (ref-op-geth PR 43)
- ci: CircleCI improvements (ref-op-geth PR 44)
- Rename to op-geth
- Build latest tag on optimism branch

op-geth changes:
- Expose cache config in simulated backend (bnb-chain#2)
- Add EIP-1559 parameters
- eth/catalyst: update payload id computation (bnb-chain#1)
- make eip1559 configurable (bnb-chain#4)
- post-merge network should not log warnings about missing transition information (bnb-chain#5)
- Make the simulator more configurable (bnb-chain#6)
- fix OPB-6 - IsDepositTx check instead of artificial nonce value check (bnb-chain#7)
- Simulated backend - enable proof of stake consensus type and fix performance issue (bnb-chain#8)
- accounts: simulated backend consensus engine option and immediate tx indexing
- consensus/beacon: recognize all blocks as reached TTD with 0 TTD in chain config
- Add --rollup.historicalhttp CLI flag and fix backend iface
- Flags and interfaces for historical RPC requests (bnb-chain#12)
- Redirect historical RPC requests (bnb-chain#13)
- Use the pre-existing ethereum.NotFound error (bnb-chain#18)
- Add historical endpoint to TraceBlockByNumber and TraceBlockByHash (bnb-chain#19)
- Add historical endpoint to TraceTransaction (bnb-chain#20)
- Add historical endpoint to TraceCall (bnb-chain#21)
- optimism: fee params from info txi, update l1 cost func GPO params read (bnb-chain#15)
- add hardcoded addresses for fee payouts (bnb-chain#23)
- dynamic gas limit via engine API (bnb-chain#22)

Co-authored-by: Matthew Slipper <me@matthewslipper.com>
Co-authored-by: Joshua Gutow <jgutow@oplabs.co>
Co-authored-by: protolambda <proto@protolambda.com>
Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Co-authored-by: Maurelian <maurelian@protonmail.ch>
galaio pushed a commit to galaio/bsc that referenced this pull request Jul 31, 2024
@welkin22 @owen-reorg
fix: remove unnecessary newRPCTransactionFromBlockHash function (bnb-…
0eb8a65 
…chain#22)

Co-authored-by: Welkin <welkin.b@nodereal.com>
Co-authored-by: Owen <103096885+owen-reorg@users.noreply.github.com>
galaio added a commit to galaio/bsc that referenced this pull request Aug 16, 2024
@galaio @sunny2022da
txdag: support multi flags, and supported in pevm; (bnb-chain#22)
e292916 
* txdag: add excluded flag;
mvstates: generate txdag with excluded flag;

* pevm: support txdag with excluded tx;

* blockchain: opt txdag file mode;

* pevm: fix dispatch bugs;

* pevm: opt txdag dispatch;

---------

Co-authored-by: galaio <galaio@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro approved these changes

@yutianwu yutianwu yutianwu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HaoyangLiu @yutianwu @unclezoro