Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[R4R] minor fix for ramanujan upgrade #25

Merged
merged 3 commits into from
Aug 10, 2020
Merged

[R4R] minor fix for ramanujan upgrade #25

merged 3 commits into from
Aug 10, 2020

Conversation

unclezoro
Copy link
Collaborator

@unclezoro unclezoro commented Aug 9, 2020 •
edited
Loading

  1. The logic of back off time should compatible with previous logic.
  2. The code is not hex compatible.

@unclezoro unclezoro changed the title [R4R]fix delay check [R4R]fix delay logic before fork Aug 9, 2020
@unclezoro unclezoro changed the title [R4R]fix delay logic before fork [R4R] minor fix for ramanujan upgrade Aug 9, 2020
@unclezoro unclezoro merged commit 8c1d1db into system-contract-upgrade Aug 10, 2020
@unclezoro unclezoro deleted the fixdelayLogic branch August 28, 2020 02:40
unclezoro pushed a commit to unclezoro/bsc that referenced this pull request Feb 9, 2022
@holiman @ryanschneider
@lightclient @rjl493456442 @karalabe
core, eth, internal, les: RPC methods and fields for EIP 1559 (#22964)
5cff975 
* internal/ethapi: add baseFee to RPCMarshalHeader

* internal/ethapi: add FeeCap, Tip and correct GasPrice to EIP-1559 RPCTransaction results

* core,eth,les,internal: add support for tip estimation in gas price oracle

* internal/ethapi,eth/gasprice: don't suggest tip larger than fee cap

* core/types,internal: use correct eip1559 terminology for json marshalling

* eth, internal/ethapi: fix rebase problems

* internal/ethapi: fix rpc name of basefee

* internal/ethapi: address review concerns

* core, eth, internal, les: simplify gasprice oracle (bnb-chain#25)

* core, eth, internal, les: simplify gasprice oracle

* eth/gasprice: fix typo

* internal/ethapi: minor tweak in tx args

* internal/ethapi: calculate basefee for pending block

* internal/ethapi: fix panic

* internal/ethapi, eth/tracers: simplify txargs ToMessage

* internal/ethapi: remove unused param

* core, eth, internal: fix regressions wrt effective gas price in the evm

* eth/gasprice: drop weird debug println

* internal/jsre/deps: hack in 1559 gas conversions into embedded web3

* internal/jsre/deps: hack basFee to decimal conversion

* internal/ethapi: init feecap and tipcap for legacy txs too

* eth, graphql, internal, les: fix gas price suggestion on all combos

* internal/jsre/deps: handle decimal tipcap and feecap

* eth, internal: minor review fixes

* graphql, internal: export max fee cap RPC endpoint

* internal/ethapi: fix crash in transaction_args

* internal/ethapi: minor refactor to make the code safer

Co-authored-by: Ryan Schneider <ryanleeschneider@gmail.com>
Co-authored-by: lightclient@protonmail.com <lightclient@protonmail.com>
Co-authored-by: gary rong <garyrong0905@gmail.com>
Co-authored-by: Péter Szilágyi <peterke@gmail.com>
redhdx added a commit to redhdx/bsc that referenced this pull request May 30, 2024
@redhdx @pythonberg1997
@irrun @buddh0 @unclezoro
bsc builder diff (#2)
7ecb12b 
* builder: implement BEP322 builder-api (bnb-chain#7)

* feat: mev-builder

* consesus: add a interface to set validator at runtime
* core/txpool: add bundlepool to maintain bundle txs
* core/type: define bundle
* internal/ethapi: add sendBundle, bundlePrice, unregis
* ethclient: add SendBundle
* miner: add fillTransacitonsAndBundles, add Bidder to sendBid to validators
* add README.builder.md
---------

Co-authored-by: raina <irunert@gmail.com>

* fix: index out of range (bnb-chain#10)

* feat: call mev_params before send bid (bnb-chain#12)

* fix: NPE and wrong profit (bnb-chain#13)

* doc: update README.builder.md (bnb-chain#14)

* fix: concurrent map write issue (bnb-chain#15)

* fix: wrongly switch sync mode from full sync to snap sync issue (bnb-chain#17)

* fix: add missing part when preparing env in `SimulateBundle` (bnb-chain#19)

* feat: sendBundle return bundle hash (bnb-chain#20)

* fix: some builder issues (bnb-chain#22)

* fix: allow fast node to rewind after abnormal shutdown (bnb-chain#2401)

(cherry picked from commit fb435eb)

* fix: bundlepool concurrent read and write and commit blob tx issue

* feat: set MaxBundleAliveBlock as bundle's default ddl

---------

Co-authored-by: buddho <galaxystroller@gmail.com>
Co-authored-by: irrun <irunert@gmail.com>

* fix: typo in `BundlePool.AllBundles` (bnb-chain#24)

* feat: add `reconnectLoop` for mev validators (bnb-chain#25)

* feat: add `reconnectLoop` for mev validators

* fix lint issue

* fix review comments

* fix review comments

* feat: ethclient of bundle (bnb-chain#23)

* fix: a nil pointer when query bundle price (bnb-chain#28)

* feat: set unrevertible tx hashes when sendBid

---------

Co-authored-by: Roshan <48975233+Pythonberg1997@users.noreply.github.com>
Co-authored-by: raina <irunert@gmail.com>
Co-authored-by: Roshan <luoshen1997@gmail.com>
Co-authored-by: buddho <galaxystroller@gmail.com>
Co-authored-by: zoro <296179868@qq.com>
galaio pushed a commit to galaio/bsc that referenced this pull request Jul 31, 2024
@redhdx
Merge pull request bnb-chain#25 from yutianwu/fix_cometbft
e7cb32f 
sec: update version of cometbft
galaio pushed a commit to galaio/bsc that referenced this pull request Aug 16, 2024
@DavidZangNR @sunny2022da
fix addBalance for delayGasFee (bnb-chain#25)
9fc533b 
Make the change into the merged mainDB instead of slotDB to avoid
the concurrency issue

Co-authored-by: Sunny <sunny2022.za@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yutianwu yutianwu yutianwu approved these changes

@HaoyangLiu HaoyangLiu HaoyangLiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@unclezoro @HaoyangLiu @yutianwu