Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]fix: block fetcher efficiency #333

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

j75689
Copy link
Contributor

@j75689 j75689 commented Jul 29, 2021

Description

If a fork block is generated, the fork block is write faster than the original block, which will cause the subsequent block write delay.

Rationale

Put the blocks that cannot find the parent block into the queue, wait for the parent block to write, and then import it.

Preflight checks

  • build passed (make build)
  • tests passed (make test)
  • manual transaction test passed

@j75689 j75689 requested a review from unclezoro July 29, 2021 03:37
@j75689 j75689 force-pushed the fix/block_fetcher branch from 0a05176 to 2ef48de Compare July 29, 2021 03:42
@j75689 j75689 requested a review from unclezoro July 29, 2021 04:12
@unclezoro unclezoro changed the title fix: block fetcher efficiency [R4R]fix: block fetcher efficiency Jul 29, 2021
@j75689 j75689 force-pushed the fix/block_fetcher branch 2 times, most recently from f826f36 to 3ab4708 Compare July 29, 2021 06:08
@j75689 j75689 force-pushed the fix/block_fetcher branch from 3ab4708 to 578b8c6 Compare July 29, 2021 06:26
@unclezoro unclezoro merged commit 7e8d9fb into bnb-chain:master Jul 29, 2021
@unclezoro unclezoro mentioned this pull request Jul 29, 2021
3 tasks
@j75689 j75689 linked an issue Jul 30, 2021 that may be closed by this pull request
unclezoro pushed a commit that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BSC synchronization issues
3 participants