get diff accounts by replaying block when diff layer not found #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Nov 13, 2021
core/state/statedb.go
Outdated
| @@ -1493,3 +1493,11 @@ func (s *StateDB) SlotInAccessList(addr common.Address, slot common.Hash) (addre | |||
| } | |||
| return s.accessList.Contains(addr, slot) | |||
| } | |||
|
|
|||
| func (s *StateDB) GetDirtyAccounts() []common.Address { | |||
| accounts := make([]common.Address, 0) | |||
There was a problem hiding this comment.
The capacity should be len(s.stateObjectsDirty)
|
Try fixing the CI as well. Seems integration test stuck |
j75689
reviewed
Nov 15, 2021
Sometimes public machines on GitHub are busy, which will cause timeout errors... |
Signed-off-by: Keefe-Liu <bianze.kernel@gmail.com>
unclezoro
approved these changes
Nov 16, 2021
j75689
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Keefe-Liu bianze.kernel@gmail.com
Description
Get block's diff accounts by replaying block when diff layer not found.
Rationale
The diff layer just can cache for a few days, when there is no diff layer, the eth_getDiffAccounts API couldn't work, in this case we should replay the block and get the diff accounts, it may slow but i can work right.
Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
make build)make test)Already reviewed by
...
Related issues
... reference related issue #'s here ...