-
Notifications
You must be signed in to change notification settings - Fork 298
/
CODEOWNERS
Validating CODEOWNERS rules...
134 lines (97 loc) · 5.49 KB
/
CODEOWNERS
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
# ==================================================================================
# ==================================================================================
# Deriv CODEOWNERS
# ==================================================================================
# ==================================================================================
#
# Configuration of code ownership and review approvals for the binary-com/deriv-app repo.
#
# More info: https://help.github.com/articles/about-codeowners/
#
# ================================================
# General rules / philosophy
# ================================================
#
# - we trust that people do the right thing and not approve changes they don't feel confident reviewing
# - we use github teams so that we funnel code reviews to the most appropriate reviewer, this is why the team structure is fine-grained
# - we enforce that only approved PRs get merged to ensure that unreviewed code doesn't get accidentally merged
# - we delegate approval rights as much as possible so that we can scale better
# - each group must have at least one person, but several people are preferable to avoid a single point of failure issues
#
# Configuration nuances:
#
# - This configuration works in conjunction with the protected branch settings that require all changes to be made via pull requests with at least one approval.
# - This approval can come from an appropriate codeowner, or any repo collaborator (person with write access) if the PR is authored by a codeowner.
# - Each codeowners team must have write access to the repo, otherwise their reviews won't count.
#
# In the case of emergency, the repo administrators can bypass this requirement.
# ================================================
# GitHub username registry
# (just to make this file easier to understand)
# ================================================
# akmal-binary
# bahar-fs
# balakrishna-binary
# carol-binary
# matin-binary
# mehrzad-fs
# nijil-binary
# njazuli-deriv
# yashim-deriv
######################################################################################################
#
# CODEOWNERS rules
# -----------------
#
# All the following rules are applied in the order specified in this file.
# The last rule that matches wins!
#
# See https://git-scm.com/docs/gitignore#_pattern_format for pattern syntax docs.
#
######################################################################################################
# ==============================================================
# Default Owners
# (in case no pattern matches a path in a PR - this should be treated as a bug and result in adding the path to CODEOWNERS)
# ==============================================================
* @matin-binary @nijil-binary @mehrzad-fs @balakrishna-binary
# ==============================================================
# deriv-app/account
# ==============================================================
/packages/account/**/* @yashim-deriv
# ==============================================================
# deriv-app/bot
# ==============================================================
/packages/bot-skeleton/**/* @mehrzad-fs
/packages/bot-web-ui/**/* @mehrzad-fs
/packages/indicators/**/* @mehrzad-fs
# ==============================================================
# deriv-app/core
# ==============================================================
/packages/core/**/* @balakrishna-binary @matin-binary
/packages/shared/**/* @balakrishna-binary @matin-binary
/packages/components/**/* @balakrishna-binary @matin-binary
/packages/translations/**/* @balakrishna-binary @matin-binary
# ==============================================================
# deriv-app/p2p
# ==============================================================
/packages/p2p/**/* @carol-binary @nijil-binary
# ==============================================================
# deriv-app/cashier
# ==============================================================
/packages/cashier/**/* @bahar-fs @nijil-binary
# ==============================================================
# deriv-app/cfd
# ==============================================================
/packages/cfd/**/* @balakrishna-binary @matin-binary @yashim-deriv
# ==============================================================
# deriv-app/trader
# ==============================================================
/packages/trader/**/* @matin-binary @balakrishna-binary @akmal-binary
# ==============================================================
# deriv-app/publisher
# ==============================================================
/packages/publisher/**/* @nijil-binary
# ==============================================================
# deriv-app/appstore
# ==============================================================
/packages/appstore/**/* @matin-binary @balakrishna-binary @njazuli-deriv @bahar-fs