-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: to remove telegram token from datadog rum #11072
refactor: to remove telegram token from datadog rum #11072
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-yaswanth-deriv-yaswanth-cfds-1290-rem-f7829b.binary.sx/ |
…_ids_from_datadog_rum
Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
🚀 Smoke test run (1) passed successfully! |
Why?
In the screenshot below, you can observe that private data such as tokens and Telegram API tokens are being exposed in Datadog RUM (Real User Monitoring). Therefore, it's crucial for me, as a developer, to eliminate these sensitive details from the logs
Solution
I utilized the 'beforesend' method provided by Datadog, allowing us to manage each event before transmitting it to Datadog RUM. Within this function, I substituted the URLs with the necessary ones.