-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WALL] Sergei / wall - 3008 / Unit tests for useInputDecimalFormatter hook #12276
[WALL] Sergei / wall - 3008 / Unit tests for useInputDecimalFormatter hook #12276
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 2 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving this PR, the original hook probably requires very solid refactor / updates
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-sergei-deriv-sergei-wall-3008test-use-d482d5.binary.sx/ |
❌ Smoke test run (2) failed. See logs for details: Visit Action |
⏳ Generating Lighthouse report... |
Changes:
useInputDecimalFormatter
hookuseInputDecimalFormatter
hook (need to check 1st char instead of left part of the input number)Card:
https://app.clickup.com/t/20696747/WALL-3008
Screenshots: