Fasih/BL-406/Removed platformContext #14951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
review-deriv
reviewed
May 3, 2024
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matin-deriv
reviewed
May 3, 2024
packages/core/src/App/Containers/RealAccountSignup/modal-login-prompt.jsx
Outdated
Show resolved
Hide resolved
matin-deriv
reviewed
May 3, 2024
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-fasihali-deriv-bl-406-remove-platformcontext.binary.sx/ |
fasihali-deriv
requested review from
maryia-deriv,
farrah-deriv,
nijil-deriv,
ali-hosseini-deriv,
hirad-deriv and
amina-deriv
as code owners
fasihali-deriv
changed the title
review-deriv
reviewed
May 3, 2024
matin-deriv
previously approved these changes
May 8, 2024
amina-deriv
previously approved these changes
May 8, 2024
suisin-deriv
approved these changes
May 8, 2024
|
likhith-deriv
approved these changes
May 13, 2024
amina-deriv
approved these changes
May 13, 2024
amina-deriv
added a commit
that referenced
this pull request
May 23, 2024
* fix: resolved IDV last status message (#14980) * [UPM-982]/evgeniy/redirect to error page while clicking contact us link (#14944) * chore: [UPM-982]/evgeniy/redirect to error page while clicking contact us link * refactor: move css import, rename classname * chore: remove return * chore: trigger build * test: added missing test case in transaction-details folder (#14990) * test: added missing test case in transaction-details folder * Update load-modal-store.ts * Update dropdown.scss * [BOT] Farabi/bot-1444/map dbot events to rudderstack (#14977) * fix: add rudderstack events * fix: added select quick strategy guide event * chore: added track event for run bot * [WALL] Lubega / WALL-3922 / Wallet carousel interactivity fix (#14989) * fix: wallet carousel interactivity fix * fix: retrigger integration test * fix: fixed the MT5 account creation flow and the showing of the correct shortcode in success screen (#14981) * chore: fix notifications misalign in cashier wallets (#14957) * [WALL] Lubega / WALL-3617 / Third party redirection for wallets cashier (#14229) * feat: third party redirection for wallets cashier * fix: clean up * fix: clean up * fix: removed feature flag dependency * fix: changed route for transactions * Dhruv/COJ-751/Account-FinancialAssessment-FieldRequiredError-MobileView-bug (#14976) * fix: Resolved field error of employment status dropdown of mobile viewin Financial Assessment * fix: incorrect validation of employment status * fix: repaired code --------- Co-authored-by: Dhruv-deriv <dhruv@deriv.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * [WALL] george / WALL-3284 / Blank Page with Invalid token when accessing wallets in desktop (for wallets created using a different device/browser) (#14946) * feat(wallets): 🔥 remove accounts without token from `account_list` and `authorize` responses * test(wallets): 🧪 add test for getAccountListWithAuthToken util * style(wallets): 💄 fix tab padding * test(wallets): 🧪 refactor tests * translations: 📚 sync translations with crowdin (#15035) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * [WALL] [Fix] Rostislav / WALL-3426 / Transaction status amount format (#14482) * fix: value format * fix: tests * fix: tests * fix: latest adjustment w prod * fix: tests * fix: tests x2 * fix: tests x3 * chore: trigger ci * refactor: revert pkg api * refactor: use `@deriv/utils` * fix: logic * fix: logic * refactor: add test * chore: re-run ci * chore: revert unrelated file * chore: revert unrelated file x2 * refactor: change new param to snake_case * refactor: truncated amount * fix: tests * feat: add tooltip / modal thing for amount * fix: tests * refactor: remove formatted_truncated_amount * refactor: remove max_digits * refactor: remove should_keep_precision * fix: ci * fix: vercel * fix: deps * fix: layout * fix(wallets): 🚑 remove onScrollHandler if there is no transactions (#15005) * [WALL] Aizad/WALL-3961/Center Modal Investor Password Modal in responsive (#14995) * chore: fix modal not center for investor password * fix: retrigger ci * Aizad/WALL-3966/Back Arrow Incorrect Placement fix (#14992) * chore: replace icon with the right one * chore: replace icon for dynamic leverage * feat: add video for even odd contract (#14958) * Maryia/WEBREL-2578/test: coverage for routes & routes-config in Reports (#14973) * test: routes.tsx in reports * test: routes-config * refactor: test for routes-config * fix: remove extra async expect * refactor: packages/reports/src/Constants/__tests__/routes-config.spec.tsx * translations: 📚 sync translations with crowdin (#15062) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * [WALL] Lubega / WALL-3945 / USD demo wallet card name (#14952) * fix: usd demo wallet card name * fix: updated unit test * fix: update carousel content condition * fix: updated unit test * fix: failing unit and integration tests (#15046) * [CFDs] Hirad/CFDs-1371/ Using the token call on click of the terminal button (#14774) * chore: made the token call on click of the button * fix: added the new token functionality * fix: styling of the button is working finer * chore: removed one level of prop passing * fix: only the relevant account type token will be called * fix: did improvements to the types * fix: added condition if token throws error * chore: fix eslint for wallets (#15060) * [WALL] Aizad/WALL-3953/fix MT5 create password strength bar doesn't match password strength is some scenarios (#14996) * chore: update password scoring system for mt5 * chore: update password policy * chore: update password scoring system according to production and expected outcomes * chore: update logic to show success modal * fix: demo switcher input browser fix (#15075) * [DTRA-1266] shahzaib / style - accumulator tick count bar misaligned in contract card (#15064) * style: fix tick counter bar alignment and color * chore: update scss * chore: replaced style with color prop from text * [TRAH] Sergei / TRAH - 3061 / Create own useWalletMigration hook (#14119) * feat: intermediate result * feat: remove unused imports part 2 * fix: get back toggle-account-type.scss * fix: delete wallet test file * fix: install types for package in @deriv/shared * feat: add redirect to wallets * feat: remove unused imports * feat: check performance without modals * feat: add lazy loading for ModalManager * feat: delete lazy loading for now * feat: delete more components * fix: fully delete deriv/api * fix: delet mock from the test * feat: check class remove * feat: keep purgecss only in appstore package * feat: update webpack config * feat: delete css webpack plugins and script from package.json * feat: modify ExchangeRatesProvider * fix: add useCallback to fix sonarCloud issue * fix: mock useContext * feat: add some lazy loadings * fix: add unsubscribe for exchange rates * feat: add one more check for total asset loader * feat: move helper function to helpers folder * feat: add one more lazy load * feat: get back header load * fix: change import order * fix: get back all lazy loads for modals * feat: add header-fallback * feat: use makeLazyLoaderfor component to prevent using suspense * fix: change get to find in spec files and add await * feat: add lazy loading for almost all modals in modal-manager * fix: fix test case * feat: make cfd-password-modal lazy too * feat: delete account loader from webpack.config and add lazy for one more modal * feat: add lazy for mt5-migration-banner * feat: add lazy loading for wallets banner * chore: empty commit * chore: fix misspelling * feat: remove lazy loading for CFDPasswordModal * feat: add lazy loading for cfd-password-modal again * feat: start with removing unused types * feat: set sideEffect to false for 2 packages * feat: add walletMigrationProvider * feat: delete USD as default currency * feat: delete unused wallet code * feat: move css inside of the component and complete walletMigrationProvider * fix: fix real-wallets-upgrade test * feat: add 4 more lazy loading in core package * fix: fix header test * feat: add check for authorize * feat: add memo for icon component * feat: remove memo * feat: move wallet migration logic to the client store * feat: delete USD as default currency * feat: remove exchange rates provider and move the logic to client store * fix: fix tests * feat: implement review comments * feat: add show_wallets_banner * chore: empty commit * feat: update api-types version in appstore package * feat: update to use hook instead of value from the store directly * feat: change check for state from wallet migration instead of flag * feat: add is_wallet_migration_request_is_in_progress * fix: remove unused import * chore: empty commit * feat: add details-form styles in the core app * feat: add catch for wallet migration requests * chore: empty commit * [TRAH]/Mitra/TRAH-3381/Set performance value for login time once cfd section is loaded (#14994) * fix: ✨ set performance value for login time once cfd is loaded * fix: 🐛 addressing habibi comments * feat: 🐛 import useeffect from react * feat: ✨ add multiplier option metric * fix: 🐛 address comment * [WALL-4020] feat: fixed flickering of USD background (#15054) * feat: fixed flickering * feat: switched TS pattern * fix: scrolling modal for scaled browser (#15066) * [WALL-3735] loaders review (#14851) * feat: improved balance loader * feat: fixed add wallet carousel loaders * feat: fixed account switching loader * feat: esling cleanup * translations: 📚 sync translations with crowdin (#15092) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * [WALL] Aizad/WALL-3967/ Fix "USD" is missing from swap free account creation success card (#15012) * chore: created display balance and put it inside of usememo * chore: added loading animation to display balance * chore: added skeleton loader css inside of stylesheet of the component * [WALL] aum / WALL-4052 / fix-arrow-direction-wallet-withdrawal-crypto-receipt (#15078) * fix: fix direction of arrow in WithdrawalCryptoReceipt * fix: fix back arrow FiatOnRamp * fix: fix the direction of the arrow in WithdrawalCryptoAmountConverter (#15050) * fix: fixed the direction for arrow wallet transfer receipt (#15033) * Matin/[BL-396]/Removal of country-level business logic (#14743) * chore: initial commit * fix: failed tests * chore: removal of useAccountTransferVisible * fix: test cases * chore: revert back some changes * chore: review comments * chore: Remove country-level business logic * chore: remove is_uk flag * chore: empty commit * chore: update @deriv/deriv-charts to 2.1.15 (#15110) Co-authored-by: balakrishna-deriv <balakrishna-deriv@users.noreply.github.com> * revert: remove should_show_eu_content SmartCharts prop + stop tracking MARKET_INFO_REDIRECT (#14971) * [FEQ-2191]/Rupato/Refactored the adjust workspace function (#15048) * fix: refactored the adjust workspace function * fix: fixed review comments * chore: 🔥 updated is_mobile --------- Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> * chore: placed p2p redirection back (#15083) * [UPM-817]/evgeniy/submit button disabled while clicking checkbox for demo account (#15006) * chore: [UPM-817]/evgeniy/submit button disabled while clicking checkbox for demo account * refactor: remove storage from setsettings * translations: 📚 sync translations with crowdin (#15118) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * build: updated react-virtualized package (#14954) * fix: Add a Deriv Account pop up is broken if user select same duplica… (#11216) * fix: Add a Deriv Account pop up is broken if user select same duplicated currency * chore: add operation check for local props * chore: fix flickering issue --------- Co-authored-by: amina-deriv <amina@regentmarkets.com> * [WALL] aum / WALL-3863 / wallet-withdrawal-blocked-on-zero-balance (#14906) * feat: added WithdrawalNoBalance screen * fix: removed unnecessary hook call and fixed tests * perf: added unit tests for WithdrawalNoBalance * chore: updated content for the screen * chore: updated unit tests with the new content * chore: applied suggestions * feat: 🖊️ updated the content for the * [WALL] Aizad/WALL-4048/Adding Scroll To ModalStepWrapper (#15085) * chore: Add scroll to small screens for modal * chore: add styles for desktop screens * refactor: revert workaround; remove todo (#14796) * Fasih/BL-406/Removed platformContext (#14951) * chore: removed platform context * chore: removed unused code * chore: removed unused classname and fixed condition * chore: fixed test and remove is app store * chore: removed unused code * chore: removed unused type * chore: removed unused types * chore: removed unused classname * chore: reverted back scss changes done by prittier * chore: removed unused param --------- Co-authored-by: Muhammad Fasih Ali Naqvi <muhammadfasih@Muhammad-Fasihs-Mac-X7KDC4NKQ0-Standard.local> * [coj]/likhith/COJ-772/chore: locked Onfido SDK version (#15102) * chore: downgrade onfido version to 13.4.0 * feat: locked Onfido version to 13.8.4 * translations: 📚 sync translations with crowdin (#15128) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * translations: 📚 sync translations with crowdin (#15135) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * fix: resolved file upload issue (#15055) * fix: resolved file upload issue * fix: issue related to COJ-773 * fix: issue COJ-774 * [TRAH]/Mitra/TRAH-3251/Update description and texts in traders hub (#14854) * feat: 💬 update description and texts * fix: 🧪 fix test * fix: 🐛 change cfd description * fix: 💬 fix descriptions * fix: 🐛 address comments * chore: update eu disclaimer (#15143) * Revert "chore: update eu disclaimer (#15143)" (#15146) This reverts commit 000bbb9. * chore: remove add button from compare account cards (#15093) * fix: analyze swallows errors, so this splits it out into a different script (#14978) * fix: translation issue for recent transactions (#15045) * Akmal / fix: add sell error modals in reports package (#14689) * fix: add sell error modals in reports package * feat: trigger deployment * fix: remove unused component and test cases * fix: swtich to Localize * translations: 📚 sync translations with crowdin (#15158) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * translations: 📚 sync translations with crowdin (#15160) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * translations: 📚 sync translations with crowdin (#15161) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * [WALL] george / WALL-3866 / Add API error handling for withdrawal service (#15052) * feat(wallets): ✨ add API error handling for withdrawal service * fix(wallets): 🎨 apply comments * fix: remove disclaimer modal (#15076) * translations: 📚 sync translations with crowdin (#15168) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * refactor: revert temp workaround (#14797) * [WALL] Rostislav / WALL-3931 / Wrap wallet migration logic behind feature flag (#15036) * refactor: make `has_wallets` shadow `is_next_wallet_enabled` when `true` * refactor: extra changes re prev commit * refactor: e2e tests upd * refactor: e2e mock upd * refactor: hide wallets migration stuff behind feature flag * refactor: revert changes causing integration tests to fail * refactor: remove typo * refactor: correct update to client store * refactor: `<React.Fragment>` * refactor: dont use `useStoreWalletAccountsList` when unnecessary * fix: tests * refactor: revert `<Devtools />` conditional render * refactor: logic * refactor: remove flag for <DevTools /> * refactor: `client-store` correction * fix: revert a bad refactor * fix: tests * refactor: remove unused imports * refactor: remove unused import * [WALL]Jim/WALL-4041/hide close icon and set ctrader account as default when transfer button is clicked (#15156) * chore: hide close icon and set ctrader account as default when transfer button is clicked * chore: add type declaration * translations: 📚 sync translations with crowdin (#15175) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * chore: TransferFormAccountCard unit test (#15140) * chore: select dxtrade account by default (#15132) * chore: remove description and buttons (#15063) * [coj]/likhith/coj-775/added dependencies of accounts to externals to consume from core (#15106) * chore: added dependencies to externals to consume from core * fix: repnamed js to TS extension * [WALL] aum / WALL-3808 / show-latest-balance-wallet-cashier-overlay-and-wallet-header (#15014) * feat: added useBalanceSubscription hook * feat: replaced balance in the header with subscribable balance * feat: added balance subscription for wallet header balance * feat: added unit tests for balance for WalletCashierHeader * chore: fix sonarcloud issues * chore: added data-testid for the real/demo wallet switcher * chore: fix integration test for balance * fix: added subscribed balance call to wallet card in mobile carousel * fix: fix integration tests * fix: balance glitching on switching wallet in carousel * [DTRA] Farhan/WEBREL-2/Test coverage: error-component & Page404 in Reports (#15109) * chore: test cases for error and page404 component * chore: add test case * fix: add tests (#15136) * DTRA/ Kate / WEBREL-5 / Add tests for loader component (#15104) * refactor: add tests for loader component * chore: empty commit for checks retriggering * fix: do not ignore locales when switching between languages (#15043) * chore: disclaimer update (#15150) * translations: 📚 sync translations with crowdin (#15191) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * chore: 🔥 fix the active_symbols refetching issue on bot (#15151) * chore: 🔥 fix the active_symbols refetching issue on bot * chore: 🔥 added useeffect to refrain the bot from calling the api multiple times' * translations: 📚 sync translations with crowdin (#15192) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * chore: TransferFormAccountSelection unit test (#15124) * [WALL] Jim/WALL-4001/ Send email when forgot password is clicked (#15107) * chore: send email when forgot password is clicked * chore: add sendemail call to modal on mobile * chore: rename hook * docs: add tsdoc * chore: add sendemail to dependency array * chore: add error handling logic * chore: add error handling for sent email template * chore: remove unnecessary dependencies * [WALL] aum / WALL-2990/ unit-test-transfer-form (#15162) * perf: added a test case and some mocks for TransferForm tests * perf: added more test cases * perf: added more test cases * chore: transfer api error (#15203) * [WALL] Lubega / WALL-3274 / Crypto connection and cryptocurrency suspend API errors (#15074) * feat: suspend cryptocurrency deposit * Merge branch 'master' of github.com:binary-com/deriv-app into WALL-3274/suspend-cryptocashier-deposit * fix: updated unit tests * fix: updated withdrawal error screen unit test * chore: added check for CryptoConnectionError * chore: added providers for deposit and withdrawal error screens * fix: updated content components * fix: updated component structure * [WALL] Aizad/wall 3964/wallet onboarding (#15099) * feat: wait for switch * chore: Implement new joyride steps * chore: update react-joyride and remove old joyride implementation * chore: small style changes for Desktop flow * chore: update steps in tour guide * chore: update onboarding for Mobile view for wallets * chore: refactor tour guide for wallets * chore: fix test case for AccountList * chore: refactor joyride * feat: reverted back to previous version * chore: i think i fix the flickering 👀 * chore: replace deriv/react-joyride with the react-joyride * chore: update import statements * chore: fix not scrolling when press back * chore: fix test cases * chore: added small changes for tour guide --------- Co-authored-by: Wojciech Brygola <wojciech@regentmarkets.com> * [CFDS] Hasan/CFDS-3424/mt5 deeplink redirect issue (#14547) * chore: console mobile os detect func * chore: console mobile os detect func * chore: console mobile os detect func * chore: updated mobile os detect function * chore: updated mobile os detect function * chore: created async based os detect function * chore: console * chore: console * chore: test react-device-detect package * chore: test react-device-detect package * chore: test react-device-detect package * Revert "chore: test react-device-detect package" This reverts commit 1ec874f. * Revert "chore: test react-device-detect package" This reverts commit a71712a. * Revert "chore: test react-device-detect package" This reverts commit 397a006. * chore: test new regex * chore: test new regex * Revert "chore: test new regex" This reverts commit 7483513. * Revert "chore: test new regex" This reverts commit fba5af8. * chore: removed test useEffect * chore: updated test cases * fix: sonarcloud issues * fix: updated huawei regex * fix: console * fix: removed updated regex * fix: updated regex * fix: updated regex to Set * chore: console ua parser * chore: console ua parser * Revert "chore: console ua parser" This reverts commit 4f6e581. * Revert "chore: console ua parser" This reverts commit 6d3e714. * chore: merge master * feat: add test coverage for empty trade history message and indicative cell (#15194) * [DTRA] henry/dtra-1237/fix: dtrader-v2 setup (#14991) * fix: initial setup * fix: partially finished setup * fix: ensure new header only appears for mobile * fix: quill-ui version bump * fix: change classnames * fix: change to kebab case file names * fix: resolve comments * fix: add color to text * fix: add tests * fix: sonarcloud * fix: sonarcloud issues * fix: parse JSON with try catch in case FeatureFlagsStore returns empty * fix: change to quill icons * fix: add missing css * fix: change hamburger menu icon to standalone * fix: move quill-ui to core and wrap application with themeprovider * fix: import themeprovider from quill/ui * fix: wrong import * fix: remove unused css and make header bold * fix: make labels red when active * fix: change text to correct component * fix: move themeprovider to appcontent to react to changes in store * chore: reset package lock * fix: update package-lock and add quill-ui to traders package * fix: jest config error * fix: ignore errors from quill-ui * fix: jest config and add babel config * fix: remove a plugin * fix: lets try this * fix: remove irrelevant files * fix: test * fix: change * fix: asdf * fix: errors * fix: give contract details page a new header * [DTRA] Maryia/DTRA-1265/fix: improve alignment in open positions for desktop (#15053) * fix: alignment in open positions * fix: take profit for accu alignment * translations: 📚 sync translations with crowdin (#15215) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * translations: 📚 sync translations with crowdin (#15219) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * refactor(deriv_go): updated Deriv Go's app links paths for dev and staging (#15141) * refactor(deriv_go): updated Deriv Go's app links paths for dev and staging with the correct ones * refactor(p2p): added dp2p to the webcredentials * fix: added the path to `36S5Q8S4V5.com.deriv.app` * chore: update copy for onboarding (#15218) * chore: removed get more button and modal (#15115) * [coj]/likhith/wall-4066/locked onfido version to prevent unintended changes (#15133) * chore: locked onfido version to prevent unintented changes * fix: height for Iphone 8 devices * [WALL]Hasan/WALL-3823/Incorrect field highlighting (#15049) * fix: password modal server error * chore: remove console * [coj]/likhith/coj-795/install deriv sharable libs to account package (#15120) * chore: added deriv sharable libs to account package * fix svg icons * chore: added deriv sharable libs to account package * chore: trigger rebuild * Merge branch 'master' into likhith/coj-795/setup-deriv-utils-and-quill-icons-in-account * [WALL] Test case for TransferReceipt (#15010) * chore: added test cases for transfer receipt * chore: fix eslint issues on test cases * chore: resolved review comments * [DTRA] Maryia/build: update quill-ui library version to 1.9.27 + utilize lib styles (#15235) * build: update quill-ui lib version to 1.9.27 * fix: utilize quill.css file * translations: 📚 sync translations with crowdin (#15240) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * [TRAH-3259]: chore: add comment to pull requests with bundle size information (#15172) * [WALL] Aizad/WALL-4096/Skip Step Add More Wallets (#15249) * chore: added boolean checks if all of the available wallets are added * chore: reduce flickering issues * chore: transactions unit test (#15250) * [CFDS] shontzu/CFDS-3502/unexpected-behaviour-upon-clicking-dynamic-leverage (#15139) * style: fix transition glitch * style: minor animation duration tweaks * fix(wallets): 🚑 fix demo cfd balance (#15230) * fix(wallets): 🚑 fix deposit iframe loading (#15252) * fix: fix routing to wallet transfer on clicking manage funds button in account settings page (#15204) * chore: get the last successful master artifact (#15253) * Jim/wall 4000/too many attempts modal doesnt appear new (#15220) * chore: send email when forgot password is clicked * chore: add sendemail call to modal on mobile * chore: rename hook * docs: add tsdoc * chore: add sendemail to dependency array * chore: add error handling logic * chore: add error handling for sent email template * chore: add modal with lightbox in mobile Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * chore: add password limit modal * chore: remove prop causing re-rendering * chore: remove title from email modal * chore: move modal title from the body to the header * chore: rename classes --------- Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> * [WALL] Jim/WALL-4121/Split modals and move modal titles to the header (#15251) * chore: move title to the header section * chore: retrieve markettype from prop * chore: remove unnecessary prop and make it optional in the host component * chore: transfer message unit test (#15222) * build: add quill-tokens lib + update quill-ui lib (#15266) * [DTRA] Maryia/DTRA-1206/fix: request contract history in Contract details on every language change (#15007) * fix: request contract_update_history on every lang change * refactor: contract audit * revert: unnecessary file that slipped through during merging * refactor: address comments * refactor: rename prop * [DTRA]Ahmad WEBREL-21/Reports.tsx Coverage (#15164) * fix: reports test * fix: sonar cloud fix * fix: review fix * translations: 📚 sync translations with crowdin (#15271) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * chore: update @deriv/deriv-charts to 2.1.17 (#15273) Co-authored-by: balakrishna-deriv <balakrishna-deriv@users.noreply.github.com> * fix: market closed (#15157) * [TRAH-3380] shahzaib / remove authorization and loader from options & multipliers] (#15013) * chore: removed platfrom loader from options & multiplier * chore: check for residence from account list * fix: platform description for trading card * chore: removed unused variables * chore: removed unused imports * chore: cfd section loading * chore: persist available trading platforms in localstorage * [TRAH-3250] thisyahlen / shahzaib - remove disclaimers from real account creation (#14836) * chore: remove disclaimers from real account creation * fix: tests * chore: remove inline message disclaimer * chore: update test * chore: update content * chore: change width for mobile * chore: change width * chore: add personal details message * fix: poi test case * chore: update address details heading * chore: removed unused imports --------- Co-authored-by: Shahzaib <shahzaib@deriv.com> * [TRAH]/MITRA/TRAH-3395/ Update descriptions on Wallets (#15121) * feat: 💬 update descriptions * build: 🏗️ trigger build * fix: 🐛 change the option description * chore: 🏗️ trigger build * fix: 🐛 add i18n for translation * chore: 🏗️ trigger build * chore: 🏗️ trigger build * chore: 🏗️ trigger build * fix: 🐛 change options & mulitpliers to options (#15244) * chore: fix bottom nav scroll (#15279) * Aizad/WALL-4039/Resize Logo in Transfer Summary Details on Transaction Screen (#15070) * chore: replace WalletsAppLinkedWithWalletIcon with WaleltMarketCurrencyIcon * chore: Fix type error * chore: change true to isDemo * chore: change default from All to null * chore: fix typescript errors * chore: fix typescript errros pt.2 * chore: improve logic within WalletMarketCurrenyIcon * chore: standardize logic across features * chore: change z-index for market icon * chore: update border radius according to design * chore: update all of the icons for transaction rows to have border-radius 4px * [TRAH]/Mitra/TRAH-3230/Show real sign up modal once demo creation is done (#14749) * feat: ✨ show real sign up modal once demo creation is done * feat: 🚩 add feature flag * feat: ✨ land client on demo for row who can have diel * fix: 🔊 putting log to check the value * feat: 🐛 fix name of the feature flag * fix: 🐛 remove eslint disable line * fix: 🐛 set is from sign up to false when client close the modal * fix: 🐛 new fix * feat: 🔥 remove tour guide from tradershub * fix: 🧪 fix test failure * Revert "feat: 🔥 remove tour guide from tradershub" This reverts commit fed9653. * Revert "Revert "feat: 🔥 remove tour guide from tradershub"" This reverts commit ada5cb2. * fix: 🧪 make test green * fix: 🐛 try the fix * fix: 🐛 fix console error * Hirad/wall-4006/ Terminal button will call the token and redirect user with a new token (#15119) * chore: moved the token call to click of the button * chore: made changes to pass the tests * fix: remove extra return statements (#15286) * chore: remove comment posting for analyze job (#15264) * [P2PS] farrah/P2PS-1953/feat: ad terms (#13636) * feat: add unavailable button * fix: translation * feat: ad terms flow * fix: review comments * fix: moved eligibility function to utils * fix: refactor code * feat: add eligible countries * fix: test * fix: remove unnecessary change * fix: subtasks * fix: tests * fix: message type * fix: subtasks * fix: subtasks * fix: subtasks * fix: sorting of country list * fix: subtask * Aizad/WALL-3825/Date picker in Wallets following production (#14940) * chore: update datepicker component following production * chore: refactor code and styles * chore: remove console errors by replacing undefined with empty string * chore: for mobile show native datepicker * chore: added improvements for native datepicker * chore: move styling to the base component style * chore: make background text transparent * chore: remove keyboard interaction on mobile * chore: hide keyboard * chore: addressing comments and reverting unneeded changes * chore: update component with their own stylesheet * chore: retrigger * [WALL] Rostislav / WALL-3456 / Wallets post-migration UX (successful & unsuccessful) (#14472) * chore: init * refactor: remove acknowledge * fix: modals too wide * feat: redirect to wallets once completed migration * refactor: a small alignment * fix: a mistake * refactor: cookie * refactor: exp backoff in useWalletMigration * refactor: seconds val * fix(wallets): 🚑 try again button for unsuccessful migrations, fix style issues * fix: broaden migration closing condition * fix: avoid update loop * refactor: account for breaking connection * fix: wall-4063 * fix: wall-4062 * fix: dont show appstore migration modals when passkeys modal is open --------- Co-authored-by: heorhi-deriv <heorhi@binary.com> * [WALL] [Fix] Rostislav / WALL-3923 / ATM input "select & type in fraction" behavior adjustments (#14984) * fix: the wall-3923 general case * fix: more specific cases * refactor: onkeydown onkeyup * fix: ci * translations: 📚 sync translations with crowdin (#15297) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * translations: 📚 sync translations with crowdin (#15299) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * [BOT] Farabi/bot-1601/dbot bugs and improvements (#15086) * fix: notification visibility and qs form alignment * chore: update toast visibility handler * fix: summary and transactions view detail for different language * chore: removed download and view detail icon * fix: transaction panel profit alignment * translations: 📚 sync translations with crowdin (#15300) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * [WALL] Lubega / WALL-4133 / Refactor withdrawal and deposit error handling (#15293) * chore: refactor withdrawal and deposit error handling * fix: optional chaining * fix: applied comments * Merge branch 'master' of github.com:binary-com/deriv-app into WALL-4133/refactor-withdrawal-and-deposit-error-handling * fix: updated wallet cashier header * fix: error typing * [WALL] [Fix] Rostislav / WALL-4135 / Fix wallet name in wallet account switcher looking odd in-between switches (#15289) * fix: get rid of intermediate state * refactor: @wojciech-deriv suggestion * [BOT]test: added missing test case in qs folder (#15304) * test: added missing test case in qs folder * fix: implemented review comments * translations: 📚 sync translations with crowdin (#15306) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * fix: translation not handled for header fix (#15310) * [COJ]/likhith/coj-1123/chore: remove unused dependencies in account package (#15193) * chore: remove unused dependencies * chore: installed @deriv/translations * [WALL] [Jest] Rostislav / WALL-3047 / Unit test for Tooltip component (#15311) * test: add unit tests for tooltip * refactor: typo * [WEBREL]/Mitra/[WEBREL-2748] Remove the condition as we use the component for bot… (#15309) * fix: 🚑 remove the condition as we use the component for both CFD and Options * fix: 🐛 remove passing the props * Revert "[WEBREL]/Mitra/[WEBREL-2748] Remove the condition as we use the compo…" (#15321) This reverts commit dedf00f. * Revert "[TRAH-3380] shahzaib / remove authorization and loader from options &…" (#15323) This reverts commit c3ecc88. * [WEBREL]/Mitra/[WEBREL-2753] remove crypto subheader (#15316) * fix: 🐛 remove crypto subhead * fix: 🧪 fix failing test * translations: 📚 sync translations with crowdin (#15324) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * fix: user_id attribute missing on rudderstack (#15305) * Aswathy/CRO-566/Tradershub trackevent dashboard updated (#15134) * fix: updated the tracking values * fix: removed the unwanted import * fix: removed the type from market_type * fix: added the condition for the open action * fix: peer comments * chore: update @deriv/deriv-charts to 2.1.18 (#15319) Co-authored-by: balakrishna-deriv <balakrishna-deriv@users.noreply.github.com> * fix: add defaultFile (#15292) * [WALL] aum / WALL-3614 / fix-reopening-file-upload-poi-poa-for-bvi-account-creation (#14711) * fix: reopening of file selector when uploading of files * chore: fix Dropzone for uploading docs on click * chore: minor style fix * fix: fix the reopening issue of dropzone for identity card upload * [WALL] Fix button not disabled upload and added error screen for duplicate upload (#14703) * fix: issue with datepicker selection and button not disabled upload * chore: fix test cases * chore: removed documentation for p2p-country-list hook * feat: added flow for manual upload error screens * chore: updated content for error * chore: removed test variables * chore: navigate user back to document selection * [WALL] aum / WALL-4029 / fix-CFDs-password-flows (#15122) * fix: fix issues with CFDs password flows - Fix height of success modal in mobile - Fix the title of the modal screens based on selected account - Added WalletErrorMT5Password screen for investor password error - Tried to fix most errors for MT5, MT5Investor, DerivX password issues * fix: fix more issues with footer * fix: sonar issues * chore: add header back for success popup MT5 * fix: header for mt5 investor password reset error and success * [COJ]/likhith/[coj-1131]chore: remove account-v2 checks from CI (#15320) * chore: remove account-v2 checks from test.yml and chore/build * chore: removed route check * chore: removed prod and local build and test for account-v2 * chore: added jest config to ignore account-v2 * Fasih/Removed unused code and unused imported variables (#15039) * chore: removed unused code and unused imported variables * chore: reverted passkey file * chore: removed unused code * chore: removed unused code * chore: removed unused code * redeploy: 🚀 to redeploy and trigger build * chore: removed unwanted code * chore: removed unused and duplicated file --------- Co-authored-by: Muhammad Fasih Ali Naqvi <muhammadfasih@Muhammad-Fasihs-Mac-X7KDC4NKQ0-Standard.local> * [WALL] george / WALL-4126 / If the wallet balance is less than the minimum withdrawal amount, the withdrawal limit shown below the amount field displays in a Max-Min pattern (#15265) * feat(wallets): 🚑 add balanceLessThanMinWithdrawalLimit cehck to crypto withdraw * test(wallets): 🧪 add test case * [WALL] [Jest] Rostislav / WALL-3050 / Unit tests for `<WalletClipboard />` (#15317) * test: add test file for WalletClipboard * test: add test case for timeout * refactor: `fireEvent -> userEvent` * refactor: a few adjustments * refactor: a small change * fix: inconsistency * refactor: better strucure * fix: compare accounts and jurisdiction fixes (#15338) * [WALL] aum / WALL-4145 / next-button-not-disabled-if-missing-file-for-poi-poa (#15336) * fix: disabling of next button if file is missing in poi or poa flows * fix: fix types and ci --------- Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com> Co-authored-by: lubega-deriv <142860499+lubega-deriv@users.noreply.github.com> Co-authored-by: Aum Bhatt <125039206+aum-deriv@users.noreply.github.com> Co-authored-by: adrienne-deriv <103016120+adrienne-deriv@users.noreply.github.com> Co-authored-by: Dhruv Neb <158162395+Dhruv-deriv@users.noreply.github.com> Co-authored-by: Dhruv-deriv <dhruv@deriv.com> Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <fe-access@regentmarkets.com> Co-authored-by: Rostik Kayko <119863957+rostislav-deriv@users.noreply.github.com> Co-authored-by: Aizad Ridzo <103104395+aizad-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Maryia <103177211+maryia-deriv@users.noreply.github.com> Co-authored-by: hirad-deriv <hirad@re-work.dev> Co-authored-by: Mark Wylde <129744061+markwylde-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> Co-authored-by: mitra-deriv <64970259+mitra-deriv@users.noreply.github.com> Co-authored-by: Wojtek B <141034155+wojciech-deriv@users.noreply.github.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: Matin shafiei <matin@deriv.com> Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com> Co-authored-by: balakrishna-deriv <balakrishna-deriv@users.noreply.github.com> Co-authored-by: rupato-deriv <97010868+rupato-deriv@users.noreply.github.com> Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> Co-authored-by: ameerul-deriv <103412909+ameerul-deriv@users.noreply.github.com> Co-authored-by: Niloofar Sadeghi <93518187+niloofar-deriv@users.noreply.github.com> Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com> Co-authored-by: fasihali-deriv <121229483+fasihali-deriv@users.noreply.github.com> Co-authored-by: Muhammad Fasih Ali Naqvi <muhammadfasih@Muhammad-Fasihs-Mac-X7KDC4NKQ0-Standard.local> Co-authored-by: Habib Deriv <88178645+habib-deriv@users.noreply.github.com> Co-authored-by: Mark <129744061+markw-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Farrah Mae Ochoa <82315152+farrah-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Farhan Ahmad Nurzi <125247833+farhan-nurzi-deriv@users.noreply.github.com> Co-authored-by: henry-deriv <118344354+henry-deriv@users.noreply.github.com> Co-authored-by: Wojciech Brygola <wojciech@regentmarkets.com> Co-authored-by: Hasan Mobarak <126637868+hasan-deriv@users.noreply.github.com> Co-authored-by: Bassam El Obeid <127500305+bassam-deriv@users.noreply.github.com> Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com> Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@deriv.com> Co-authored-by: heorhi-deriv <heorhi@binary.com> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> Co-authored-by: amir ali <129206554+amir-deriv@users.noreply.github.com> Co-authored-by: Aswathy-Deriv <96725617+aswathy-deriv@users.noreply.github.com>
vinu-deriv
pushed a commit
to vinu-deriv/deriv-app
that referenced
this pull request
May 28, 2024
* chore: removed platform context * chore: removed unused code * chore: removed unused classname and fixed condition * chore: fixed test and remove is app store * chore: removed unused code * chore: removed unused type * chore: removed unused types * chore: removed unused classname * chore: reverted back scss changes done by prittier * chore: removed unused param --------- Co-authored-by: Muhammad Fasih Ali Naqvi <muhammadfasih@Muhammad-Fasihs-Mac-X7KDC4NKQ0-Standard.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Removed platformContext