Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[COJ][TRAH-3427]/Dhruv/amina mt5 defaulting jurisdiction #16540

Merged
merged 161 commits into from
Oct 24, 2024
Merged

[COJ][TRAH-3427]/Dhruv/amina mt5 defaulting jurisdiction #16540

merged 161 commits into from
Oct 24, 2024

Conversation

amina-deriv
Copy link
Contributor

Changes:

Default jurisdction for MT5

Screenshots:

Please provide some screenshots of the change.

Dhruv-deriv and others added 17 commits July 31, 2024 11:58
@Dhruv-deriv
chore: empty commit
6d08122
@Dhruv-deriv
fix: Removed Jurisdiction, POI, POA, Personal details from mt5
b624318
@Dhruv-deriv
fix: removed comments
1f3cc81
@Dhruv-deriv
fix: fixec
c8e27c3
@Dhruv-deriv
fix: removed styles
a604539
@Dhruv-deriv
fix: removed POI files for mt5
12c940b
@amina-deriv
fix: modal
fe426fa
@Dhruv-deriv
fix: removed store variables
1ec65be
@amina-deriv
fix: Add_and_enter_password_modals
a393531
@amina-deriv
fix: mt5 default account
f487297
@Dhruv-deriv
fix: resolved comments and added file which was removed
2570560
@amina-deriv
Merge pull request #111 from Dhruv-deriv/TRAH-3834/Remove-jurisdictio…
4510149 
…n-screens/dhruv

dhruv/TRAH-3834/Remove-JurisdictionScreens-MT5
@amina-deriv
Merge pull request #112 from amina-deriv/amina/password_modal
70b6529 
Amina/password modal
@amina-deriv
fix: conflicts
51d919f
@amina-deriv
fix: testing modal
0bb966a
@amina-deriv
Merge branch 'dhruv/amina_mt5_defaulting_jurisdiction' of github.com:…
44f0779 
…amina-deriv/deriv-app into amina/password_modal
@amina-deriv
Merge pull request #114 from amina-deriv/amina/password_modal
9bacd60 
Amina/password modal
@vercel Vercel
Copy link

vercel bot commented Aug 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 23, 2024 5:52pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/deriv-com/deriv-app/pull/16540](https://github.com/deriv-com/deriv-app/pull/16540)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-dhruv-aminamt5defaultingj-48d1a5.binary.sx?qa_server=red.derivws.com&app_id=23934
    - **Original**: https://deriv-app-git-fork-amina-deriv-dhruv-aminamt5defaultingj-48d1a5.binary.sx
- **App ID**: `23934`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 19, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-dhruv-aminamt5defaultingj-48d1a5.binary.sx/

Dhruv-deriv and others added 2 commits October 15, 2024 07:59
@Dhruv-deriv
fix: scroll fix
4d19b76
@likhith-deriv
Merge pull request #132 from Dhruv-deriv/dhruv/compare_accounts_scrol…
8134d4b 
…l_issue/TRAH-4310

dhruv/Compare_accounts_scroll_issue/ TRAH-4310
Dhruv-deriv and others added 3 commits October 23, 2024 18:40
@github-actions GitHub Actions
Copy link
Contributor

⏳ Generating Lighthouse report...

@likhith-deriv likhith-deriv merged commit b723364 into deriv-com:master Oct 24, 2024
5 of 6 checks passed
shahzaib-deriv added a commit that referenced this pull request Oct 25, 2024
@shahzaib-deriv
Revert "[COJ][TRAH-3427]/Dhruv/amina mt5 defaulting jurisdiction (#16540
39c366b 
)"

This reverts commit b723364.
@shahzaib-deriv shahzaib-deriv mentioned this pull request Oct 25, 2024
Merged
shahzaib-deriv added a commit that referenced this pull request Oct 25, 2024
@shahzaib-deriv
Revert "[COJ][TRAH-3427]/Dhruv/amina mt5 defaulting jurisdiction (#16540
6fb892b 
)" (#17325)

This reverts commit b723364.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dhruv-deriv Dhruv-deriv Dhruv-deriv left review comments

@yauheni-deriv yauheni-deriv yauheni-deriv left review comments

@matin-deriv matin-deriv matin-deriv left review comments

@suisin-deriv suisin-deriv suisin-deriv approved these changes

@farrah-deriv farrah-deriv farrah-deriv approved these changes

@likhith-deriv likhith-deriv likhith-deriv left review comments

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@maryia-deriv maryia-deriv Awaiting requested review from maryia-deriv

@hirad-deriv hirad-deriv Awaiting requested review from hirad-deriv hirad-deriv is a code owner

@nijil-deriv nijil-deriv Awaiting requested review from nijil-deriv nijil-deriv is a code owner

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@habib-deriv habib-deriv Awaiting requested review from habib-deriv habib-deriv is a code owner

@sandeep-deriv sandeep-deriv Awaiting requested review from sandeep-deriv sandeep-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

@heorhi-deriv heorhi-deriv Awaiting requested review from heorhi-deriv heorhi-deriv is a code owner

@jim-deriv jim-deriv Awaiting requested review from jim-deriv jim-deriv is a code owner

@vinu-deriv vinu-deriv Awaiting requested review from vinu-deriv vinu-deriv is a code owner

@shafin-deriv shafin-deriv Awaiting requested review from shafin-deriv shafin-deriv is a code owner

@dan-deriv dan-deriv Awaiting requested review from dan-deriv dan-deriv is a code owner

Assignees
No one assigned
Labels
Account AppStore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@amina-deriv @coveralls @matin-deriv @farrah-deriv @likhith-deriv @suisin-deriv @yauheni-deriv @Dhruv-deriv