-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UPM-1303]/evgeniy/livechat name and email not populated #16676
Merged
likhith-deriv
merged 63 commits into
deriv-com:master
from
yauheni-deriv:livechat/upm-1303-name_and_email_not_populated
Oct 16, 2024
Merged
[UPM-1303]/evgeniy/livechat name and email not populated #16676
likhith-deriv
merged 63 commits into
deriv-com:master
from
yauheni-deriv:livechat/upm-1303-name_and_email_not_populated
Oct 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yauheni-deriv
requested review from
ali-hosseini-deriv,
matin-deriv and
maryia-deriv
as code owners
August 29, 2024 12:21
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
heorhi-deriv
previously approved these changes
Aug 29, 2024
maryia-matskevich-deriv
previously approved these changes
Aug 29, 2024
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-yauheni-deriv-livechat-upm-1303-namea-9f4db1.binary.sx/ |
Dhruv-deriv
reviewed
Aug 30, 2024
packages/core/src/App/Components/Elements/LiveChat/use-livechat.ts
Outdated
Show resolved
Hide resolved
Dhruv-deriv
approved these changes
Aug 30, 2024
yauheni-deriv
dismissed stale reviews from maryia-matskevich-deriv and heorhi-deriv
via
August 30, 2024 08:16
689d960
yauheni-deriv
temporarily deployed
to
Preview
September 2, 2024 05:23
— with
GitHub Actions
Inactive
yauheni-deriv
requested review from
adrienne-deriv,
thisyahlen-deriv and
wojciech-deriv
as code owners
September 4, 2024 14:20
likhith-deriv
approved these changes
Oct 16, 2024
suisin-deriv
approved these changes
Oct 16, 2024
heorhi-deriv
approved these changes
Oct 16, 2024
matin-deriv
approved these changes
Oct 16, 2024
prince-deriv
added a commit
that referenced
this pull request
Oct 19, 2024
* [WALL] george / WALL-4973 / Remove @deriv/ui library from cashier package (#17086) * perf(cashier): 🔥 replace deriv-ui with deriv-com/ui * chore: 📝 update package-lock * chore: update package-lock * chore: bump deriv-com/ui version * translations: 📚 sync translations with crowdin (#17165) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * fix: when remove verified number from BO, UI should update automatically (#17111) * chore: add rms to translations codeowners (#17170) * chore: add rms to translations codeowners * chore: add akmal to the codeowners * chore: update bottom disclaimer percentage (#17135) * chore: MF content update (#17154) chore: MF tnc content update * translations: 📚 sync translations with crowdin (#17175) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * Revert "Akmal / feat: change default chart style from ticks to candles (#16645)" (#17179) (#17182) This reverts commit d09f4ca. Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> * DTRA-1969 + 2061 / Kate / Translation fixes (#17081) * fix: translation for contract details reports and fixed position tab navigation * fix: add translation for buy and sell * refactor: add tests and remove extra files * chore: remove type assertion * chore: test renaming * chore: add comments * fix: set default trade type when switching to vanillas and turbos (#17159) * [BOT] sandeep/refactor: 🔥 remove binary-utils package (#17169) * refactor: 🔥 remove binary-utils package * refactor: 🔥 moved common function into binary-utils.js * fix: blank screen (#17149) * [WALL] Lubega / WALL-2928 / ModalTradeWrapper unit test (#17162) * chore: modal trade wrapper unit test * chore: modal trade wrapper unit test * [WALL] Lubega / WALL-4911 / Migrate wallets utils to deriv-com/utils (#17010) * chore: migrate utils to deriv-com/utils * fix: remove react-node-to-string * fix: update library version * translations: 📚 sync translations with crowdin (#17191) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * chore: update auth-client library (#17194) * fix: 🚑 format amount and transaction fee (#17153) * fix: removed integration package (#17201) * fix: issue with user not able resubmit poa (#17189) * chore: updated packahe version (#17202) * Update pushDataLayer to check logged in state of user (#16561) * chore: update pushDataLayer to check logged in state of user * Update packages/core/src/Stores/gtm-store.js Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> * chore: callbacks to async/await * chore: add optional chaining --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> * [UPM-1303]/evgeniy/livechat name and email not populated (#16676) * fix: [UPM-1303]/evgeniy/livechat name and email not pipulated * chore: remove comments * refactor: livechat init and usage * chore: remove old hook from redirect component * chore: add tests for hooks * fix: failing test case * chore: removed unused import * chore: update package-lock * chore: remove icons, isMounted * fix: reverted icons * fix: revert useremote default * chore: review comments, refactor appcontent * fix: lc call in cashier * chore: change name of client store new field * fix: ts error * fix: update psckage lock * fix: update deps * chore: update package-lock * fix: update package lock and fix code * fix: removed old lc_api call * fix: using old api to close opened chat after loggin out * fix: stop fetching account settings after logging out * chore: update package-lock * fix: close chat before hidding it after logout * fix: resolve conflict * fix: resolve conflicts * [UPM1539] Suisin/fix: user coming from personal detail when verified not route to TH (#17101) * fix: user coming from personal detail when verified not route to TH * chore: fix routing issue when coming from personal details page * [P2PS] - Nada/P2PS-4249/fix: staging deriv to staging p2p (#17143) * fix: staging deriv to staging p2p * fix: glitch * fix: use is p2p enabled * fix: test redirection * fix: redirection fix * fix: check for p2p standalone enabled * CSIT-1539/Prince/Release PR/Freshchat Integration + Feature Flag toggle (#17196) * chore: fresh chat integration * fix: update script url * fix: update freshchat initialization * fix: show freshchat widget by default * fix: update useFreshChat hook * chore: loaded script from use-freshchat hook * fix: token undefined issue * fix: token issue for non-loggedin user * fix: remove temp auth * fix: chat ready issue, remove user when logged out * fix: update use freshchat hook * fix: point to freshchat js * fix: test temp js * fix: update freshchat hook * fix: update freshchat hook * fix: update locale config * fix: check fcwidget available * fix: update script and condition to check widget loaded * fix: update script * fix: remove language configs * fix: point to temp js * fix: freshchat url * chore: enable feature flag based on growthbook * chore: added query param flag enabler * fix: remove console * fix: close livechat widget when freshchat is enabled --------- Co-authored-by: Nuzhy-Deriv <nuzhy@deriv.com> * [WALL] george / WALL-4404 / The Life time limit for Crypto to include USD amount (#17049) * feat(wallets): 🎨 add approximate usd amount for lifetime limit * perf(wallets): 🔥 improve lifetime transfer messages * fix(wallets): 🚑 add approximate amount in USD for reminder * fix: spelling mistake * fix: issue WEBREL-3238 (#17209) (#17215) * fix: issue WEBREL-3238 * fix: failing testcase Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * DTRA-2089 / Kate / Digit fixes (#17161) * fix: digit win percentage update * refactor: add skeleton loader for win persentage * fix: remove chard rerender on digit contract switch * refactor: tests * fix: add condition (#17118) * [BOT] Farabi/bot-2299/add-usage-tracking-for-announcements (#17186) * chore: added rudderstack track events for announcement click * chore: added announcement action and close events * fix: pass announcement name as the main title and subform names * chore: added load strategy open event on import announcement click * fix: call the open load strategy event from config * Suisin/chore: add analytics to track error events (#17070) * chore: add analytics to track error events * chore: update tracking negative scenario events actions and subform * chore: change error_message to error_code * chore: update session timeout tracking event * [TRAH- 3476]/Amina-Likhith/add employment status and tin to real account signup (#15805) * chore: incorporated the new employment status and tin info * fix: employment status form * fix: employment status form * chore: merge master * chore: created validation configs * chore: added validations * feat: separate components for tin * feat: separate components for tin * feat: separate components for tin * fix: separate component wrapper for employment status, tax residence and tin * chore: incorporated validation schema * fix: close popover in tin fileds on scrolling * chore: created employment-tax-info section * fix: style changes for Real account sign up layout * chore: add_hook_for_tin_api_call * chore: changes useTinValidation Hook * chore: changes useTinValidation Hook * chore: implemented new validation config * chore: added validation check in Real account sign up * chore: default value for tax residence * chore: made tin optional * chore: add tin validation * fix: component * fix: checkbox * fix: import * chore: updted validation schema * chore: incorporated new checkbox in validation * fix: removed console statements * fix: binded value * fix: resolved import issue * chore: removed DesktopWrapper & MobileWrapper * chore: clear tax values on checkbox click * fix: checkbox for no tax info * fix: validation issue with no tin checkbox * fix: removed unused ref * fix: title text * fix: tin title * fix: tin title * fix: re-validation of tin field * fix: incorporated DOB fix * fix: resize issue * fix: button alignment in Tax section * fix: incorporated validation for IDV * fix: type * fix: tin validation issue * chore: added testcases for hook and tin schema * chore: added testcases to validation schema * chore: incorporated Personal details validation * chore: made tax residence mandatory * fix: submission of Real account signup data * fix: tin validation issues * fix: resolved tin validation * fix: reverted checkbox change * fix: failing testcases * fix: failing testcases * fix: removed console errors * fix: missing import * fix: missing import * fix: testcases for personal details config * chore: integrated tin auto config * fix: sending tin auto set value to BE * fix: resolved auto dirty form on load * fix: testcase checks * fix: incorporated new tin prop * fix: removed commented Tests * fix: removed commented Tests * fix: added employment status testcases * fix: sonarcloud issues * fix: failed testcases * fix: resolved sonarcloud issues * fix: added personal details validation * fix: reset testcases * fix: personal details * fix: personal details * fix: user profile testcase * fix: user profile testcase * fix: reset testcases * fix: added testcases wrt user profile * fix: MF creation form * fix: added validation for TIN when MF * fix: console error * chore: incorporated Translations and dayjs libs * fix: CSS comments * fix: tin comfirmation checkbox * fix: removed is_tin_mandatory check from Tax section * fix: displaying 0 * chore: included Account opening reason in Person details * chore: incorporated employment status update for TIN & emp status * fix: testcase * chore: added hook to trigger scroll * fix: incorporated emp status and tax restrictions * fix: added check for Tin & emp update * fix: resolved build error * added: notification * chore: added focus on Account opening reason field * fix: making tin mandatory * chore: trigger build * chore: make tin mandatory based on BE * fix: type issues * fix: tin field mandatory * fix: tin field mandatory * chore: added CSS to highlight field * fix: reverted testing changes * chore: added field focus * fix: build issues * fix: failing testcase * chore: remove unused component * chore: added missing type * fix: tin validation * fix: type failures * chore: added description * fix: incorporated review comments * fix: failing testcase * fix: incorporated review comments * fix: reverted change * chore: incorporated changes to Financial assessment * fix: updated render condition * fix: incorporated review comments * chore: disabled employment status * chore: updated quill-icon version * Merge branch 'master' into TRAH_3476/amina_likhith/add_employment_status_and_tin_to_real_account_signup * fix: package-lock * fix: failing testcase * fix: removed un-necessary condition * fix: issue TRAH-4258 * fix: TIN check for Real account creation * fix: TIN check for Real account creation * fix: data unsaved popup appearing from personal details * fix: resolved TRAH-4272, TRAH-4268 * fix: TRAH-4270 issue * fix: Personal details type * fix: reverted version --------- Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * fix: eslint errors occured during merge (#17227) * fix: destroy instead of minimize (#17229) * fix: redirection fro staging to p2p staging (#17231) (#17236) Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> * fix: idv update in real account creation (#17235) (#17239) Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * fix: misaligned employment-status field (#17242) (#17244) Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * [UPM-1679] Suisin/fix: error message alignment and spacing for inaccessible mt5 pop up … (#17192) * fix: error message alignment and spacing for inaccessible mt5 pop up modal * chore: update to have better text size for the error message * Mitra trah 3842 add deposit banner (#17233) * feat: create useStoreHasAccountDeposited hook and unit tests * refactor: move all th banners to one component * feat: intermediate result * feat: add svg images * feat: update banenr icon for responsive * feat: finished with styles for banner * feat: update ff name * refactor: change ff name again * feat: complete banner development * refactor: remove unused variable * fix: add isLoaded to hook * fix: add is_switching check for the banner * feat: undo changes * fix: 🐛 remove banner for DIEL clients * fix: 🐛 hide the banner for existing deil only --------- Co-authored-by: sergei-deriv <sergei@deriv.com> * DTRA-2035 / Kate / [DTrader-v2] Implement swiping functionality and fix TP/SL history title (#17173) * refactor: restructure config with pages * feat: add swipe handlers for carousel * fix: tests * refactor: chnage selecting title logic * refactor: make infinit loop optional * refactor: quill update * CSIT-1558/Prince/Livechat icon on testlinks (#17251) * fix: livechat icon on testlinks * fix: country data for growthbook --------- Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <fe-access@regentmarkets.com> Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Habib Deriv <88178645+habib-deriv@users.noreply.github.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: lubega-deriv <142860499+lubega-deriv@users.noreply.github.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Nuzhy-Deriv <nuzhy@deriv.com> Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: mitra-deriv <64970259+mitra-deriv@users.noreply.github.com> Co-authored-by: sergei-deriv <sergei@deriv.com>
prince-deriv
added a commit
that referenced
this pull request
Oct 19, 2024
* [WALL] george / WALL-4973 / Remove @deriv/ui library from cashier package (#17086) * perf(cashier): 🔥 replace deriv-ui with deriv-com/ui * chore: 📝 update package-lock * chore: update package-lock * chore: bump deriv-com/ui version * translations: 📚 sync translations with crowdin (#17165) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * fix: when remove verified number from BO, UI should update automatically (#17111) * chore: add rms to translations codeowners (#17170) * chore: add rms to translations codeowners * chore: add akmal to the codeowners * chore: update bottom disclaimer percentage (#17135) * chore: MF content update (#17154) chore: MF tnc content update * translations: 📚 sync translations with crowdin (#17175) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * Revert "Akmal / feat: change default chart style from ticks to candles (#16645)" (#17179) (#17182) This reverts commit d09f4ca. Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> * DTRA-1969 + 2061 / Kate / Translation fixes (#17081) * fix: translation for contract details reports and fixed position tab navigation * fix: add translation for buy and sell * refactor: add tests and remove extra files * chore: remove type assertion * chore: test renaming * chore: add comments * fix: set default trade type when switching to vanillas and turbos (#17159) * [BOT] sandeep/refactor: 🔥 remove binary-utils package (#17169) * refactor: 🔥 remove binary-utils package * refactor: 🔥 moved common function into binary-utils.js * fix: blank screen (#17149) * [WALL] Lubega / WALL-2928 / ModalTradeWrapper unit test (#17162) * chore: modal trade wrapper unit test * chore: modal trade wrapper unit test * [WALL] Lubega / WALL-4911 / Migrate wallets utils to deriv-com/utils (#17010) * chore: migrate utils to deriv-com/utils * fix: remove react-node-to-string * fix: update library version * translations: 📚 sync translations with crowdin (#17191) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * chore: update auth-client library (#17194) * fix: 🚑 format amount and transaction fee (#17153) * fix: removed integration package (#17201) * fix: issue with user not able resubmit poa (#17189) * chore: updated packahe version (#17202) * Update pushDataLayer to check logged in state of user (#16561) * chore: update pushDataLayer to check logged in state of user * Update packages/core/src/Stores/gtm-store.js Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> * chore: callbacks to async/await * chore: add optional chaining --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> * [UPM-1303]/evgeniy/livechat name and email not populated (#16676) * fix: [UPM-1303]/evgeniy/livechat name and email not pipulated * chore: remove comments * refactor: livechat init and usage * chore: remove old hook from redirect component * chore: add tests for hooks * fix: failing test case * chore: removed unused import * chore: update package-lock * chore: remove icons, isMounted * fix: reverted icons * fix: revert useremote default * chore: review comments, refactor appcontent * fix: lc call in cashier * chore: change name of client store new field * fix: ts error * fix: update psckage lock * fix: update deps * chore: update package-lock * fix: update package lock and fix code * fix: removed old lc_api call * fix: using old api to close opened chat after loggin out * fix: stop fetching account settings after logging out * chore: update package-lock * fix: close chat before hidding it after logout * fix: resolve conflict * fix: resolve conflicts * [UPM1539] Suisin/fix: user coming from personal detail when verified not route to TH (#17101) * fix: user coming from personal detail when verified not route to TH * chore: fix routing issue when coming from personal details page * [P2PS] - Nada/P2PS-4249/fix: staging deriv to staging p2p (#17143) * fix: staging deriv to staging p2p * fix: glitch * fix: use is p2p enabled * fix: test redirection * fix: redirection fix * fix: check for p2p standalone enabled * CSIT-1539/Prince/Release PR/Freshchat Integration + Feature Flag toggle (#17196) * chore: fresh chat integration * fix: update script url * fix: update freshchat initialization * fix: show freshchat widget by default * fix: update useFreshChat hook * chore: loaded script from use-freshchat hook * fix: token undefined issue * fix: token issue for non-loggedin user * fix: remove temp auth * fix: chat ready issue, remove user when logged out * fix: update use freshchat hook * fix: point to freshchat js * fix: test temp js * fix: update freshchat hook * fix: update freshchat hook * fix: update locale config * fix: check fcwidget available * fix: update script and condition to check widget loaded * fix: update script * fix: remove language configs * fix: point to temp js * fix: freshchat url * chore: enable feature flag based on growthbook * chore: added query param flag enabler * fix: remove console * fix: close livechat widget when freshchat is enabled --------- Co-authored-by: Nuzhy-Deriv <nuzhy@deriv.com> * [WALL] george / WALL-4404 / The Life time limit for Crypto to include USD amount (#17049) * feat(wallets): 🎨 add approximate usd amount for lifetime limit * perf(wallets): 🔥 improve lifetime transfer messages * fix(wallets): 🚑 add approximate amount in USD for reminder * fix: spelling mistake * fix: issue WEBREL-3238 (#17209) (#17215) * fix: issue WEBREL-3238 * fix: failing testcase Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * DTRA-2089 / Kate / Digit fixes (#17161) * fix: digit win percentage update * refactor: add skeleton loader for win persentage * fix: remove chard rerender on digit contract switch * refactor: tests * fix: add condition (#17118) * [BOT] Farabi/bot-2299/add-usage-tracking-for-announcements (#17186) * chore: added rudderstack track events for announcement click * chore: added announcement action and close events * fix: pass announcement name as the main title and subform names * chore: added load strategy open event on import announcement click * fix: call the open load strategy event from config * Suisin/chore: add analytics to track error events (#17070) * chore: add analytics to track error events * chore: update tracking negative scenario events actions and subform * chore: change error_message to error_code * chore: update session timeout tracking event * [TRAH- 3476]/Amina-Likhith/add employment status and tin to real account signup (#15805) * chore: incorporated the new employment status and tin info * fix: employment status form * fix: employment status form * chore: merge master * chore: created validation configs * chore: added validations * feat: separate components for tin * feat: separate components for tin * feat: separate components for tin * fix: separate component wrapper for employment status, tax residence and tin * chore: incorporated validation schema * fix: close popover in tin fileds on scrolling * chore: created employment-tax-info section * fix: style changes for Real account sign up layout * chore: add_hook_for_tin_api_call * chore: changes useTinValidation Hook * chore: changes useTinValidation Hook * chore: implemented new validation config * chore: added validation check in Real account sign up * chore: default value for tax residence * chore: made tin optional * chore: add tin validation * fix: component * fix: checkbox * fix: import * chore: updted validation schema * chore: incorporated new checkbox in validation * fix: removed console statements * fix: binded value * fix: resolved import issue * chore: removed DesktopWrapper & MobileWrapper * chore: clear tax values on checkbox click * fix: checkbox for no tax info * fix: validation issue with no tin checkbox * fix: removed unused ref * fix: title text * fix: tin title * fix: tin title * fix: re-validation of tin field * fix: incorporated DOB fix * fix: resize issue * fix: button alignment in Tax section * fix: incorporated validation for IDV * fix: type * fix: tin validation issue * chore: added testcases for hook and tin schema * chore: added testcases to validation schema * chore: incorporated Personal details validation * chore: made tax residence mandatory * fix: submission of Real account signup data * fix: tin validation issues * fix: resolved tin validation * fix: reverted checkbox change * fix: failing testcases * fix: failing testcases * fix: removed console errors * fix: missing import * fix: missing import * fix: testcases for personal details config * chore: integrated tin auto config * fix: sending tin auto set value to BE * fix: resolved auto dirty form on load * fix: testcase checks * fix: incorporated new tin prop * fix: removed commented Tests * fix: removed commented Tests * fix: added employment status testcases * fix: sonarcloud issues * fix: failed testcases * fix: resolved sonarcloud issues * fix: added personal details validation * fix: reset testcases * fix: personal details * fix: personal details * fix: user profile testcase * fix: user profile testcase * fix: reset testcases * fix: added testcases wrt user profile * fix: MF creation form * fix: added validation for TIN when MF * fix: console error * chore: incorporated Translations and dayjs libs * fix: CSS comments * fix: tin comfirmation checkbox * fix: removed is_tin_mandatory check from Tax section * fix: displaying 0 * chore: included Account opening reason in Person details * chore: incorporated employment status update for TIN & emp status * fix: testcase * chore: added hook to trigger scroll * fix: incorporated emp status and tax restrictions * fix: added check for Tin & emp update * fix: resolved build error * added: notification * chore: added focus on Account opening reason field * fix: making tin mandatory * chore: trigger build * chore: make tin mandatory based on BE * fix: type issues * fix: tin field mandatory * fix: tin field mandatory * chore: added CSS to highlight field * fix: reverted testing changes * chore: added field focus * fix: build issues * fix: failing testcase * chore: remove unused component * chore: added missing type * fix: tin validation * fix: type failures * chore: added description * fix: incorporated review comments * fix: failing testcase * fix: incorporated review comments * fix: reverted change * chore: incorporated changes to Financial assessment * fix: updated render condition * fix: incorporated review comments * chore: disabled employment status * chore: updated quill-icon version * Merge branch 'master' into TRAH_3476/amina_likhith/add_employment_status_and_tin_to_real_account_signup * fix: package-lock * fix: failing testcase * fix: removed un-necessary condition * fix: issue TRAH-4258 * fix: TIN check for Real account creation * fix: TIN check for Real account creation * fix: data unsaved popup appearing from personal details * fix: resolved TRAH-4272, TRAH-4268 * fix: TRAH-4270 issue * fix: Personal details type * fix: reverted version --------- Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * fix: eslint errors occured during merge (#17227) * fix: destroy instead of minimize (#17229) * fix: redirection fro staging to p2p staging (#17231) (#17236) Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> * fix: idv update in real account creation (#17235) (#17239) Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * fix: misaligned employment-status field (#17242) (#17244) Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * [UPM-1679] Suisin/fix: error message alignment and spacing for inaccessible mt5 pop up … (#17192) * fix: error message alignment and spacing for inaccessible mt5 pop up modal * chore: update to have better text size for the error message * Mitra trah 3842 add deposit banner (#17233) * feat: create useStoreHasAccountDeposited hook and unit tests * refactor: move all th banners to one component * feat: intermediate result * feat: add svg images * feat: update banenr icon for responsive * feat: finished with styles for banner * feat: update ff name * refactor: change ff name again * feat: complete banner development * refactor: remove unused variable * fix: add isLoaded to hook * fix: add is_switching check for the banner * feat: undo changes * fix: 🐛 remove banner for DIEL clients * fix: 🐛 hide the banner for existing deil only --------- Co-authored-by: sergei-deriv <sergei@deriv.com> * DTRA-2035 / Kate / [DTrader-v2] Implement swiping functionality and fix TP/SL history title (#17173) * refactor: restructure config with pages * feat: add swipe handlers for carousel * fix: tests * refactor: chnage selecting title logic * refactor: make infinit loop optional * refactor: quill update * CSIT-1558/Prince/Livechat icon on testlinks (#17251) * fix: livechat icon on testlinks * fix: country data for growthbook * fix: add livechat widget call check --------- Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <fe-access@regentmarkets.com> Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Habib Deriv <88178645+habib-deriv@users.noreply.github.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: lubega-deriv <142860499+lubega-deriv@users.noreply.github.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Nuzhy-Deriv <nuzhy@deriv.com> Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: mitra-deriv <64970259+mitra-deriv@users.noreply.github.com> Co-authored-by: sergei-deriv <sergei@deriv.com>
prince-deriv
added a commit
that referenced
this pull request
Oct 19, 2024
* [WALL] george / WALL-4973 / Remove @deriv/ui library from cashier package (#17086) * perf(cashier): 🔥 replace deriv-ui with deriv-com/ui * chore: 📝 update package-lock * chore: update package-lock * chore: bump deriv-com/ui version * translations: 📚 sync translations with crowdin (#17165) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * fix: when remove verified number from BO, UI should update automatically (#17111) * chore: add rms to translations codeowners (#17170) * chore: add rms to translations codeowners * chore: add akmal to the codeowners * chore: update bottom disclaimer percentage (#17135) * chore: MF content update (#17154) chore: MF tnc content update * translations: 📚 sync translations with crowdin (#17175) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * Revert "Akmal / feat: change default chart style from ticks to candles (#16645)" (#17179) (#17182) This reverts commit d09f4ca. Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> * DTRA-1969 + 2061 / Kate / Translation fixes (#17081) * fix: translation for contract details reports and fixed position tab navigation * fix: add translation for buy and sell * refactor: add tests and remove extra files * chore: remove type assertion * chore: test renaming * chore: add comments * fix: set default trade type when switching to vanillas and turbos (#17159) * [BOT] sandeep/refactor: 🔥 remove binary-utils package (#17169) * refactor: 🔥 remove binary-utils package * refactor: 🔥 moved common function into binary-utils.js * fix: blank screen (#17149) * [WALL] Lubega / WALL-2928 / ModalTradeWrapper unit test (#17162) * chore: modal trade wrapper unit test * chore: modal trade wrapper unit test * [WALL] Lubega / WALL-4911 / Migrate wallets utils to deriv-com/utils (#17010) * chore: migrate utils to deriv-com/utils * fix: remove react-node-to-string * fix: update library version * translations: 📚 sync translations with crowdin (#17191) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * chore: update auth-client library (#17194) * fix: 🚑 format amount and transaction fee (#17153) * fix: removed integration package (#17201) * fix: issue with user not able resubmit poa (#17189) * chore: updated packahe version (#17202) * Update pushDataLayer to check logged in state of user (#16561) * chore: update pushDataLayer to check logged in state of user * Update packages/core/src/Stores/gtm-store.js Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> * chore: callbacks to async/await * chore: add optional chaining --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> * [UPM-1303]/evgeniy/livechat name and email not populated (#16676) * fix: [UPM-1303]/evgeniy/livechat name and email not pipulated * chore: remove comments * refactor: livechat init and usage * chore: remove old hook from redirect component * chore: add tests for hooks * fix: failing test case * chore: removed unused import * chore: update package-lock * chore: remove icons, isMounted * fix: reverted icons * fix: revert useremote default * chore: review comments, refactor appcontent * fix: lc call in cashier * chore: change name of client store new field * fix: ts error * fix: update psckage lock * fix: update deps * chore: update package-lock * fix: update package lock and fix code * fix: removed old lc_api call * fix: using old api to close opened chat after loggin out * fix: stop fetching account settings after logging out * chore: update package-lock * fix: close chat before hidding it after logout * fix: resolve conflict * fix: resolve conflicts * [UPM1539] Suisin/fix: user coming from personal detail when verified not route to TH (#17101) * fix: user coming from personal detail when verified not route to TH * chore: fix routing issue when coming from personal details page * [P2PS] - Nada/P2PS-4249/fix: staging deriv to staging p2p (#17143) * fix: staging deriv to staging p2p * fix: glitch * fix: use is p2p enabled * fix: test redirection * fix: redirection fix * fix: check for p2p standalone enabled * CSIT-1539/Prince/Release PR/Freshchat Integration + Feature Flag toggle (#17196) * chore: fresh chat integration * fix: update script url * fix: update freshchat initialization * fix: show freshchat widget by default * fix: update useFreshChat hook * chore: loaded script from use-freshchat hook * fix: token undefined issue * fix: token issue for non-loggedin user * fix: remove temp auth * fix: chat ready issue, remove user when logged out * fix: update use freshchat hook * fix: point to freshchat js * fix: test temp js * fix: update freshchat hook * fix: update freshchat hook * fix: update locale config * fix: check fcwidget available * fix: update script and condition to check widget loaded * fix: update script * fix: remove language configs * fix: point to temp js * fix: freshchat url * chore: enable feature flag based on growthbook * chore: added query param flag enabler * fix: remove console * fix: close livechat widget when freshchat is enabled --------- Co-authored-by: Nuzhy-Deriv <nuzhy@deriv.com> * [WALL] george / WALL-4404 / The Life time limit for Crypto to include USD amount (#17049) * feat(wallets): 🎨 add approximate usd amount for lifetime limit * perf(wallets): 🔥 improve lifetime transfer messages * fix(wallets): 🚑 add approximate amount in USD for reminder * fix: spelling mistake * fix: issue WEBREL-3238 (#17209) (#17215) * fix: issue WEBREL-3238 * fix: failing testcase Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * DTRA-2089 / Kate / Digit fixes (#17161) * fix: digit win percentage update * refactor: add skeleton loader for win persentage * fix: remove chard rerender on digit contract switch * refactor: tests * fix: add condition (#17118) * [BOT] Farabi/bot-2299/add-usage-tracking-for-announcements (#17186) * chore: added rudderstack track events for announcement click * chore: added announcement action and close events * fix: pass announcement name as the main title and subform names * chore: added load strategy open event on import announcement click * fix: call the open load strategy event from config * Suisin/chore: add analytics to track error events (#17070) * chore: add analytics to track error events * chore: update tracking negative scenario events actions and subform * chore: change error_message to error_code * chore: update session timeout tracking event * [TRAH- 3476]/Amina-Likhith/add employment status and tin to real account signup (#15805) * chore: incorporated the new employment status and tin info * fix: employment status form * fix: employment status form * chore: merge master * chore: created validation configs * chore: added validations * feat: separate components for tin * feat: separate components for tin * feat: separate components for tin * fix: separate component wrapper for employment status, tax residence and tin * chore: incorporated validation schema * fix: close popover in tin fileds on scrolling * chore: created employment-tax-info section * fix: style changes for Real account sign up layout * chore: add_hook_for_tin_api_call * chore: changes useTinValidation Hook * chore: changes useTinValidation Hook * chore: implemented new validation config * chore: added validation check in Real account sign up * chore: default value for tax residence * chore: made tin optional * chore: add tin validation * fix: component * fix: checkbox * fix: import * chore: updted validation schema * chore: incorporated new checkbox in validation * fix: removed console statements * fix: binded value * fix: resolved import issue * chore: removed DesktopWrapper & MobileWrapper * chore: clear tax values on checkbox click * fix: checkbox for no tax info * fix: validation issue with no tin checkbox * fix: removed unused ref * fix: title text * fix: tin title * fix: tin title * fix: re-validation of tin field * fix: incorporated DOB fix * fix: resize issue * fix: button alignment in Tax section * fix: incorporated validation for IDV * fix: type * fix: tin validation issue * chore: added testcases for hook and tin schema * chore: added testcases to validation schema * chore: incorporated Personal details validation * chore: made tax residence mandatory * fix: submission of Real account signup data * fix: tin validation issues * fix: resolved tin validation * fix: reverted checkbox change * fix: failing testcases * fix: failing testcases * fix: removed console errors * fix: missing import * fix: missing import * fix: testcases for personal details config * chore: integrated tin auto config * fix: sending tin auto set value to BE * fix: resolved auto dirty form on load * fix: testcase checks * fix: incorporated new tin prop * fix: removed commented Tests * fix: removed commented Tests * fix: added employment status testcases * fix: sonarcloud issues * fix: failed testcases * fix: resolved sonarcloud issues * fix: added personal details validation * fix: reset testcases * fix: personal details * fix: personal details * fix: user profile testcase * fix: user profile testcase * fix: reset testcases * fix: added testcases wrt user profile * fix: MF creation form * fix: added validation for TIN when MF * fix: console error * chore: incorporated Translations and dayjs libs * fix: CSS comments * fix: tin comfirmation checkbox * fix: removed is_tin_mandatory check from Tax section * fix: displaying 0 * chore: included Account opening reason in Person details * chore: incorporated employment status update for TIN & emp status * fix: testcase * chore: added hook to trigger scroll * fix: incorporated emp status and tax restrictions * fix: added check for Tin & emp update * fix: resolved build error * added: notification * chore: added focus on Account opening reason field * fix: making tin mandatory * chore: trigger build * chore: make tin mandatory based on BE * fix: type issues * fix: tin field mandatory * fix: tin field mandatory * chore: added CSS to highlight field * fix: reverted testing changes * chore: added field focus * fix: build issues * fix: failing testcase * chore: remove unused component * chore: added missing type * fix: tin validation * fix: type failures * chore: added description * fix: incorporated review comments * fix: failing testcase * fix: incorporated review comments * fix: reverted change * chore: incorporated changes to Financial assessment * fix: updated render condition * fix: incorporated review comments * chore: disabled employment status * chore: updated quill-icon version * Merge branch 'master' into TRAH_3476/amina_likhith/add_employment_status_and_tin_to_real_account_signup * fix: package-lock * fix: failing testcase * fix: removed un-necessary condition * fix: issue TRAH-4258 * fix: TIN check for Real account creation * fix: TIN check for Real account creation * fix: data unsaved popup appearing from personal details * fix: resolved TRAH-4272, TRAH-4268 * fix: TRAH-4270 issue * fix: Personal details type * fix: reverted version --------- Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * fix: eslint errors occured during merge (#17227) * fix: destroy instead of minimize (#17229) * fix: redirection fro staging to p2p staging (#17231) (#17236) Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> * fix: idv update in real account creation (#17235) (#17239) Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * fix: misaligned employment-status field (#17242) (#17244) Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * [UPM-1679] Suisin/fix: error message alignment and spacing for inaccessible mt5 pop up … (#17192) * fix: error message alignment and spacing for inaccessible mt5 pop up modal * chore: update to have better text size for the error message * Mitra trah 3842 add deposit banner (#17233) * feat: create useStoreHasAccountDeposited hook and unit tests * refactor: move all th banners to one component * feat: intermediate result * feat: add svg images * feat: update banenr icon for responsive * feat: finished with styles for banner * feat: update ff name * refactor: change ff name again * feat: complete banner development * refactor: remove unused variable * fix: add isLoaded to hook * fix: add is_switching check for the banner * feat: undo changes * fix: 🐛 remove banner for DIEL clients * fix: 🐛 hide the banner for existing deil only --------- Co-authored-by: sergei-deriv <sergei@deriv.com> * DTRA-2035 / Kate / [DTrader-v2] Implement swiping functionality and fix TP/SL history title (#17173) * refactor: restructure config with pages * feat: add swipe handlers for carousel * fix: tests * refactor: chnage selecting title logic * refactor: make infinit loop optional * refactor: quill update * CSIT-1558/Prince/Livechat icon on testlinks (#17251) * fix: livechat icon on testlinks * fix: country data for growthbook * fix: add livechat widget call check * fix: whatsapp when freshchat is enabled --------- Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <fe-access@regentmarkets.com> Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Habib Deriv <88178645+habib-deriv@users.noreply.github.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: lubega-deriv <142860499+lubega-deriv@users.noreply.github.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Nuzhy-Deriv <nuzhy@deriv.com> Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: mitra-deriv <64970259+mitra-deriv@users.noreply.github.com> Co-authored-by: sergei-deriv <sergei@deriv.com>
prince-deriv
added a commit
that referenced
this pull request
Oct 20, 2024
* [WALL] george / WALL-4973 / Remove @deriv/ui library from cashier package (#17086) * perf(cashier): 🔥 replace deriv-ui with deriv-com/ui * chore: 📝 update package-lock * chore: update package-lock * chore: bump deriv-com/ui version * translations: 📚 sync translations with crowdin (#17165) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * fix: when remove verified number from BO, UI should update automatically (#17111) * chore: add rms to translations codeowners (#17170) * chore: add rms to translations codeowners * chore: add akmal to the codeowners * chore: update bottom disclaimer percentage (#17135) * chore: MF content update (#17154) chore: MF tnc content update * translations: 📚 sync translations with crowdin (#17175) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * Revert "Akmal / feat: change default chart style from ticks to candles (#16645)" (#17179) (#17182) This reverts commit d09f4ca. Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> * DTRA-1969 + 2061 / Kate / Translation fixes (#17081) * fix: translation for contract details reports and fixed position tab navigation * fix: add translation for buy and sell * refactor: add tests and remove extra files * chore: remove type assertion * chore: test renaming * chore: add comments * fix: set default trade type when switching to vanillas and turbos (#17159) * [BOT] sandeep/refactor: 🔥 remove binary-utils package (#17169) * refactor: 🔥 remove binary-utils package * refactor: 🔥 moved common function into binary-utils.js * fix: blank screen (#17149) * [WALL] Lubega / WALL-2928 / ModalTradeWrapper unit test (#17162) * chore: modal trade wrapper unit test * chore: modal trade wrapper unit test * [WALL] Lubega / WALL-4911 / Migrate wallets utils to deriv-com/utils (#17010) * chore: migrate utils to deriv-com/utils * fix: remove react-node-to-string * fix: update library version * translations: 📚 sync translations with crowdin (#17191) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * chore: update auth-client library (#17194) * fix: 🚑 format amount and transaction fee (#17153) * fix: removed integration package (#17201) * fix: issue with user not able resubmit poa (#17189) * chore: updated packahe version (#17202) * Update pushDataLayer to check logged in state of user (#16561) * chore: update pushDataLayer to check logged in state of user * Update packages/core/src/Stores/gtm-store.js Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> * chore: callbacks to async/await * chore: add optional chaining --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> * [UPM-1303]/evgeniy/livechat name and email not populated (#16676) * fix: [UPM-1303]/evgeniy/livechat name and email not pipulated * chore: remove comments * refactor: livechat init and usage * chore: remove old hook from redirect component * chore: add tests for hooks * fix: failing test case * chore: removed unused import * chore: update package-lock * chore: remove icons, isMounted * fix: reverted icons * fix: revert useremote default * chore: review comments, refactor appcontent * fix: lc call in cashier * chore: change name of client store new field * fix: ts error * fix: update psckage lock * fix: update deps * chore: update package-lock * fix: update package lock and fix code * fix: removed old lc_api call * fix: using old api to close opened chat after loggin out * fix: stop fetching account settings after logging out * chore: update package-lock * fix: close chat before hidding it after logout * fix: resolve conflict * fix: resolve conflicts * [UPM1539] Suisin/fix: user coming from personal detail when verified not route to TH (#17101) * fix: user coming from personal detail when verified not route to TH * chore: fix routing issue when coming from personal details page * [P2PS] - Nada/P2PS-4249/fix: staging deriv to staging p2p (#17143) * fix: staging deriv to staging p2p * fix: glitch * fix: use is p2p enabled * fix: test redirection * fix: redirection fix * fix: check for p2p standalone enabled * CSIT-1539/Prince/Release PR/Freshchat Integration + Feature Flag toggle (#17196) * chore: fresh chat integration * fix: update script url * fix: update freshchat initialization * fix: show freshchat widget by default * fix: update useFreshChat hook * chore: loaded script from use-freshchat hook * fix: token undefined issue * fix: token issue for non-loggedin user * fix: remove temp auth * fix: chat ready issue, remove user when logged out * fix: update use freshchat hook * fix: point to freshchat js * fix: test temp js * fix: update freshchat hook * fix: update freshchat hook * fix: update locale config * fix: check fcwidget available * fix: update script and condition to check widget loaded * fix: update script * fix: remove language configs * fix: point to temp js * fix: freshchat url * chore: enable feature flag based on growthbook * chore: added query param flag enabler * fix: remove console * fix: close livechat widget when freshchat is enabled --------- Co-authored-by: Nuzhy-Deriv <nuzhy@deriv.com> * [WALL] george / WALL-4404 / The Life time limit for Crypto to include USD amount (#17049) * feat(wallets): 🎨 add approximate usd amount for lifetime limit * perf(wallets): 🔥 improve lifetime transfer messages * fix(wallets): 🚑 add approximate amount in USD for reminder * fix: spelling mistake * fix: issue WEBREL-3238 (#17209) (#17215) * fix: issue WEBREL-3238 * fix: failing testcase Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * DTRA-2089 / Kate / Digit fixes (#17161) * fix: digit win percentage update * refactor: add skeleton loader for win persentage * fix: remove chard rerender on digit contract switch * refactor: tests * fix: add condition (#17118) * [BOT] Farabi/bot-2299/add-usage-tracking-for-announcements (#17186) * chore: added rudderstack track events for announcement click * chore: added announcement action and close events * fix: pass announcement name as the main title and subform names * chore: added load strategy open event on import announcement click * fix: call the open load strategy event from config * Suisin/chore: add analytics to track error events (#17070) * chore: add analytics to track error events * chore: update tracking negative scenario events actions and subform * chore: change error_message to error_code * chore: update session timeout tracking event * [TRAH- 3476]/Amina-Likhith/add employment status and tin to real account signup (#15805) * chore: incorporated the new employment status and tin info * fix: employment status form * fix: employment status form * chore: merge master * chore: created validation configs * chore: added validations * feat: separate components for tin * feat: separate components for tin * feat: separate components for tin * fix: separate component wrapper for employment status, tax residence and tin * chore: incorporated validation schema * fix: close popover in tin fileds on scrolling * chore: created employment-tax-info section * fix: style changes for Real account sign up layout * chore: add_hook_for_tin_api_call * chore: changes useTinValidation Hook * chore: changes useTinValidation Hook * chore: implemented new validation config * chore: added validation check in Real account sign up * chore: default value for tax residence * chore: made tin optional * chore: add tin validation * fix: component * fix: checkbox * fix: import * chore: updted validation schema * chore: incorporated new checkbox in validation * fix: removed console statements * fix: binded value * fix: resolved import issue * chore: removed DesktopWrapper & MobileWrapper * chore: clear tax values on checkbox click * fix: checkbox for no tax info * fix: validation issue with no tin checkbox * fix: removed unused ref * fix: title text * fix: tin title * fix: tin title * fix: re-validation of tin field * fix: incorporated DOB fix * fix: resize issue * fix: button alignment in Tax section * fix: incorporated validation for IDV * fix: type * fix: tin validation issue * chore: added testcases for hook and tin schema * chore: added testcases to validation schema * chore: incorporated Personal details validation * chore: made tax residence mandatory * fix: submission of Real account signup data * fix: tin validation issues * fix: resolved tin validation * fix: reverted checkbox change * fix: failing testcases * fix: failing testcases * fix: removed console errors * fix: missing import * fix: missing import * fix: testcases for personal details config * chore: integrated tin auto config * fix: sending tin auto set value to BE * fix: resolved auto dirty form on load * fix: testcase checks * fix: incorporated new tin prop * fix: removed commented Tests * fix: removed commented Tests * fix: added employment status testcases * fix: sonarcloud issues * fix: failed testcases * fix: resolved sonarcloud issues * fix: added personal details validation * fix: reset testcases * fix: personal details * fix: personal details * fix: user profile testcase * fix: user profile testcase * fix: reset testcases * fix: added testcases wrt user profile * fix: MF creation form * fix: added validation for TIN when MF * fix: console error * chore: incorporated Translations and dayjs libs * fix: CSS comments * fix: tin comfirmation checkbox * fix: removed is_tin_mandatory check from Tax section * fix: displaying 0 * chore: included Account opening reason in Person details * chore: incorporated employment status update for TIN & emp status * fix: testcase * chore: added hook to trigger scroll * fix: incorporated emp status and tax restrictions * fix: added check for Tin & emp update * fix: resolved build error * added: notification * chore: added focus on Account opening reason field * fix: making tin mandatory * chore: trigger build * chore: make tin mandatory based on BE * fix: type issues * fix: tin field mandatory * fix: tin field mandatory * chore: added CSS to highlight field * fix: reverted testing changes * chore: added field focus * fix: build issues * fix: failing testcase * chore: remove unused component * chore: added missing type * fix: tin validation * fix: type failures * chore: added description * fix: incorporated review comments * fix: failing testcase * fix: incorporated review comments * fix: reverted change * chore: incorporated changes to Financial assessment * fix: updated render condition * fix: incorporated review comments * chore: disabled employment status * chore: updated quill-icon version * Merge branch 'master' into TRAH_3476/amina_likhith/add_employment_status_and_tin_to_real_account_signup * fix: package-lock * fix: failing testcase * fix: removed un-necessary condition * fix: issue TRAH-4258 * fix: TIN check for Real account creation * fix: TIN check for Real account creation * fix: data unsaved popup appearing from personal details * fix: resolved TRAH-4272, TRAH-4268 * fix: TRAH-4270 issue * fix: Personal details type * fix: reverted version --------- Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * fix: eslint errors occured during merge (#17227) * fix: destroy instead of minimize (#17229) * fix: redirection fro staging to p2p staging (#17231) (#17236) Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> * fix: idv update in real account creation (#17235) (#17239) Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * fix: misaligned employment-status field (#17242) (#17244) Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * [UPM-1679] Suisin/fix: error message alignment and spacing for inaccessible mt5 pop up … (#17192) * fix: error message alignment and spacing for inaccessible mt5 pop up modal * chore: update to have better text size for the error message * Mitra trah 3842 add deposit banner (#17233) * feat: create useStoreHasAccountDeposited hook and unit tests * refactor: move all th banners to one component * feat: intermediate result * feat: add svg images * feat: update banenr icon for responsive * feat: finished with styles for banner * feat: update ff name * refactor: change ff name again * feat: complete banner development * refactor: remove unused variable * fix: add isLoaded to hook * fix: add is_switching check for the banner * feat: undo changes * fix: 🐛 remove banner for DIEL clients * fix: 🐛 hide the banner for existing deil only --------- Co-authored-by: sergei-deriv <sergei@deriv.com> * DTRA-2035 / Kate / [DTrader-v2] Implement swiping functionality and fix TP/SL history title (#17173) * refactor: restructure config with pages * feat: add swipe handlers for carousel * fix: tests * refactor: chnage selecting title logic * refactor: make infinit loop optional * refactor: quill update * CSIT-1558/Prince/Livechat icon on testlinks (#17251) * fix: livechat icon on testlinks * fix: country data for growthbook * fix: add livechat widget call check * fix: whatsapp issue on freshchats * chore: pass country to growthbook on login using cloudflare check --------- Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <fe-access@regentmarkets.com> Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Habib Deriv <88178645+habib-deriv@users.noreply.github.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: lubega-deriv <142860499+lubega-deriv@users.noreply.github.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Nuzhy-Deriv <nuzhy@deriv.com> Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: mitra-deriv <64970259+mitra-deriv@users.noreply.github.com> Co-authored-by: sergei-deriv <sergei@deriv.com>
prince-deriv
added a commit
that referenced
this pull request
Oct 21, 2024
* [WALL] george / WALL-4973 / Remove @deriv/ui library from cashier package (#17086) * perf(cashier): 🔥 replace deriv-ui with deriv-com/ui * chore: 📝 update package-lock * chore: update package-lock * chore: bump deriv-com/ui version * translations: 📚 sync translations with crowdin (#17165) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * fix: when remove verified number from BO, UI should update automatically (#17111) * chore: add rms to translations codeowners (#17170) * chore: add rms to translations codeowners * chore: add akmal to the codeowners * chore: update bottom disclaimer percentage (#17135) * chore: MF content update (#17154) chore: MF tnc content update * translations: 📚 sync translations with crowdin (#17175) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * Revert "Akmal / feat: change default chart style from ticks to candles (#16645)" (#17179) (#17182) This reverts commit d09f4ca. Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> * DTRA-1969 + 2061 / Kate / Translation fixes (#17081) * fix: translation for contract details reports and fixed position tab navigation * fix: add translation for buy and sell * refactor: add tests and remove extra files * chore: remove type assertion * chore: test renaming * chore: add comments * fix: set default trade type when switching to vanillas and turbos (#17159) * [BOT] sandeep/refactor: 🔥 remove binary-utils package (#17169) * refactor: 🔥 remove binary-utils package * refactor: 🔥 moved common function into binary-utils.js * fix: blank screen (#17149) * [WALL] Lubega / WALL-2928 / ModalTradeWrapper unit test (#17162) * chore: modal trade wrapper unit test * chore: modal trade wrapper unit test * [WALL] Lubega / WALL-4911 / Migrate wallets utils to deriv-com/utils (#17010) * chore: migrate utils to deriv-com/utils * fix: remove react-node-to-string * fix: update library version * translations: 📚 sync translations with crowdin (#17191) Co-authored-by: DerivFE <fe-access@regentmarkets.com> * chore: update auth-client library (#17194) * fix: 🚑 format amount and transaction fee (#17153) * fix: removed integration package (#17201) * fix: issue with user not able resubmit poa (#17189) * chore: updated packahe version (#17202) * Update pushDataLayer to check logged in state of user (#16561) * chore: update pushDataLayer to check logged in state of user * Update packages/core/src/Stores/gtm-store.js Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> * chore: callbacks to async/await * chore: add optional chaining --------- Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> * [UPM-1303]/evgeniy/livechat name and email not populated (#16676) * fix: [UPM-1303]/evgeniy/livechat name and email not pipulated * chore: remove comments * refactor: livechat init and usage * chore: remove old hook from redirect component * chore: add tests for hooks * fix: failing test case * chore: removed unused import * chore: update package-lock * chore: remove icons, isMounted * fix: reverted icons * fix: revert useremote default * chore: review comments, refactor appcontent * fix: lc call in cashier * chore: change name of client store new field * fix: ts error * fix: update psckage lock * fix: update deps * chore: update package-lock * fix: update package lock and fix code * fix: removed old lc_api call * fix: using old api to close opened chat after loggin out * fix: stop fetching account settings after logging out * chore: update package-lock * fix: close chat before hidding it after logout * fix: resolve conflict * fix: resolve conflicts * [UPM1539] Suisin/fix: user coming from personal detail when verified not route to TH (#17101) * fix: user coming from personal detail when verified not route to TH * chore: fix routing issue when coming from personal details page * [P2PS] - Nada/P2PS-4249/fix: staging deriv to staging p2p (#17143) * fix: staging deriv to staging p2p * fix: glitch * fix: use is p2p enabled * fix: test redirection * fix: redirection fix * fix: check for p2p standalone enabled * CSIT-1539/Prince/Release PR/Freshchat Integration + Feature Flag toggle (#17196) * chore: fresh chat integration * fix: update script url * fix: update freshchat initialization * fix: show freshchat widget by default * fix: update useFreshChat hook * chore: loaded script from use-freshchat hook * fix: token undefined issue * fix: token issue for non-loggedin user * fix: remove temp auth * fix: chat ready issue, remove user when logged out * fix: update use freshchat hook * fix: point to freshchat js * fix: test temp js * fix: update freshchat hook * fix: update freshchat hook * fix: update locale config * fix: check fcwidget available * fix: update script and condition to check widget loaded * fix: update script * fix: remove language configs * fix: point to temp js * fix: freshchat url * chore: enable feature flag based on growthbook * chore: added query param flag enabler * fix: remove console * fix: close livechat widget when freshchat is enabled --------- Co-authored-by: Nuzhy-Deriv <nuzhy@deriv.com> * [WALL] george / WALL-4404 / The Life time limit for Crypto to include USD amount (#17049) * feat(wallets): 🎨 add approximate usd amount for lifetime limit * perf(wallets): 🔥 improve lifetime transfer messages * fix(wallets): 🚑 add approximate amount in USD for reminder * fix: spelling mistake * fix: issue WEBREL-3238 (#17209) (#17215) * fix: issue WEBREL-3238 * fix: failing testcase Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * DTRA-2089 / Kate / Digit fixes (#17161) * fix: digit win percentage update * refactor: add skeleton loader for win persentage * fix: remove chard rerender on digit contract switch * refactor: tests * fix: add condition (#17118) * [BOT] Farabi/bot-2299/add-usage-tracking-for-announcements (#17186) * chore: added rudderstack track events for announcement click * chore: added announcement action and close events * fix: pass announcement name as the main title and subform names * chore: added load strategy open event on import announcement click * fix: call the open load strategy event from config * Suisin/chore: add analytics to track error events (#17070) * chore: add analytics to track error events * chore: update tracking negative scenario events actions and subform * chore: change error_message to error_code * chore: update session timeout tracking event * [TRAH- 3476]/Amina-Likhith/add employment status and tin to real account signup (#15805) * chore: incorporated the new employment status and tin info * fix: employment status form * fix: employment status form * chore: merge master * chore: created validation configs * chore: added validations * feat: separate components for tin * feat: separate components for tin * feat: separate components for tin * fix: separate component wrapper for employment status, tax residence and tin * chore: incorporated validation schema * fix: close popover in tin fileds on scrolling * chore: created employment-tax-info section * fix: style changes for Real account sign up layout * chore: add_hook_for_tin_api_call * chore: changes useTinValidation Hook * chore: changes useTinValidation Hook * chore: implemented new validation config * chore: added validation check in Real account sign up * chore: default value for tax residence * chore: made tin optional * chore: add tin validation * fix: component * fix: checkbox * fix: import * chore: updted validation schema * chore: incorporated new checkbox in validation * fix: removed console statements * fix: binded value * fix: resolved import issue * chore: removed DesktopWrapper & MobileWrapper * chore: clear tax values on checkbox click * fix: checkbox for no tax info * fix: validation issue with no tin checkbox * fix: removed unused ref * fix: title text * fix: tin title * fix: tin title * fix: re-validation of tin field * fix: incorporated DOB fix * fix: resize issue * fix: button alignment in Tax section * fix: incorporated validation for IDV * fix: type * fix: tin validation issue * chore: added testcases for hook and tin schema * chore: added testcases to validation schema * chore: incorporated Personal details validation * chore: made tax residence mandatory * fix: submission of Real account signup data * fix: tin validation issues * fix: resolved tin validation * fix: reverted checkbox change * fix: failing testcases * fix: failing testcases * fix: removed console errors * fix: missing import * fix: missing import * fix: testcases for personal details config * chore: integrated tin auto config * fix: sending tin auto set value to BE * fix: resolved auto dirty form on load * fix: testcase checks * fix: incorporated new tin prop * fix: removed commented Tests * fix: removed commented Tests * fix: added employment status testcases * fix: sonarcloud issues * fix: failed testcases * fix: resolved sonarcloud issues * fix: added personal details validation * fix: reset testcases * fix: personal details * fix: personal details * fix: user profile testcase * fix: user profile testcase * fix: reset testcases * fix: added testcases wrt user profile * fix: MF creation form * fix: added validation for TIN when MF * fix: console error * chore: incorporated Translations and dayjs libs * fix: CSS comments * fix: tin comfirmation checkbox * fix: removed is_tin_mandatory check from Tax section * fix: displaying 0 * chore: included Account opening reason in Person details * chore: incorporated employment status update for TIN & emp status * fix: testcase * chore: added hook to trigger scroll * fix: incorporated emp status and tax restrictions * fix: added check for Tin & emp update * fix: resolved build error * added: notification * chore: added focus on Account opening reason field * fix: making tin mandatory * chore: trigger build * chore: make tin mandatory based on BE * fix: type issues * fix: tin field mandatory * fix: tin field mandatory * chore: added CSS to highlight field * fix: reverted testing changes * chore: added field focus * fix: build issues * fix: failing testcase * chore: remove unused component * chore: added missing type * fix: tin validation * fix: type failures * chore: added description * fix: incorporated review comments * fix: failing testcase * fix: incorporated review comments * fix: reverted change * chore: incorporated changes to Financial assessment * fix: updated render condition * fix: incorporated review comments * chore: disabled employment status * chore: updated quill-icon version * Merge branch 'master' into TRAH_3476/amina_likhith/add_employment_status_and_tin_to_real_account_signup * fix: package-lock * fix: failing testcase * fix: removed un-necessary condition * fix: issue TRAH-4258 * fix: TIN check for Real account creation * fix: TIN check for Real account creation * fix: data unsaved popup appearing from personal details * fix: resolved TRAH-4272, TRAH-4268 * fix: TRAH-4270 issue * fix: Personal details type * fix: reverted version --------- Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * fix: eslint errors occured during merge (#17227) * fix: destroy instead of minimize (#17229) * fix: redirection fro staging to p2p staging (#17231) (#17236) Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> * fix: idv update in real account creation (#17235) (#17239) Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * fix: misaligned employment-status field (#17242) (#17244) Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> * [UPM-1679] Suisin/fix: error message alignment and spacing for inaccessible mt5 pop up … (#17192) * fix: error message alignment and spacing for inaccessible mt5 pop up modal * chore: update to have better text size for the error message * Mitra trah 3842 add deposit banner (#17233) * feat: create useStoreHasAccountDeposited hook and unit tests * refactor: move all th banners to one component * feat: intermediate result * feat: add svg images * feat: update banenr icon for responsive * feat: finished with styles for banner * feat: update ff name * refactor: change ff name again * feat: complete banner development * refactor: remove unused variable * fix: add isLoaded to hook * fix: add is_switching check for the banner * feat: undo changes * fix: 🐛 remove banner for DIEL clients * fix: 🐛 hide the banner for existing deil only --------- Co-authored-by: sergei-deriv <sergei@deriv.com> * DTRA-2035 / Kate / [DTrader-v2] Implement swiping functionality and fix TP/SL history title (#17173) * refactor: restructure config with pages * feat: add swipe handlers for carousel * fix: tests * refactor: chnage selecting title logic * refactor: make infinit loop optional * refactor: quill update * CSIT-1558/Prince/Livechat icon on testlinks (#17251) * fix: livechat icon on testlinks * fix: country data for growthbook * fix: add livechat widget call check * fix: whatsapp issue on freshchats * chore: pass country to growthbook on login using cloudflare check * fix: import issues --------- Co-authored-by: George Usynin <103181646+heorhi-deriv@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: DerivFE <fe-access@regentmarkets.com> Co-authored-by: Sui Sin <103026762+suisin-deriv@users.noreply.github.com> Co-authored-by: Jim Daniels Wasswa <104334373+jim-deriv@users.noreply.github.com> Co-authored-by: Habib Deriv <88178645+habib-deriv@users.noreply.github.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: vinu-deriv <100689171+vinu-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com> Co-authored-by: Sandeep Rajput <90243468+sandeep-deriv@users.noreply.github.com> Co-authored-by: amina-deriv <84661147+amina-deriv@users.noreply.github.com> Co-authored-by: lubega-deriv <142860499+lubega-deriv@users.noreply.github.com> Co-authored-by: thisyahlen <104053934+thisyahlen-deriv@users.noreply.github.com> Co-authored-by: Farabi <102643568+farabi-deriv@users.noreply.github.com> Co-authored-by: nada-deriv <122768621+nada-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <98398322+likhith-deriv@users.noreply.github.com> Co-authored-by: Shahzaib <shahzaib@deriv.com> Co-authored-by: Ali(Ako) Hosseini <ali.hosseini@regentmarkets.com> Co-authored-by: yauheni-deriv <103182683+yauheni-deriv@users.noreply.github.com> Co-authored-by: Nuzhy-Deriv <nuzhy@deriv.com> Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com> Co-authored-by: Likhith Kolayari <likhith@regentmarkets.com> Co-authored-by: mitra-deriv <64970259+mitra-deriv@users.noreply.github.com> Co-authored-by: sergei-deriv <sergei@deriv.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: