Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Lubega / WALL-4860 / Remove moment from wallets #16741

Merged
merged 12 commits into from
Sep 24, 2024

Conversation

lubega-deriv
Copy link
Contributor

@lubega-deriv lubega-deriv commented Sep 5, 2024

Changes:

  • Remove moment from wallets and replace with utils
  • Add other externals in webpack config to reduce bundle load

Before:

Screenshot 2024-09-05 at 12 29 42 PM

After

image

Screenshots:

Screenshot 2024-09-09 at 1 59 45 PM Screenshot 2024-09-09 at 11 20 33 AM Screenshot 2024-09-09 at 11 01 12 AM Screenshot 2024-09-09 at 11 03 11 AM

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 24, 2024 2:09am

Copy link
Contributor

github-actions bot commented Sep 9, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16741](https://github.com/binary-com/deriv-app/pull/16741)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-remove-moment-from-wallets.binary.sx?qa_server=red.derivws.com&app_id=24160
    - **Original**: https://deriv-app-git-fork-lubega-deriv-remove-moment-from-wallets.binary.sx
- **App ID**: `24160`

Copy link
Contributor

github-actions bot commented Sep 9, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 30
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with undefined

@coveralls
Copy link

coveralls commented Sep 9, 2024

Coverage Status

coverage: 52.482% (+0.1%) from 52.386%
when pulling 7d6511d on lubega-deriv:remove-moment-from-wallets
into 975321f on binary-com:master.

@lubega-deriv lubega-deriv changed the title [WALL] Remove moment from wallets [WALL] Lubega / WALL-4860 / Remove moment from wallets Sep 9, 2024
@lubega-deriv lubega-deriv marked this pull request as ready for review September 9, 2024 03:54
nijil-deriv
nijil-deriv previously approved these changes Sep 10, 2024
heorhi-deriv
heorhi-deriv previously approved these changes Sep 10, 2024
jim-deriv
jim-deriv previously approved these changes Sep 11, 2024
Copy link

sonarcloud bot commented Sep 24, 2024

Copy link
Contributor

Generating Lighthouse report...

@nijil-deriv nijil-deriv merged commit f5d708f into deriv-com:master Sep 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants