Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UPM-1431]/evgeniy/total withdrawal limit fix #16748

Conversation

yauheni-deriv
Copy link
Contributor

Changes:

num_of_days_limit is replaced to lifetime_limit as per CU card requirements

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 20, 2024 7:39am

Copy link
Contributor

github-actions bot commented Sep 5, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16748](https://github.com/binary-com/deriv-app/pull/16748)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-yauheni-deriv-account-limits-total-wi-68fb48.binary.sx?qa_server=red.derivws.com&app_id=32882
    - **Original**: https://deriv-app-git-fork-yauheni-deriv-account-limits-total-wi-68fb48.binary.sx
- **App ID**: `32882`

Copy link
Contributor

github-actions bot commented Sep 5, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-yauheni-deriv-account-limits-total-wi-68fb48.binary.sx/

@coveralls
Copy link

coveralls commented Sep 5, 2024

Coverage Status

coverage: 52.392% (+0.001%) from 52.391%
when pulling 664d59b on yauheni-deriv:account-limits/total-withdrawal-allowed
into 18f8611 on binary-com:master.

Copy link

sonarcloud bot commented Sep 20, 2024

Copy link
Contributor

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants