Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WALL] Jim/WALL-4923/update gh dependency to version 6 #16910

Merged

Conversation

jim-deriv
Copy link
Contributor

@jim-deriv jim-deriv commented Sep 20, 2024

Changes:

Updated gh-pages from 2.1.1 to 6.1.1

Changelog here

Screenshots:

Before

image

After

image

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 24, 2024 3:29am

Copy link
Contributor

github-actions bot commented Sep 20, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16910](https://github.com/binary-com/deriv-app/pull/16910)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-jim-deriv-jim-dsec-26597update-ghpage-a4bc26.binary.sx?qa_server=red.derivws.com&app_id=32795
    - **Original**: https://deriv-app-git-fork-jim-deriv-jim-dsec-26597update-ghpage-a4bc26.binary.sx
- **App ID**: `32795`

Copy link
Contributor

github-actions bot commented Sep 20, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 27
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with undefined

@coveralls
Copy link

coveralls commented Sep 20, 2024

Coverage Status

coverage: 52.447% (-0.001%) from 52.448%
when pulling 3c7eac9 on jim-deriv:jim/dsec-26597/update-ghpages-version
into 077dc75 on binary-com:master.

nijil-deriv
nijil-deriv previously approved these changes Sep 23, 2024
@jim-deriv jim-deriv changed the title chore: update gh dependency [WALL] Jim/WALL-4923/update gh dependency to version 6 Sep 23, 2024
Copy link

sonarcloud bot commented Sep 24, 2024

Copy link
Contributor

Generating Lighthouse report...

@jim-deriv jim-deriv merged commit f8824de into binary-com:master Sep 24, 2024
6 of 8 checks passed
@jim-deriv jim-deriv deleted the jim/dsec-26597/update-ghpages-version branch September 24, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants