Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DTRA-1879 / Kate / [DTrader-V2]: Implement Rise/Fall forward starting contract and change card structure #16919

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

kate-deriv
Copy link
Contributor

@kate-deriv kate-deriv commented Sep 20, 2024

Changes:

Card changes:

  • Repositioned elements in the contract card and clean unused css
  • Chore UI: icon size changed to 16px, font size for Market&Stake changed to 14px
  • Added tags for TP when it's active (will be shown for Open Positions and CD - only for open contracts)
  • Added tags for SL when it's active (will be shown for Open Positions and CD - only for open contracts)
  • Added tags for DC when it's active (will be shown for Open Positions and CD - only for open contracts, when DC is active)
  • Removed duration tag from Multipliers contracts EXCEPT crypto markets
  • Covered changed with tests

Forward starting contract:

  • Created a tag for contract card with information about start time (Open Positions, Contract Details).
  • Added a banner for Contract Details with information about start time and count down timer. Banner sticked to the top and be visible during scrolling.
  • As Barrier information for forward staring contract is not available, it will be replaced with 'TBD' in Contract Details
  • Covered changed with tests

Additionally:

  • Rename Stop Loss --> Stop loss (in CD)
  • Removed extra card wrapper
  • Changed History title. Now it can be TP history, SL history or TP & SL history based on what exactly was changed.
  • Chore UI: add padding bottom to Positions page

Screenshots:

Screenshot 2024-09-23 at 5 32 45 PM
Screenshot 2024-09-23 at 5 33 08 PM
Screenshot 2024-09-23 at 5 33 18 PM
Screenshot 2024-09-23 at 5 33 35 PM
Screenshot 2024-09-23 at 5 37 43 PM
Screenshot 2024-09-23 at 5 38 02 PM
Screenshot 2024-09-23 at 5 38 19 PM
Screenshot 2024-09-23 at 5 37 08 PM
Screenshot 2024-09-23 at 5 36 45 PM

@boring-cyborg boring-cyborg bot added the Trader label Sep 20, 2024
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 23, 2024 2:10pm

Copy link
Contributor

github-actions bot commented Sep 20, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/16919](https://github.com/binary-com/deriv-app/pull/16919)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-kate-deriv-kate-dtra-1879forwardstart-62792e.binary.sx?qa_server=red.derivws.com&app_id=24064
    - **Original**: https://deriv-app-git-fork-kate-deriv-kate-dtra-1879forwardstart-62792e.binary.sx
- **App ID**: `24064`

Copy link
Contributor

github-actions bot commented Sep 20, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-1879forwardstart-62792e.binary.sx/

@coveralls
Copy link

coveralls commented Sep 20, 2024

Coverage Status

coverage: 52.497% (+0.06%) from 52.438%
when pulling 3588318 on kate-deriv:kate/DTRA-1879/forward_starting_support
into ed76221 on binary-com:master.

Copy link

sonarcloud bot commented Sep 23, 2024

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Generating Lighthouse report...

@@ -83,9 +84,8 @@ const ContractDetails = observer(() => {
'contract-details--one-button': shouldShowSell && !showCancelButton,
})}
>
<div className='contract-card-wrapper'>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside of ContractCard there is a wrapper with same className

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants