Aum/prodqa 38/client redirection to correct withdrawal page using loginid #9017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-aum-deriv-aum-prodqa-38client-redirec-f23b33.binary.sx/ |
…DQA-38/client-redirection-to-correct-withdrawal-page-using-loginid
Codecov Report
@@ Coverage Diff @@
## master #9017 +/- ##
======================================
Coverage 0.05% 0.05%
======================================
Files 117 117
Lines 3425 3422 -3
Branches 893 891 -2
======================================
Hits 2 2
+ Misses 3423 3420 -3 |
…DQA-38/client-redirection-to-correct-withdrawal-page-using-loginid
…DQA-38/client-redirection-to-correct-withdrawal-page-using-loginid
heorhi-deriv
approved these changes
Jun 20, 2023
packages/core/src/App/Containers/Redirect/__tests__/redirect.spec.jsx
Outdated
Show resolved
Hide resolved
farzin-deriv
previously approved these changes
Jun 21, 2023
heorhi-deriv
approved these changes
Jun 21, 2023
nijil-deriv
previously approved these changes
Jun 21, 2023
farzin-deriv
previously approved these changes
Jun 21, 2023
shayan-deriv
approved these changes
Jun 21, 2023
…DQA-38/client-redirection-to-correct-withdrawal-page-using-loginid
…DQA-38/client-redirection-to-correct-withdrawal-page-using-loginid
nijil-deriv
reviewed
Jul 3, 2023
| @@ -1573,6 +1573,7 @@ export default class ClientStore extends BaseStore { | |||
| const redirect_url = search_params?.get('redirect_url'); | |||
| const code_param = search_params?.get('code'); | |||
| const action_param = search_params?.get('action'); | |||
| const loginid_param = search_params.get('loginid'); | |||
There was a problem hiding this comment.
Suggested change
| const loginid_param = search_params.get('loginid'); | |
| const loginid_param = search_params?.get('loginid'); |
farzin-deriv
previously approved these changes
Jul 4, 2023
…DQA-38/client-redirection-to-correct-withdrawal-page-using-loginid
|
Kudos, SonarCloud Quality Gate passed!
|
|
⏳ Generating Lighthouse report... |
nijil-deriv
approved these changes
Jul 4, 2023
|
✨ PR has been merged by Paimon the Release Bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Please provide a summary of the change.
Screenshots:
Please provide some screenshots of the change.