Vinu/fix: fixed minor code smells in bot-web-ui #9822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-vinu-deriv-vinu-304fix-minor-code-smells.binary.sx/ |
vinu-deriv
requested review from
ali-hosseini-deriv,
matin-deriv,
maryia-deriv,
prince-deriv and
sandeep-deriv
as code owners
farzin-deriv
previously approved these changes
Aug 25, 2023
shafin-deriv
approved these changes
Aug 28, 2023
sandeep-deriv
previously approved these changes
Aug 28, 2023
vinu-deriv
dismissed stale reviews from sandeep-deriv and farzin-deriv
via
faa5125
sandeep-deriv
previously approved these changes
Aug 28, 2023
farabi-deriv
approved these changes
Aug 28, 2023
* chore: added useSettings to @deriv/api * chore: combine get_settings with set_settings * refactor: change function name * chore: return all mutation data * chore: export hook * refactor: types and mutation function name
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
* fix(cashier): 🐛 fix unable to access CFD-DerivX transfer * feat(wallets): 📦 add `@deriv/wallets` workspace * fix(wallets): 💚 fix CI build * feat(api): ✨ share a single instance of `QueryClient` in `APIProvider` * Merge branch 'master' into farzin/next --------- Co-authored-by: Farzin Mirzaie <farzin@deriv.com>
…#9785) * feat: added use-authorize hook taken from sergei pr Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> * chore: sorted imports for use-authorize Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com> * chore: moved default empty string in use-authorize * chore: incorporated code reviews * chore: added useLandingCompany into api package * chore: added useSettings to @deriv/api * chore: get country_code from user settings instead of authorize * chore: combine get_settings with set_settings * fix: change request type for landing_company * chore: combine get_settings with set_settings * refactor: change function name * chore: add missing dependencies for useLandingCompany return data * chore: return all mutation data * chore: export hook * refactor: types and mutation function name * refactor: use-landing-company-hook * fix: remove dependency --------- Co-authored-by: adrienne-rio <adrienne@deriv.com> Co-authored-by: Sergei Baranovski <120570511+sergei-deriv@users.noreply.github.com>
… off (binary-com#9876) * chore: fixed sort dropdown alignment * chore: changed styling for dropdown
…m#9908) * fix: 🚑 fix active container for TH transfer, fix insufficient balance check * test: 🐛 fix tests * fix: 🚑 fix 'Insufficient balance' condition
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
…ary-com#9611) * feat: initializing the compare account implementation * feat: icon reusable component v1.0 * feat: icon reusable component v1.1 * feat: icon reusable component v1.1.1 * feat: initialize compare cfd account page (todo:css) * feat: blank compare cfd accounts page & navi done * feat: mobile view * fix: compare-accounts naming convention * fix: updated path import * fix: reverted icons.js changes * fix: compare-cfds -> compare-accounts * feat: reusable component v1.2 * feat: reusable component v1.2.1 * feat: icon reusable component added v1.3 * feat: reusable component for Icons * feat: reusable component for Icons refactor * feat: reusable component for Icons refactor v1.2 * feat: description div added * feat: description with title +icon is added * feat: platform label + icon component padding added * chore: labuan leverage updated * chore: css issue fixed for Cards * feat: carousel added with sorting o f MT5 accounts * feat: carousel arrow background and container added * chore: added dxtrade in the card for dynamic rendering with type fixes * chore: changes in platform label header with respect to props data * chore: icons updated because of white line issue in icons * chore: change the components css name and other naming convention tweaks * refactor: suggestions implemented * refactor: convert carousel button into one * feat: initial commit for starting collaboration * feat: added the button placeholder * feat: added new banner to cfd cards * refactor: make the banner smaller * fix: added condition to show banner for derivez and ctrader only * refactor: changed the types and applied suggestions * refactor: removed the invalide shortcode for dxtrade * refactor: round up patches based on reviews * fix: round up patch 2 based on review * Update packages/cfd/src/Containers/cfd-compare-accounts/cfd-compare-accounts.scss Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com> * refactor: button width * refactor: button classname * chore: fix css of underline * chore: added redirection to homepage in case of modals * fix: circle ci failed due to wrong type of client function * chore: added the disabled property for the Added accounts * chore: added condition for the dxtrade * chore: rearrange block scoped variables * chore: fix css of labuan tooltip with removal of commented code * chore: responsive view fixes * feat: demo accounts added for low risk * feat: demo accounts label added and swap-free account creation fixed * chore: added derivx account creation flow * refactor: replace ternary operators with if-else * chore: remove unused jurisdiction * feat: demo account compare implemetation tweaks as per design * feat: rectified the Demo title as per design * chore: font weigth of instruments as per design * feat: Eu flow for DIEL * feat: changes in the icons label and correction in EU flow * chore: addded translations demo title and rename baskets * chore: rename icon type * chore: final changes prop drilling instead of observer EU flow finalized * fix: hidding deriv ez * fix: EU flow platform label change * feat: test case for description added * feat: platform label test case added * feat: title icon test case added * feat: title icon test case added * chore: fix test case description + instruments icon test added * refactor: blank spaces removed * chore: cfd-instruments-label test added * chore: test file added cfd-instrument-label * feat: button partial test case added * chore: added more test case for Button component * feat: added test case for compare-account-card * chore: merge conflicts * chore: test for cfd-compare-accounts added * feat: derivX demo * chore: added testcase for dxtrade in button * fix: dxtrade for australian clients * fix: swapfree account creation added * fix: comapre account fixes first round * fix: remove the css because scroll not working * fix: renamed variable + icons * fix: cursor not allowed on instrument icons * fix: fixed the circle ci issue * fix: fixed one of our test issues * refactor: review comments resolved * fix: changing the text of mf accounts to pass the tests * fix: made changes according to suggestions * fix: made changes according to suggestions * fix: fixed the test case issues * chore: added s to spread(s) * chore: fixed capitalization * chore: line split * fix: failing test case * fix: updated markets offerings for MT5 Financial Labuan * fix: Other CFDs --> Other CFDs Platform * fix: removed standard/micro from DerivX Forex label * refactor: optimised code * fix: icon size inconsistencyn mobile VP * refactor: css refactoring to reflect figma as much as possible * refactor: minor css fixes * fix: fixed * style: added bottom padding for mobile * fix: fixed the build issue * chore: re running the tests * fix: subtasks * chore: typo * style: position the tooltip to be center within the card * style: resize width for word-wrap * chore: d and r should be lowercase dispute and resolution * fix: fixing sonar cloud issues * fix: making changes to pass the tests --------- Co-authored-by: hamza-deriv <hamza.muhammad@regentmarkets.com> Co-authored-by: shontzu-deriv <shon.tzu@regentmarkets.com> Co-authored-by: shontzu <108507236+shontzu-deriv@users.noreply.github.com> Co-authored-by: Muhammad Hamza <120543468+hamza-deriv@users.noreply.github.com>
…s variables (binary-com#9877) * feat: added stylelint for wallets for bem convention * feat: added stylelint for wallets for bem convention * chore: added import sorts for wallets and bem convention checking * chore: removed unused dependencies in wallets
…inary-com#9314) * chore: Dynamic leverage for MT5 financial accounts initial commit * feat: 🚧 dynamic leverage modal * test: unit tests * feat: ✅ added unit tests and refactoring * feat: ♻️ fixed UI * feat: ♻️ review changes for dynamic leverage * chore: item name update * feat: 🐛 passed string to localize instead of a variable * test: ♻️ * refactor: ♻️ refactored column header to new component * refactor: refactored code * fix: fixed styling and refactored code * style: formatted code * test: updated test mock component * refactor: refactored styling and unit tests * fix: fixed text content for dynamic leverage * fix: fixed localize component usage * refactor: used strong instead of span styling * fix: jurisdiction card layout --------- Co-authored-by: arshad-rao-deriv <muhammad.arshad@deriv.com> Co-authored-by: mahdiyeh-deriv <82078941+mahdiyeh-deriv@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
Co-authored-by: DerivFE <80095553+DerivFE@users.noreply.github.com>
vinu-deriv
requested review from
farrah-deriv and
nijil-deriv
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
prince-deriv
approved these changes
Sep 21, 2023
farabi-deriv
approved these changes
Sep 21, 2023
shafin-deriv
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Removed the minor code smells across bot-web-ui package
Screenshots:
Please provide some screenshots of the change.