Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ameerul /P2PS-1577 Change the maximum file upload size to 5 MB in POT popup for FE #10320

Conversation

ameerul-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

  • Changed maximum upload size for POT from 2MB to 5MB to match mobile team
  • Updated strings and test cases where it referenced 2MB

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Sep 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Sep 27, 2023 2:40am

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
9.7% 9.7% Duplication

@github-actions
Copy link
Contributor

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10320](https://github.com/binary-com/deriv-app/pull/10320)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ameerul-deriv-p2ps-1577-change-file-u-eeb70a.binary.sx?qa_server=red.binaryws.com&app_id=24089
    - **Original**: https://deriv-app-git-fork-ameerul-deriv-p2ps-1577-change-file-u-eeb70a.binary.sx
- **App ID**: `24089`

@github-actions
Copy link
Contributor

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 22
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-ameerul-deriv-p2ps-1577-change-file-u-eeb70a.binary.sx/

@coveralls
Copy link

Coverage Status

coverage: 10.924%. remained the same when pulling 5386cb2 on ameerul-deriv:P2PS-1577-change-file-upload-size-to-5-mb into 612a122 on binary-com:master.

@sandeep-deriv sandeep-deriv merged commit c37a823 into deriv-com:master Oct 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants