Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Farabi/bot-726/fix snackbar shown on opening gdrive #10406

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Farabi/bot-726/fix snackbar shown on opening gdrive #10406

merged 2 commits into from
Oct 11, 2023

Conversation

farabi-deriv
Copy link
Contributor

Changes:

Removed setOpenSettings method from onDriveOpen and added to createLoadFilePicker

@boring-cyborg boring-cyborg bot added the Bot label Oct 2, 2023
@vercel
Copy link

vercel bot commented Oct 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 2, 2023 4:29am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10406](https://github.com/binary-com/deriv-app/pull/10406)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-726fix-snackb-1d21ca.binary.sx?qa_server=red.binaryws.com&app_id=24061
    - **Original**: https://deriv-app-git-fork-farabi-deriv-farabi-bot-726fix-snackb-1d21ca.binary.sx
- **App ID**: `24061`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-farabi-deriv-farabi-bot-726fix-snackb-1d21ca.binary.sx/

@sonarcloud
Copy link

sonarcloud bot commented Oct 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.1% 4.1% Duplication

@vinu-deriv vinu-deriv merged commit cf6c6cd into deriv-com:master Oct 11, 2023
5 checks passed
vinu-deriv added a commit that referenced this pull request Oct 12, 2023
@vinu-deriv
Revert "fix: updated import toast from gdrive open to file picker (#1…
f6ae2b5 
…0406)"

This reverts commit cf6c6cd.
@vinu-deriv vinu-deriv mentioned this pull request Oct 12, 2023
Merged
vinu-deriv added a commit that referenced this pull request Oct 12, 2023
@vinu-deriv
Revert "fix: updated import toast from gdrive open to file picker (#1…
5958112 
…0406)" (#10636)

This reverts commit cf6c6cd.
vinu-deriv added a commit that referenced this pull request Oct 12, 2023
@vinu-deriv
Revert "Revert "fix: updated import toast from gdrive open to file pi…
044c5ed 
…cker (#10406)" (#10636)"

This reverts commit 5958112.
vinu-deriv added a commit that referenced this pull request Oct 12, 2023
@vinu-deriv
Revert "Revert "fix: updated import toast from gdrive open to file pi…
2b8dc76 
…cker (#10406)" (#10636)" (#10638)

This reverts commit 5958112.
vinu-deriv added a commit that referenced this pull request Oct 12, 2023
@vinu-deriv
Revert "Revert "Revert "fix: updated import toast from gdrive open to…
1fcec72 
… file picker (#10406)" (#10636)" (#10638)"

This reverts commit 2b8dc76.
vinu-deriv added a commit that referenced this pull request Oct 12, 2023
@vinu-deriv
Revert "Revert "Revert "fix: updated import toast from gdrive open to…
9959d1a 
… file picker (#10406)" (#10636)" (#10638)" (#10641)

This reverts commit 2b8dc76.
vinu-deriv added a commit that referenced this pull request Oct 13, 2023
@vinu-deriv
Revert "Revert "Revert "Revert "fix: updated import toast from gdrive…
40f6c45 
… open to file picker (#10406)" (#10636)" (#10638)" (#10641)"

This reverts commit 9959d1a.
hirad-deriv pushed a commit that referenced this pull request Oct 17, 2023
@vinu-deriv
Revert "Revert "Revert "Revert "fix: updated import toast from gdrive…
ba53b73 
… open to file picker (#10406)" (#10636)" (#10638)" (#10641)" (#10662)

This reverts commit 9959d1a.
vinu-deriv pushed a commit that referenced this pull request Oct 17, 2023
@farabi-deriv @vinu-deriv
fix: updated import toast from gdrive open to file picker (#10406)
838b5d6
vinu-deriv added a commit that referenced this pull request Oct 17, 2023
@vinu-deriv
Revert "fix: updated import toast from gdrive open to file picker (#1…
2d564ca 
…0406)" (#10636)

This reverts commit cf6c6cd.
vinu-deriv added a commit that referenced this pull request Oct 17, 2023
@vinu-deriv
Revert "Revert "fix: updated import toast from gdrive open to file pi…
723dc4b 
…cker (#10406)" (#10636)" (#10638)

This reverts commit 5958112.
vinu-deriv added a commit that referenced this pull request Oct 17, 2023
@vinu-deriv
Revert "Revert "Revert "fix: updated import toast from gdrive open to…
337ff2f 
… file picker (#10406)" (#10636)" (#10638)" (#10641)

This reverts commit 2b8dc76.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinu-deriv vinu-deriv vinu-deriv approved these changes

@rupato-deriv rupato-deriv rupato-deriv approved these changes

@prince-deriv prince-deriv Awaiting requested review from prince-deriv

@sandeep-deriv sandeep-deriv Awaiting requested review from sandeep-deriv sandeep-deriv is a code owner

Assignees
No one assigned
Labels
Bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@farabi-deriv @rupato-deriv @vinu-deriv