Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ako/ Disable import sort order auto-fix temporarily #10552

Conversation

ali-hosseini-deriv
Copy link
Member

@ali-hosseini-deriv ali-hosseini-deriv commented Oct 9, 2023

Changes:

This is causing lots of issues, Disabling the rule temporarily to fix in the next step.

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 9, 2023 11:21am

@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.7% 7.7% Duplication

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10552](https://github.com/binary-com/deriv-app/pull/10552)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-temporarily-di-b86d05.binary.sx?qa_server=red.binaryws.com&app_id=24095
    - **Original**: https://deriv-app-git-fork-ali-hosseini-deriv-ako-temporarily-di-b86d05.binary.sx
- **App ID**: `24095`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 21
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟢 PWA 90

Lighthouse ran with https://deriv-app-git-fork-ali-hosseini-deriv-ako-temporarily-di-b86d05.binary.sx/

@coveralls
Copy link

coveralls commented Oct 9, 2023

Coverage Status

coverage: 25.291%. remained the same when pulling 83052cc on ali-hosseini-deriv:ako/temporarily-disable-sort-order-autofix into d54d012 on binary-com:master.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Generating Lighthouse report...

@ali-hosseini-deriv ali-hosseini-deriv merged commit 797dd31 into deriv-com:master Oct 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants