Sandeep/bot 398/quick strategy refactor 2 #10615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-sandeep-deriv-sandeep-bot-398quick-st-f7b764.binary.sx/ |
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | e54aaa5 | nx.json | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
|
SonarCloud Quality Gate failed.
|
…uick-strategy-refacotor-2
…on mobile responsive
vinu-deriv
previously approved these changes
Oct 23, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
packages/bot-web-ui/src/components/quick-strategy/form-wrappers/mobile-form-wrapper.tsx
Show resolved
Hide resolved
prince-deriv
approved these changes
Oct 23, 2023
rupato-deriv
approved these changes
Oct 23, 2023
aum-deriv
pushed a commit
to aum-deriv/deriv-app
that referenced
this pull request
Oct 24, 2023
* refactor: 🔥 quick strategy refactor -- working on the desktop dialog design * refactor: working on quick strategy redesign * refactor: working on quick strategy dynamic form * refactor: working on QS dynamic form * refactor: quick strategy finalizing * refactor: adding missing test coverage and fixed minor issues * refactor: updated names in the store with the params in the quick strategy * refactor: adding test cases for the newly added quick strategy components * chore: reverted changes to the unrelated component * refactor: working on quick strategy component test coverage * chore: added back the reverted change * chore: added back the reverted change * refactor: added remaining test case for quick strategy * refactor: added interface for quick-strategy-store-1 * refactor: removed duplicate import statement * refactor: quick strategy, updated breaking test suits * refactor: quick strategy fallback to first symbol if default symbol is not available * refactor: quick strategy - wrapped qs-input-label with store observer * refactor: quick-strategy - initialize trade_type and duration_value error on change of symbol * refactor: quick-strategy - is_strategy_modal_open is replaced with is_open * refactor: quick-strategy - linked setFormVisibility with dashboard tile * refactor: quick-strategy cleanup the old store and components * refactor: quick-strategy updated test cases * refactor: quick-strategy fixing minor ui issues * refactor: quick-strategy - updated tooltip messages for unit * refactor: quick-strategy - fixed minor ui bugs and round off * refactor: quick-strategy alignment and reset form fix * refactor: quick-strategy fixed run/edit issue and test update * refactor: quick-strategy - form field should be required * refactor: quick-strategy updated qs description * refactor: quick-strategy - added input mode to stop showing keyboard on mobile responsive * refactor: quick-strategy - fixed edit button disable issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Quick-Strategy (Including Mobile Responsive)
Screenshots:
Mobile Responsive:
With error message:
Desktop
With error message:
