Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[42069] Farhan/Dropdown Component #10723

Merged
merged 11 commits into from
Oct 24, 2023
Merged

[42069] Farhan/Dropdown Component #10723

merged 11 commits into from
Oct 24, 2023

Conversation

farhan-nurzi-deriv
Copy link
Contributor

@farhan-nurzi-deriv farhan-nurzi-deriv commented Oct 17, 2023 •
edited
Loading

Changes:

Please provide a summary of the change.

Screenshots:

Screen.Recording.2023-10-17.at.12.33.48.PM.mov

@vercel
Copy link

vercel bot commented Oct 17, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 24, 2023 5:08am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/10723](https://github.com/binary-com/deriv-app/pull/10723)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-dropdown-component.binary.sx?qa_server=red.binaryws.com&app_id=31468
    - **Original**: https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-dropdown-component.binary.sx
- **App ID**: `31468`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟢 Best practices 92
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-farhan-nurzi-deriv-farhan-dropdown-component.binary.sx/

@coveralls
Copy link

coveralls commented Oct 17, 2023 •
edited
Loading

Coverage Status

coverage: 26.752%. remained the same when pulling f7e05b6 on farhan-nurzi-deriv:farhan/dropdown-component into e0de128 on binary-com:master.

sergei-deriv
sergei-deriv approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@sergei-deriv sergei-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's ok to use 3rd party library for combobox then LGTM

wojciech-deriv
wojciech-deriv previously approved these changes Oct 17, 2023
View reviewed changes
aizad-deriv
aizad-deriv approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@aizad-deriv aizad-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wojciech-deriv
wojciech-deriv previously approved these changes Oct 18, 2023
View reviewed changes
wojciech-deriv
wojciech-deriv previously approved these changes Oct 19, 2023
View reviewed changes
yashim-deriv
yashim-deriv requested changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@yashim-deriv yashim-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For localization support (maybe)

packages/wallets/src/components/Base/WalletDropdown/WalletDropdown.tsx Outdated Show resolved Hide resolved
packages/wallets/src/components/Base/WalletDropdown/WalletDropdown.tsx Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 41 Code Smells

No Coverage information No Coverage information
5.2% 5.2% Duplication

@yashim-deriv yashim-deriv merged commit b87a1eb into deriv-com:master Oct 24, 2023
6 checks passed
aum-deriv pushed a commit to aum-deriv/deriv-app that referenced this pull request Oct 24, 2023
@farhan-nurzi-deriv @aum-deriv
farhan/feat: Dropdown Component (deriv-com#10723)
024f9ba 
* feat: created dropdown component

* chore: remove icon right padding, cleaning styles

* chore: add transition to icon

* refactor: styles

* chore: default selected item prop

* chore: make onselect required

* chore: changes dropdown styles

* chore: change types create a util
likhith-deriv pushed a commit to likhith-deriv/deriv-app that referenced this pull request Oct 25, 2023
@farhan-nurzi-deriv @likhith-deriv
farhan/feat: Dropdown Component (deriv-com#10723)
0dc3dc0 
* feat: created dropdown component

* chore: remove icon right padding, cleaning styles

* chore: add transition to icon

* refactor: styles

* chore: default selected item prop

* chore: make onselect required

* chore: changes dropdown styles

* chore: change types create a util
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergei-deriv sergei-deriv sergei-deriv approved these changes

@thisyahlen-deriv thisyahlen-deriv thisyahlen-deriv approved these changes

@aizad-deriv aizad-deriv aizad-deriv approved these changes

@yashim-deriv yashim-deriv yashim-deriv approved these changes

@wojciech-deriv wojciech-deriv wojciech-deriv left review comments

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@farhan-nurzi-deriv @coveralls @yashim-deriv @aizad-deriv @thisyahlen-deriv @sergei-deriv @wojciech-deriv @Farhan-slurrp