Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amir/CRO-59-Virtual-Signup-Tracking-Flow #10735

Conversation

amir-deriv
Copy link
Contributor

@amir-deriv amir-deriv commented Oct 17, 2023

Changes:

  • Implement Rudderstack track events for the virtual signup flow
  • Removes the old monorepo of @deriv/analytics and replaced it with our npm package @deriv/analytics

Screenshots:

Please provide some screenshots of the change.

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Oct 27, 2023 9:47am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/binary-com/deriv-app/pull/10735](https://github.com/binary-com/deriv-app/pull/10735)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amir-deriv-amir-cro-59-virtual-signup-c32d3e.binary.sx?qa_server=red.derivws.com&app_id=24165
    - **Original**: https://deriv-app-git-fork-amir-deriv-amir-cro-59-virtual-signup-c32d3e.binary.sx
- **App ID**: `24165`

@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2023

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 15
🟧 Accessibility 75
🟧 Best practices 83
🟧 SEO 85
🟧 PWA 80

Lighthouse ran with https://deriv-app-git-fork-amir-deriv-amir-cro-59-virtual-signup-c32d3e.binary.sx/

packages/core/src/App/Containers/Layout/app-contents.jsx Outdated Show resolved Hide resolved
packages/core/src/Stores/client-store.js Outdated Show resolved Hide resolved
packages/core/src/Stores/client-store.js Show resolved Hide resolved
packages/core/src/Stores/client-store.js Show resolved Hide resolved
packages/core/src/Stores/client-store.js Outdated Show resolved Hide resolved
packages/core/src/Stores/contract-replay-store.js Outdated Show resolved Hide resolved
packages/trader/package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@NikitK-deriv NikitK-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without init, package won't work
please follow example from package doc

Analytics?.initialise({ growthbookKey: process.env.GROWTHBOOK_CLIENT_KEY, growthbookDecryptionKey: process.env.GROWTHBOOK_DECRYPTION_KEY, enableDevMode: process.env.NODE_ENV !== 'production', rudderstackKey: process.env.NODE_ENV !== 'production' ? process.env.RUDDERSTACK_STAGING_KEY : process.env.RUDDERSTACK_PRODUCTION_KEY, })

@coveralls
Copy link

Coverage Status

coverage: 26.882% (-0.05%) from 26.928% when pulling 85f4642 on amir-deriv:amir/cro-59-virtual-signup-tracking-flow into 9557e85 on binary-com:master.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
6.7% 6.7% Duplication

@ali-hosseini-deriv ali-hosseini-deriv merged commit 29d3c01 into deriv-com:master Oct 27, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants